CloudApiBase::getLinkedResource() - Code Metrics - Inspection of "Add linked resources" - typhonius/acquia-php-sdk-v2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#111)

by Adam
created 2020-11-22 22:13 UTC
CloudApiBase::getLinkedResource() D

↳ Parent: CloudApiBase
Complexity

Conditions	21
Paths	21
Size

Total Lines	109
Code Lines	83
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	21
eloc	83
nc	21
nop	1
dl	0
loc	109
rs	4.1666
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

namespace AcquiaCloudApi\Endpoints;

use AcquiaCloudApi\Connector\ClientInterface;

/**
 * Class CloudApiBase
 *
 * @package AcquiaCloudApi\CloudApi
 */
abstract class CloudApiBase implements CloudApiInterface
{

    /**
     * @var ClientInterface The API client.
     */
    protected $client;

    /**
     * Client constructor.
     *
     * @param ClientInterface $client
     */
    public function __construct(ClientInterface $client)
    {
        $this->client = $client;
    }

    /**
     * @param array{type:string, path:string} $link
     * @return mixed
     */
    public function getLinkedResource($link)
    {
        // Remove https://cloud.acquia.com/api from the path as this is already added by the Connector.
        $path = substr($link['path'], 28);

        switch ($link['type']) {
            case 'alerts':
                return new \AcquiaCloudApi\Response\InsightAlertsResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'applications':
                return new \AcquiaCloudApi\Response\ApplicationsResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'backups':
                return new \AcquiaCloudApi\Response\BackupsResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'code':
                return new \AcquiaCloudApi\Response\BranchesResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'crons':
                return new \AcquiaCloudApi\Response\CronsResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'databases':
                return new \AcquiaCloudApi\Response\DatabasesResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'domains':
                return new \AcquiaCloudApi\Response\DomainsResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'environments':
                return new \AcquiaCloudApi\Response\EnvironmentsResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'ides':
                return new \AcquiaCloudApi\Response\IdesResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'insight':
                return new \AcquiaCloudApi\Response\InsightsResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'logs':
                return new \AcquiaCloudApi\Response\LogsResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'members':
                return new \AcquiaCloudApi\Response\MembersResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'metrics':
                return new \AcquiaCloudApi\Response\MetricsResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'modules':
                return new \AcquiaCloudApi\Response\InsightModulesResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'notification':
                return new \AcquiaCloudApi\Response\NotificationResponse(
                    $this->client->request('get', $path)
                );
            break;
            case 'permissions':
                return new \AcquiaCloudApi\Response\PermissionsResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'servers':
                return new \AcquiaCloudApi\Response\ServersResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'ssl':
                return new \AcquiaCloudApi\Response\SslCertificatesResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'teams':
                return new \AcquiaCloudApi\Response\TeamsResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
            case 'variables':
                return new \AcquiaCloudApi\Response\VariablesResponse(
                    $this->client->request('get', $path)
                    /** @scrutinizer ignore-type */ $this->client->request('get', $path)
                );
            break;
        }

        throw new \Exception('Not found');
    }
}

typhonius / acquia-php-sdk-v2

Pull Request — master (#111)

CloudApiBase::getLinkedResource() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
