AcquiaCloudApi\Endpoints\Role

Complexity

Total Complexity

3

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	deleteRole()	0	3	1
A	updateRole()	0	10	1
A	__construct()	0	3	1

<?php

namespace AcquiaCloudApi\Endpoints;

use AcquiaCloudApi\Connector\ClientInterface;
use AcquiaCloudApi\Response\ApplicationResponse;
use AcquiaCloudApi\Response\ApplicationsResponse;
use AcquiaCloudApi\Response\RolesResponse;
use AcquiaCloudApi\Response\OperationResponse;

/**
 * Class Client
 * @package AcquiaCloudApi\CloudApi
 */
class Role implements CloudApi
{

    /**
     * Client constructor.
     *
     * @param ConnectorInterface $connector

The type AcquiaCloudApi\Endpoints\ConnectorInterface was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function __construct(ClientInterface $client)
    {
        $this->client = $client;

The property client does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Update the permissions associated with a role.
     *
     * @param string $roleUuid
     * @param array  $permissions
     * @return OperationResponse
     */
    public function updateRole($roleUuid, array $permissions)
    {
        $options = [
            'form_params' => [
                'permissions' => $permissions,
            ],
        ];

        return new OperationResponse(
            $this->client->request('put', "/roles/${roleUuid}", $options)

It seems like $this->client->request('put', '/roles/'.$roleUuid, $options) can also be of type array; however, parameter $operation of AcquiaCloudApi\Response\OperationResponse::__construct() does only seem to accept object, maybe add an additional type check?

        );
    }

    /**
     * Delete a role.
     *
     * @param string $roleUuid
     * @return OperationResponse
     */
    public function deleteRole($roleUuid)
    {
        return new OperationResponse($this->client->request('delete', "/roles/${roleUuid}"));

It seems like $this->client->request('delete', '/roles/'.$roleUuid) can also be of type array; however, parameter $operation of AcquiaCloudApi\Response\OperationResponse::__construct() does only seem to accept object, maybe add an additional type check?

    }
}