AdminBundle\Tests\Controller\LicenseeControllerTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	71
Duplicated Lines	11.27 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	createLicenseeRepositoryMock()	8	8	1
A	testLicenseeActionWithOneLicensee()	0	15	1
A	setUp()	0	5	1
A	testLicenseeActionWithNoLicensees()	0	11	1

<?php
/* Copyright (C) 2017 Michael Giesler
 *
 * This file is part of Dembelo.
 *
 * Dembelo is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * Dembelo is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License 3 for more details.
 *
 * You should have received a copy of the GNU Affero General Public License 3
 * along with Dembelo. If not, see <http://www.gnu.org/licenses/>.
 */

namespace AdminBundle\Tests\Controller;

use AdminBundle\Controller\LicenseeController;
use DembeloMain\Document\Licensee;
use DembeloMain\Model\Repository\Doctrine\ODM\LicenseeRepository;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\HttpFoundation\Response;

/**
 * Class LicenseeControllerTest
 * @package AdminBundle\Tests\Controller
 */
class LicenseeControllerTest extends WebTestCase
{
    /**
     * @var LicenseeController
     */
    private $controller;

    /**
     * @var \PHPUnit_Framework_MockObject_MockObject|LicenseeRepository
     */
    private $licenseeRepositoryMock;

    /**
     * @return void
     */
    protected function setUp(): void
    {
        $this->licenseeRepositoryMock = $this->createLicenseeRepositoryMock();

        $this->controller = new LicenseeController($this->licenseeRepositoryMock);
    }

    /**
     * tests licenseeAction with no licensees
     * @return void
     */
    public function testLicenseeActionWithNoLicensees(): void
    {
        $this->licenseeRepositoryMock->expects($this->once())

The method expects() does not exist on DembeloMain\Model\Repository\Doctrine\ODM\LicenseeRepository. Since you implemented __call, consider adding a @method annotation.

            ->method('findAll')
            ->willReturn([]);

        /* @var $response \Symfony\Component\HttpFoundation\Response */
        $response = $this->controller->licenseesAction();
        $this->assertInstanceOf(Response::class, $response);
        $this->assertJsonStringEqualsJsonString('[]', $response->getContent());
        $this->assertEquals('200', $response->getStatusCode());
    }

    /**
     * tests licenseeAction() with one licensee
     * @return void
     */
    public function testLicenseeActionWithOneLicensee(): void
    {
        $licensee = new Licensee();
        $licensee->setName('someName');
        $licensee->setId('someId');

        $this->licenseeRepositoryMock->expects($this->once())
            ->method('findAll')
            ->willReturn([$licensee]);

        /* @var $response \Symfony\Component\HttpFoundation\Response */
        $response = $this->controller->licenseesAction();
        $this->assertInstanceOf(Response::class, $response);
        $this->assertJsonStringEqualsJsonString('[{"id":"someId","name":"someName"}]', $response->getContent());
        $this->assertEquals('200', $response->getStatusCode());
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|LicenseeRepository
     */
    private function createLicenseeRepositoryMock(): LicenseeRepository

This method seems to be duplicated in your project.

    {
        $repository = $this->getMockBuilder(LicenseeRepository::class)
            ->disableOriginalConstructor()
            ->setMethods(['findAll', 'save', 'find', 'findBy', 'findOneBy', 'getClassName', 'findOneByName'])
            ->getMock();

        return $repository;

The expression return $repository returns the type PHPUnit_Framework_MockObject_MockObject which is incompatible with the type-hinted return DembeloMain\Model\Repository\Doctrine\ODM\LicenseeRepository.

    }
}