AdminBundle\Tests\Controller\TopicControllerTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	159
Duplicated Lines	0 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	testListActionWithSomeFilters()	0	31	1
A	createTopicRepositoryMock()	0	3	1
A	testUploadImageActionWithNoError()	0	22	1
A	setUp()	0	5	1
A	testUploadImageActionWithNoFileError()	0	17	1
A	testListActionWithOneTopic()	0	23	1
A	testListActionWithNoTopics()	0	12	1

<?php
/* Copyright (C) 2016 Michael Giesler
 *
 * This file is part of Dembelo.
 *
 * Dembelo is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * Dembelo is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License 3 for more details.
 *
 * You should have received a copy of the GNU Affero General Public License 3
 * along with Dembelo. If not, see <http://www.gnu.org/licenses/>.
 */

namespace AdminBundle\Tests\Controller;

use AdminBundle\Controller\TopicController;
use DembeloMain\Document\Topic;
use DembeloMain\Model\Repository\Doctrine\ODM\TopicRepository;
use DembeloMain\Model\Repository\TopicRepositoryInterface;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\ParameterBag;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * Class TopicControllerTest
 */
class TopicControllerTest extends WebTestCase
{
    /**
     * @var TopicController
     */
    private $controller;

    /**
     * @var \PHPUnit_Framework_MockObject_MockObject|TopicRepositoryInterface
     */
    private $topicRepositoryMock;

    /**
     * @return void
     */
    protected function setUp(): void
    {
        $this->topicRepositoryMock = $this->createTopicRepositoryMock();
        $this->controller = new TopicController(
            $this->topicRepositoryMock
        );
    }

    /**
     * tests topicAction() with no topics
     */
    public function testListActionWithNoTopics()
    {
        $parameterBag = $this->getMockBuilder(ParameterBag::class)->disableOriginalConstructor()->setMethods(['get'])->getMock();

        $requestMock = $this->getMockBuilder(Request::class)->getMock();
        $requestMock->query = $parameterBag;

Accessing query on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        /* @var $response \Symfony\Component\HttpFoundation\Response */
        $response = $this->controller->listAction($requestMock);
        $this->assertInstanceOf(Response::class, $response);
        $this->assertJsonStringEqualsJsonString('[]', $response->getContent());
        $this->assertEquals('200', $response->getStatusCode());
    }

    /**
     * tests topicAction with one topic
     */
    public function testListActionWithOneTopic()
    {
        $topic = new Topic();
        $topic->setName('someName');
        $topic->setId('someId');
        $topic->setStatus(1);
        $topic->setSortKey(123);
        $topic->setOriginalImageName("someImageName");

        $this->topicRepositoryMock->expects($this->once())
            ->method('findBy')
            ->willReturn([$topic]);

        $parameterBag = $this->getMockBuilder(ParameterBag::class)->disableOriginalConstructor()->setMethods(['get'])->getMock();

        $requestMock = $this->getMockBuilder(Request::class)->getMock();
        $requestMock->query = $parameterBag;

Accessing query on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        /* @var $response \Symfony\Component\HttpFoundation\Response */
        $response = $this->controller->listAction($requestMock);
        $this->assertInstanceOf(Response::class, $response);
        $this->assertJsonStringEqualsJsonString('[{"id":"someId","name":"someName","status":"1","sortKey":123,"originalImageName":"someImageName"}]', $response->getContent());
        $this->assertEquals('200', $response->getStatusCode());
    }

    /**
     * tests topicAction with some filters
     */
    public function testListActionWithSomeFilters()
    {
        $topic = new Topic();
        $topic->setName('someName');
        $topic->setId('someId');
        $topic->setStatus(1);
        $topic->setSortKey(123);
        $topic->setOriginalImageName("someImageName");

        $this->topicRepositoryMock->expects($this->never())
            ->method('findBy')
            ->willReturn([$topic]);
        $this->topicRepositoryMock->expects($this->once())
            ->method('findFiltered')
            ->with(['status' => '1'])
            ->willReturn([$topic]);

        $parameterBag = $this->getMockBuilder(ParameterBag::class)->disableOriginalConstructor()->setMethods(['get'])->getMock();
        $parameterBag->expects($this->once())
            ->method('get')
            ->with('filter')
            ->willReturn(['status' => '1']);

        $requestMock = $this->getMockBuilder(Request::class)->getMock();
        $requestMock->query = $parameterBag;

Accessing query on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        /* @var $response \Symfony\Component\HttpFoundation\Response */
        $response = $this->controller->listAction($requestMock);
        $this->assertInstanceOf(Response::class, $response);
        $this->assertJsonStringEqualsJsonString('[{"id":"someId","name":"someName","status":"1","sortKey":123,"originalImageName":"someImageName"}]', $response->getContent());
        $this->assertEquals('200', $response->getStatusCode());
    }

    /**
     * tests uploadImageAction with an error in $_FILES
     */
    public function testUploadImageActionWithNoFileError()
    {
        $parameterBag = $this->getMockBuilder(ParameterBag::class)->disableOriginalConstructor()->setMethods(['get'])->getMock();
        $parameterBag->expects($this->never())
            ->method('get');

        $requestMock = $this->getMockBuilder(Request::class)->getMock();
        $requestMock->query = $parameterBag;

Accessing query on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        $_FILES['upload'] = [
            'error' => UPLOAD_ERR_NO_FILE,
        ];

        /* @var $response \Symfony\Component\HttpFoundation\Response */
        $response = $this->controller->uploadImageAction($requestMock);
        $this->assertInstanceOf(Response::class, $response);
        $this->assertJsonStringEqualsJsonString('{"status":"error"}', $response->getContent());
    }

    /**
     * tests uploadImageAction
     */
    public function testUploadImageActionWithNoError()
    {
        $parameterBag = $this->getMockBuilder(ParameterBag::class)->disableOriginalConstructor()->setMethods(['get'])->getMock();
        $parameterBag->expects($this->once())
            ->method('get')
            ->with('topic_image_directory')
            ->willReturn('someDirectory');

        $requestMock = $this->getMockBuilder(Request::class)->getMock();
        $requestMock->query = $parameterBag;

Accessing query on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        $_FILES['upload'] = [
            'error' => UPLOAD_ERR_OK,
            'name' => 'someName',
            'tmp_name' => 'someTmpName',
        ];

        /* @var $response \Symfony\Component\HttpFoundation\Response */
        $response = $this->controller->uploadImageAction($requestMock);
        $this->assertInstanceOf(Response::class, $response);
        $decoded = json_decode($response->getContent());
        $this->assertEquals('someName', $decoded->originalImageName);
    }

    /**
    * @return TopicRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
    */
    private function createTopicRepositoryMock(): TopicRepositoryInterface
    {
        return $this->createMock(TopicRepositoryInterface::class);

The expression return $this->createMock(DembeloMain\Model\Repository\TopicRepositoryInterface::class) returns the type PHPUnit\Framework\MockObject\MockObject which is incompatible with the type-hinted return DembeloMain\Model\Repository\TopicRepositoryInterface.

    }
}