tylernathanreed / laravel-blueprints

src/Concerns/SoftDeletesBy.php

<?php

namespace Reedware\LaravelBlueprints\Concerns;

trait SoftDeletesBy
{
    /**
     * Alias of {@see $this->deletedBy()}.
     *
     * @param  string       $table
     * @param  string|null  $local
     * @param  string|null  $name
     * @param  string|null  $onUpdate
     * @param  string|null  $onDelete
     *
     * @return \Illuminate\Support\Fluent
     */
    public function softDeletesBy($table = null, $local = null, $name = null, $onUpdate = null, $onDelete = null)
    {
    	return $this->deletedBy($table, $local, $name, $onUpdate, $onDelete);
    }

    /**
     * Alias of {@see $this->deletedByMorph()}.
     *
     * @param  string|null  $indexName
     *
     * @return \Illuminate\Support\Fluent
     */
    public function softDeletesByMorph($indexName = null)
    {
        return $this->deletedByMorph($indexName);

Are you sure the usage of $this->deletedByMorph($indexName) targeting Reedware\LaravelBlueprints\Concerns\SoftDeletesBy::deletedByMorph() seems to always return null.

The expression return $this->deletedByMorph($indexName) returns the type void which is incompatible with the documented return type Illuminate\Support\Fluent.

    }

    /**
     * Alias of {@see $this->bigDeletedBy()}.
     *
     * @param  string       $table
     * @param  string|null  $local
     * @param  string|null  $name
     * @param  string|null  $onUpdate
     * @param  string|null  $onDelete
     *
     * @return \Illuminate\Support\Fluent
     */
    public function bigSoftDeletesBy($table = null, $local = null, $name = null, $onUpdate = null, $onDelete = null)
    {
        return $this->bigDeletedBy($table, $local, $name, $onUpdate, $onDelete);

The expression return $this->bigDeletedBy($table, $local, $name, $onUpdate, $onDelete) returns the type void which is incompatible with the documented return type Illuminate\Support\Fluent.

Are you sure the usage of $this->bigDeletedBy($table, $local, $name, $onUpdate, $onDelete) targeting Reedware\LaravelBlueprints\Concerns\SoftDeletesBy::bigDeletedBy() seems to always return null.

    }

    /**
     * Alias of {@see $this->bigDeletedByMorph()}.
     *
     * @param  string|null  $indexName
     *
     * @return \Illuminate\Support\Fluent
     */
    public function bigSoftDeletesByMorph($indexName = null)
    {
        return $this->bigDeletedByMorph($indexName);

The expression return $this->bigDeletedByMorph($indexName) returns the type void which is incompatible with the documented return type Illuminate\Support\Fluent.

Are you sure the usage of $this->bigDeletedByMorph($indexName) targeting Reedware\LaravelBlueprints\Concerns\SoftDeletesBy::bigDeletedByMorph() seems to always return null.

    }

    /**
     * Adds the 'deleted_by_id' Reference.
     *
     * @param  string       $table
     * @param  string|null  $local
     * @param  string|null  $name
     * @param  string|null  $onUpdate
     * @param  string|null  $onDelete
     *
     * @return \Illuminate\Support\Fluent
     */
    public function deletedBy($table = null, $local = null, $name = null, $onUpdate = null, $onDelete = null)
    {
        // Determine the Table
        if(is_null($table)) {
            $table = $this->getTimestampsByTable();

It seems like getTimestampsByTable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        // Create the Belongs to Relation
    	return $this->belongsTo($table, 'deleted_by_id', $local, $name, $onUpdate, $onDelete)->nullable();

It seems like belongsTo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Adds the 'deleted_by_id' Morph Reference.
     *
     * @param  string|null  $indexName
     *
     * @return void
     */
    public function deletedByMorph($indexName = null)
    {
        // Create the 'deleted_by_id' Morph Column
        $this->belongsToColumn('deleted_by_id')->nullable();

It seems like belongsToColumn() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // Create the 'deleted_by_type' Morph Column
        $this->string('deleted_by_type', 255)->nullable();

It seems like string() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // Index the two Columns
        $this->index(['deleted_by_id', 'deleted_by_type'], $indexName);

It seems like index() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Adds the 'deleted_by_id' Reference.
     *
     * @param  string       $table
     * @param  string|null  $local
     * @param  string|null  $name
     * @param  string|null  $onUpdate
     * @param  string|null  $onDelete
     *
     * @return void
     */
    public function bigDeletedBy($table = null, $local = null, $name = null, $onUpdate = null, $onDelete = null)
    {
        // Determine the Table
        if(is_null($table)) {
            $table = $this->getTimestampsByTable();
        }

        // Create the Belongs to Relation
        return $this->bigBelongsTo($table, 'deleted_by_id', $local, $name, $onUpdate, $onDelete)->nullable();

It seems like bigBelongsTo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Adds the 'deleted_by_id' Morph Reference.
     *
     * @param  string|null  $indexName
     *
     * @return void
     */
    public function bigDeletedByMorph($indexName = null)
    {
        // Create the 'deleted_by_id' Morph Column
        $this->bigBelongsToColumn('deleted_by_id')->nullable();

It seems like bigBelongsToColumn() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // Create the 'deleted_by_type' Morph Column
        $this->string('deleted_by_type', 255)->nullable();

        // Index the two Columns
        $this->index(['deleted_by_id', 'deleted_by_type'], $indexName);
    }
}