Host::strip() - Code Metrics - Inspection of "Merge branch 'master' of github.com:tylercd100/ser..." - tylercd100/server-status - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 17ad67...92a046 )

by Tyler

created 2016-04-15 04:58 UTC

Host::strip() A

↳ Parent: Host

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
ccs	4
cts	4
cp	1
rs	9.4285
cc	1
eloc	4
nc	1
nop	1
crap	1

<?php

namespace Tylercd100\ServerStatus;

use JJG\Ping;
use GuzzleHttp\Client;

class Host 
{
    /**
     * @var string
     */
    protected $host;

    /**
     * @var Ping
     */    
    protected $pinger;

    /**
     * @var Client
     */    
    protected $requester;

    /**
     * @var double
     */    
    protected $ping = 0.0;

    /**
     * @var integer
     */    
    protected $statusCode = 0;

    /**
     * @param string $host The host URL or IP to check
     */
    public function __construct($host)
    {
        $this->host      = $this->strip($host);
        $this->pinger    = new Ping($host);
        $this->requester = new Client();
    }

    /**
     * Strips off the https and http
     * @param  string $host The URL to strip
     * @return string
     */
    protected function strip($host)
    {
        $host = str_replace("https://","",$host);
        $host = str_replace("http://", "",$host);
        return $host;
    }

    /**
     * Checks the ping of the host
     * 
     * @return double|false
     */
    public function ping()
    {
        $this->ping = $this->pinger->ping();
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        return $this->getPing();
    }

    /**
     * Checks the status of the host
     * 
     * @return integer
     */
    public function status(){
        $response = $this->requester->request('GET', $this->host);
        $this->statusCode = $response->getStatusCode();
        return $this->getStatusCode();
    }

    /**
     * Sets the value of pinger.
     *
     * @return void
     */
    public function setPinger(Ping $pinger)
    {
        $this->pinger = $pinger;
    }

    /**
     * Sets the value of requester.
     *
     * @return void
     */
    public function setRequester(Client $requester)
    {
        $this->requester = $requester;
    }

    /**
     * Gets the value of host.
     *
     * @return mixed
     */
    public function getHost()
    {
        return $this->host;
    }

    /**
     * Gets the value of ping.
     *
     * @return mixed
     */
    public function getPing()
    {
        return $this->ping;
    }

    /**
     * Gets the value of statusCode.
     *
     * @return mixed
     */
    public function getStatusCode()
    {
        return $this->statusCode;
    }
}

1		<?php
2
3		namespace Tylercd100\ServerStatus;
4
5		use JJG\Ping;
6		use GuzzleHttp\Client;
7
8		class Host
9		{
10		/**
11		* @var string
12		*/
13		protected $host;
14
15		/**
16		* @var Ping
17		*/
18		protected $pinger;
19
20		/**
21		* @var Client
22		*/
23		protected $requester;
24
25		/**
26		* @var double
27		*/
28		protected $ping = 0.0;
29
30		/**
31		* @var integer
32		*/
33		protected $statusCode = 0;
34
35		/**
36		* @param string $host The host URL or IP to check
37		*/
38	18	public function __construct($host)
39		{
40	18	$this->host = $this->strip($host);
41	18	$this->pinger = new Ping($host);
42	18	$this->requester = new Client();
43	18	}
44
45		/**
46		* Strips off the https and http
47		* @param string $host The URL to strip
48		* @return string
49		*/
50	18	protected function strip($host)
51		{
52	18	$host = str_replace("https://","",$host);
53	18	$host = str_replace("http://", "",$host);
54	18	return $host;
55		}
56
57		/**
58		* Checks the ping of the host
59		*
60		* @return double\|false
61		*/
62	6	public function ping()
63		{
64	3	$this->ping = $this->pinger->ping();
		0 ignored issues – show Documentation Bug introduced 2016-04-14 20:58 UTC by Report Bug Copy Issue Report It seems like `$this->pinger->ping()` can also be of type `false`. However, the property `$ping` is declared as type `double`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
65	6	return $this->getPing();
66		}
67
68		/**
69		* Checks the status of the host
70		*
71		* @return integer
72		*/
73	3	public function status(){
74	3	$response = $this->requester->request('GET', $this->host);
75	3	$this->statusCode = $response->getStatusCode();
76	3	return $this->getStatusCode();
77		}
78
79		/**
80		* Sets the value of pinger.
81		*
82		* @return void
83		*/
84	3	public function setPinger(Ping $pinger)
85		{
86	3	$this->pinger = $pinger;
87	3	}
88
89		/**
90		* Sets the value of requester.
91		*
92		* @return void
93		*/
94	3	public function setRequester(Client $requester)
95		{
96	3	$this->requester = $requester;
97	3	}
98
99		/**
100		* Gets the value of host.
101		*
102		* @return mixed
103		*/
104	3	public function getHost()
105		{
106	3	return $this->host;
107		}
108
109		/**
110		* Gets the value of ping.
111		*
112		* @return mixed
113		*/
114	6	public function getPing()
115		{
116	6	return $this->ping;
117		}
118
119		/**
120		* Gets the value of statusCode.
121		*
122		* @return mixed
123		*/
124	6	public function getStatusCode()
125		{
126	6	return $this->statusCode;
127		}
128		}

tylercd100 / server-status

Push — master ( 17ad67...92a046 )

Host::strip() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like