Host - Code Metrics - Inspection of "added more unit tests" - tylercd100/server-status - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 51c555...c47a91 )

by Tyler

created 2016-04-14 21:08 UTC

Host A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	5
Bugs	1	Features	3

Metric	Value
wmc	8
c	5
b	1
f	3
lcom	2
cbo	2
dl	0
loc	103
ccs	24
cts	24
cp	1
rs	10

8 Methods

Rating	Name	Size	Complexity
A	setPinger()	4	1
A	__construct()	6	1
A	ping()	4	1
A	status()	5	1
A	setRequester()	4	1
A	getHost()	4	1
A	getPing()	4	1
A	getStatusCode()	4	1

<?php

namespace Tylercd100\ServerStatus;

use JJG\Ping;
use GuzzleHttp\Client;

class Host 
{
    /**
     * @var string
     */
    protected $host;

    /**
     * @var Ping
     */    
    protected $pinger;

    /**
     * @var double
     */    
    protected $ping = 0.0;

    /**
     * @var integer
     */    
    protected $statusCode = 0;

    /**
     * @param string $host The host URL or IP to check
     */
    public function __construct($host)
    {
        $this->host      = $host;
        $this->pinger    = new Ping($host);
        $this->requester = new Client();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Checks the ping of the host
     * 
     * @return double|false
     */
    public function ping(){
        $this->ping = $this->pinger->ping();
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        return $this->getPing();
    }

    /**
     * Checks the status of the host
     * 
     * @return integer
     */
    public function status(){
        $response = $this->requester->request('GET', $this->host);
        $this->statusCode = $response->getStatusCode();
        return $this->getStatusCode();
    }

    /**
     * Sets the value of pinger.
     *
     * @return void
     */
    public function setPinger(Ping $pinger)
    {
        $this->pinger = $pinger;
    }

    /**
     * Sets the value of requester.
     *
     * @return void
     */
    public function setRequester(Client $requester)
    {
        $this->requester = $requester;
    }

    /**
     * Gets the value of host.
     *
     * @return mixed
     */
    public function getHost()
    {
        return $this->host;
    }

    /**
     * Gets the value of ping.
     *
     * @return mixed
     */
    public function getPing()
    {
        return $this->ping;
    }

    /**
     * Gets the value of statusCode.
     *
     * @return mixed
     */
    public function getStatusCode()
    {
        return $this->statusCode;
    }
}

1		<?php
2
3		namespace Tylercd100\ServerStatus;
4
5		use JJG\Ping;
6		use GuzzleHttp\Client;
7
8		class Host
9		{
10		/**
11		* @var string
12		*/
13		protected $host;
14
15		/**
16		* @var Ping
17		*/
18		protected $pinger;
19
20		/**
21		* @var double
22		*/
23		protected $ping = 0.0;
24
25		/**
26		* @var integer
27		*/
28		protected $statusCode = 0;
29
30		/**
31		* @param string $host The host URL or IP to check
32		*/
33	18	public function __construct($host)
34		{
35	18	$this->host = $host;
36	18	$this->pinger = new Ping($host);
37	18	$this->requester = new Client();
		0 ignored issues – show Bug introduced 2016-04-14 21:11 UTC by Report Bug Copy Issue Report The property `requester` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
38	18	}
39
40		/**
41		* Checks the ping of the host
42		*
43		* @return double\|false
44		*/
45	3	public function ping(){
46	3	$this->ping = $this->pinger->ping();
		0 ignored issues – show Documentation Bug introduced 2016-04-14 20:58 UTC by Report Bug Copy Issue Report It seems like `$this->pinger->ping()` can also be of type `false`. However, the property `$ping` is declared as type `double`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
47	3	return $this->getPing();
48		}
49
50		/**
51		* Checks the status of the host
52		*
53		* @return integer
54		*/
55	3	public function status(){
56	3	$response = $this->requester->request('GET', $this->host);
57	3	$this->statusCode = $response->getStatusCode();
58	3	return $this->getStatusCode();
59		}
60
61		/**
62		* Sets the value of pinger.
63		*
64		* @return void
65		*/
66	3	public function setPinger(Ping $pinger)
67		{
68	3	$this->pinger = $pinger;
69	3	}
70
71		/**
72		* Sets the value of requester.
73		*
74		* @return void
75		*/
76	3	public function setRequester(Client $requester)
77		{
78	3	$this->requester = $requester;
79	3	}
80
81		/**
82		* Gets the value of host.
83		*
84		* @return mixed
85		*/
86	3	public function getHost()
87		{
88	3	return $this->host;
89		}
90
91		/**
92		* Gets the value of ping.
93		*
94		* @return mixed
95		*/
96	6	public function getPing()
97		{
98	6	return $this->ping;
99		}
100
101		/**
102		* Gets the value of statusCode.
103		*
104		* @return mixed
105		*/
106	6	public function getStatusCode()
107		{
108	6	return $this->statusCode;
109		}
110		}

tylercd100 / server-status

Push — master ( 51c555...c47a91 )

Host A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

Duplication Side-by-Side

Filter issues like