LinodeRebooter::shutdown() - Code Metrics - Inspection of "removed unnecessary class" - tylercd100/php-rebooter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 082ba8...f72045 )

by Tyler

created 2016-04-20 01:39 UTC

LinodeRebooter::shutdown() A

↳ Parent: LinodeRebooter

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	3
ccs	0
cts	2
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Tylercd100\Rebooter\Api;

use GuzzleHttp\Client;
use Tylercd100\Rebooter\ApiRebooter;

class LinodeRebooter extends ApiRebooter {

    protected $token;
    protected $linodeId;
    protected $host;
    protected $client;
    
    /**
     * @param string $token    API Token from Linode.com
     * @param [type] $linodeId The ID of the linode you want to control

     * @param string $host     The api host
     * @param Client $client   The guzzle client to use
     */
    public function __construct($token, $linodeId, $host = "api.linode.com", Client $client = null){

        if(!$client instanceof Client){
            $client = new Client();
        }

        $this->client = $client;
        $this->token = $token;
        $this->linodeId = $linodeId;
        $this->host = $host;
    }

    /**
     * Executes a Boot command
     * @return GuzzleHttp\Psr7\Response
     */
    public function boot(){
        return $this->exec("linode.boot");
    }

    /**
     * Executes a Reboot command
     * @return GuzzleHttp\Psr7\Response
     */
    public function reboot(){
        return $this->exec("linode.reboot");
    }

    /**
     * Executes a Shutdown command
     * @return GuzzleHttp\Psr7\Response
     */
    public function shutdown(){
        return $this->exec("linode.shutdown");
    }

    /**
     * Builds the request URL for the API call
     * @param  string $action The Linode API action
     * @return string
     */
    protected function buildRequestUrl($action){
        return "https://{$this->host}/?api_key={$this->token}&api_action={$action}&LinodeID={$this->linodeId}";
    }

    /**
     * Executes a command on the API
     * @return GuzzleHttp\Psr7\Response
     */
    protected function exec($action){
        $url = $this->buildRequestUrl($action);
        return $res = $this->client->request('GET', $url);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}

1		<?php
2
3		namespace Tylercd100\Rebooter\Api;
4
5		use GuzzleHttp\Client;
6		use Tylercd100\Rebooter\ApiRebooter;
7
8		class LinodeRebooter extends ApiRebooter {
9
10		protected $token;
11		protected $linodeId;
12		protected $host;
13		protected $client;
14
15		/**
16		* @param string $token API Token from Linode.com
17		* @param [type] $linodeId The ID of the linode you want to control
		0 ignored issues – show Documentation introduced 2016-04-20 01:28 UTC by Report Bug Copy Issue Report The doc-type `[type]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
18		* @param string $host The api host
19		* @param Client $client The guzzle client to use
20		*/
21	3	public function __construct($token, $linodeId, $host = "api.linode.com", Client $client = null){
22
23	3	if(!$client instanceof Client){
24	3	$client = new Client();
25	3	}
26
27	3	$this->client = $client;
28	3	$this->token = $token;
29	3	$this->linodeId = $linodeId;
30	3	$this->host = $host;
31	3	}
32
33		/**
34		* Executes a Boot command
35		* @return GuzzleHttp\Psr7\Response
36		*/
37		public function boot(){
38		return $this->exec("linode.boot");
39		}
40
41		/**
42		* Executes a Reboot command
43		* @return GuzzleHttp\Psr7\Response
44		*/
45		public function reboot(){
46		return $this->exec("linode.reboot");
47		}
48
49		/**
50		* Executes a Shutdown command
51		* @return GuzzleHttp\Psr7\Response
52		*/
53		public function shutdown(){
54		return $this->exec("linode.shutdown");
55		}
56
57		/**
58		* Builds the request URL for the API call
59		* @param string $action The Linode API action
60		* @return string
61		*/
62		protected function buildRequestUrl($action){
63		return "https://{$this->host}/?api_key={$this->token}&api_action={$action}&LinodeID={$this->linodeId}";
64		}
65
66		/**
67		* Executes a command on the API
68		* @return GuzzleHttp\Psr7\Response
69		*/
70		protected function exec($action){
71		$url = $this->buildRequestUrl($action);
72		return $res = $this->client->request('GET', $url);
		0 ignored issues – show Unused Code introduced 2016-04-20 01:41 UTC by Report Bug Copy Issue Report `$res` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
73		}
74		}

tylercd100 / php-rebooter

Push — master ( 082ba8...f72045 )

LinodeRebooter::shutdown() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like