Tylercd100\LERN\Components\Recorder

Complexity

Total Complexity

26

Size/Duplication

Total Lines	147
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

81.25%

Importance

Changes	7
Bugs	3	Features	2

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
B	record()	0	30	5
A	canCollect()	0	6	4
B	collect()	0	16	6
A	getUserId()	0	8	2
A	getMethod()	0	8	2
A	getData()	0	8	2
A	getUrl()	0	8	2
A	getStatusCode()	0	7	2

<?php

namespace Tylercd100\LERN\Components;

use Exception;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Input;
use Illuminate\Support\Facades\Request;
use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
use Tylercd100\LERN\Exceptions\RecorderFailedException;
use Tylercd100\LERN\Models\ExceptionModel;

class Recorder extends Component{

    /**
     * @var mixed
     */
    protected $config = [];

    /**
     * The constructor
     */
    public function __construct() {
        $this->config = config('lern.record');
    }

    /**
     * Records an Exception to the database
     * @param  Exception $e The exception you want to record
     * @return ExceptionModel|false
     */
    public function record(Exception $e)

The parameter $e is not used and could be removed.

    {
        try {
            if($this->shouldntHandle($e)){
                return false;
            }

            $opts = [
                'class'       => get_class($e),
                'file'        => $e->getFile(),
                'line'        => $e->getLine(),
                'code'        => $e->getCode(),
                'message'     => $e->getMessage(),
                'trace'       => $e->getTraceAsString(),
            ];


            $configDependant = ['user_id', 'status_code', 'method', 'data', 'url'];

            foreach ($configDependant as $key) {
                if ($this->canCollect($key)) {
                    $opts[$key] = $this->collect($key, $e);
                }
            }

            return ExceptionModel::create($opts);
        } catch (Exception $e) {
            throw new RecorderFailedException($e->getMessage(), $e->getCode(), $e);
        }
    }

    /**
     * Checks the config to see if you can collect certain information
     * @param  string $type the config value you want to check
     * @return boolean      
     */
    private function canCollect($type) {
        if (!empty($this->config) && !empty($this->config['collect']) && !empty($this->config['collect'][$type])) {
            return $this->config['collect'][$type] === true;
        }
        return false;
    }

    /**
     * @param string $key
     */
    protected function collect($key,Exception $e = null){
        switch ($key) {
            case 'user_id':
                return $this->getUserId();
            case 'method':
                return $this->getMethod();
            case 'status_code':
                return $this->getStatusCode($e);

It seems like $e defined by parameter $e on line 78 can be null; however, Tylercd100\LERN\Components\Recorder::getStatusCode() does not accept null, maybe add an additional type check?

            case 'url':
                return $this->getUrl();
            case 'data':
                return $this->getData();
            default:
                throw new Exception("{$key} is not supported! Therefore it cannot be collected!");
        }
    }

    /**
     * Gets the ID of the User that is logged in
     * @return integer|null The ID of the User or Null if not logged in
     */
    protected function getUserId() {
        $user = Auth::user();
        if (is_object($user)) {
            return $user->id;
        } else {
            return null;
        }
    }

    /**
     * Gets the Method of the Request
     * @return string|null Possible values are null or GET, POST, DELETE, PUT, etc...
     */
    protected function getMethod() {
        $method = Request::method();
        if (!empty($method)) {
            return $method;
        } else {
            return null;
        }
    }

    /**
     * Gets the input data of the Request
     * @return array|null The Input data or null
     */
    protected function getData() {
        $data = Input::all();
        if (is_array($data)) {
            return $data;
        } else {
            return null;
        }
    }

    /**
     * Gets the URL of the Request
     * @return string|null Returns a URL string or null
     */
    protected function getUrl() {
        $url = Request::url();
        if (is_string($url)) {
            return $url;
        } else {
            return null;
        }
    }

    /**
     * Gets the status code of the Exception
     * @param  Exception $e The Exception to check
     * @return string|integer The status code value
     */
    protected function getStatusCode(Exception $e) {
        if ($e instanceof HttpExceptionInterface) {
            return $e->getStatusCode();
        } else {
            return 0;
        }
    }
}