AutoCache - Code Metrics - Inspection of "Reverted back to const" - tylercd100/laravel-model-improved - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7bbb47...c865af )

by Tyler

created 2018-03-15 20:37 UTC

AutoCache A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

33.33%

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	2
dl	0
loc	32
ccs	4
cts	12
cp	0.3333
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	newEloquentBuilder()	0	7	2
A	refresh()	0	6	1

<?php

namespace Tylercd100\Database\Eloquent\Traits;

use Illuminate\Database\Eloquent\Builder as IlluminateBuilder;
use Tylercd100\Database\Eloquent\Builder as AutoCacheBuilder;
use Illuminate\Support\Facades\Cache;

trait AutoCache
{
    /**
     * Set the cache expiry time.
     *
     * @var int
     */
    public $cacheExpiry = 1440;

    /**
     * Create a new Eloquent query builder for the model.
     */
    public function newEloquentBuilder($query)
    {
        if (static::AUTO_CACHE_ENABLED) {
            return new AutoCacheBuilder($query);
        }
        return new IlluminateBuilder($query);
    }

    /**
     * Refresh the current models cache.
     *
     * @return $this
     */
    public function refresh()
    {
        Cache::tags($this->getTable())->forget($this->{$this->getKeyName()});
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this;
    }
}


1		<?php
2
3		namespace Tylercd100\Database\Eloquent\Traits;
4
5		use Illuminate\Database\Eloquent\Builder as IlluminateBuilder;
6		use Tylercd100\Database\Eloquent\Builder as AutoCacheBuilder;
7		use Illuminate\Support\Facades\Cache;
8
9		trait AutoCache
10		{
11		/**
12		* Set the cache expiry time.
13		*
14		* @var int
15		*/
16		public $cacheExpiry = 1440;
17
18		/**
19		* Create a new Eloquent query builder for the model.
20		*/
21	4	public function newEloquentBuilder($query)
22		{
23	4	if (static::AUTO_CACHE_ENABLED) {
24	2	return new AutoCacheBuilder($query);
25		}
26	2	return new IlluminateBuilder($query);
27		}
28
29		/**
30		* Refresh the current models cache.
31		*
32		* @return $this
33		*/
34		public function refresh()
35		{
36		Cache::tags($this->getTable())->forget($this->{$this->getKeyName()});
		0 ignored issues – show Bug introduced 2017-05-03 00:18 UTC by Report Bug Copy Issue Report It seems like `getTable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2017-05-03 00:18 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37
38		return $this;
39		}
40		}
41

tylercd100 / laravel-model-improved

Push — master ( 7bbb47...c865af )

AutoCache A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like