AutoCache - Code Metrics - Inspection of "Pivot Model and Cache Logic" - tylercd100/laravel-model-improved - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Tyler

created 2017-05-03 16:05 UTC

AutoCache A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

41.67%

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	1
dl	0
loc	48
ccs	5
cts	12
cp	0.4167
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	boot()	10	1
A	newEloquentBuilder()	4	1
A	refresh()	6	1

<?php

namespace Tylercd100\Database\Eloquent\Traits;

use Tylercd100\Database\Eloquent\Builder;
use Illuminate\Support\Facades\Cache;

trait AutoCache
{
    /**
     * Set the cache expiry time.
     *
     * @var int
     */
    public $cacheExpiry = 1440;

    /**
     * The "booting" method of the model.
     *
     * @return void
     */
    public static function boot()
    {
        static::saved(function ($model) {
            $model->refresh();
        }, -1);

        static::deleted(function ($model) {
            $model->refresh();
        }, -1);
    }

    /**
     * Create a new Eloquent query builder for the model.
     *
     * @param  \Illuminate\Database\Query\Builder $query
     * @return \PulkitJalan\Cacheable\Eloquent\Builder|static
     */
    public function newEloquentBuilder($query)
    {
        return new Builder($query);
    }

    /**
     * Refresh the current models cache.
     *
     * @return $this
     */
    public function refresh()
    {
        Cache::tags($this->getTable())->forget($this->{$this->getKeyName()});
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this;
    }
}


1		<?php
2
3		namespace Tylercd100\Database\Eloquent\Traits;
4
5		use Tylercd100\Database\Eloquent\Builder;
6		use Illuminate\Support\Facades\Cache;
7
8		trait AutoCache
9		{
10		/**
11		* Set the cache expiry time.
12		*
13		* @var int
14		*/
15		public $cacheExpiry = 1440;
16
17		/**
18		* The "booting" method of the model.
19		*
20		* @return void
21		*/
22	6	public static function boot()
23		{
24		static::saved(function ($model) {
25		$model->refresh();
26	6	}, -1);
27
28	6	static::deleted(function ($model) {
29		$model->refresh();
30	6	}, -1);
31	6	}
32
33		/**
34		* Create a new Eloquent query builder for the model.
35		*
36		* @param \Illuminate\Database\Query\Builder $query
37		* @return \PulkitJalan\Cacheable\Eloquent\Builder\|static
38		*/
39		public function newEloquentBuilder($query)
40		{
41		return new Builder($query);
42		}
43
44		/**
45		* Refresh the current models cache.
46		*
47		* @return $this
48		*/
49		public function refresh()
50		{
51		Cache::tags($this->getTable())->forget($this->{$this->getKeyName()});
		0 ignored issues – show Bug introduced 2017-05-03 00:18 UTC by Report Bug Copy Issue Report It seems like `getTable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2017-05-03 00:18 UTC by Report Bug Copy Issue Report It seems like `getKeyName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
52
53		return $this;
54		}
55		}
56

tylercd100 / laravel-model-improved

Pull Request — master (#1)

AutoCache A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like