Issues in test_modprobe.py (master) - Issues in master - tychota/saruman - Measure and Improve Code Quality continuously with Scrutinizer

Issues (97)

tests/test_modprobe.py (11 issues)

Labels

Severity

import unittest
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from nose.tools import eq_
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from celery import current_app
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

import saruman.tasks.kernel.modprobe


class KernelModprobeTest(unittest.TestCase):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def setUp(self):
        current_app.conf.CELERY_ALWAYS_EAGER = True

    def test_check(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        rst = saruman.tasks.kernel.modprobe.Check().apply(args=('dummy',)).get()

        assert isinstance(rst, bool) and rst is not None, "%r doesnt return a boolean or return None" % rst

    def test_add(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        rst = saruman.tasks.kernel.modprobe.Add().apply(args=('dummy',)).get()

        assert rst is  None, "%r doesnt return None" % rst


1			import unittest
			0 ignored issues – show Coding Style introduced 2016-01-03 15:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			from nose.tools import eq_
			0 ignored issues – show Configuration introduced 2016-01-03 15:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The import `nose.tools` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history... Unused Code introduced 2016-01-03 16:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this Unused eq_ imported from nose.tools Loading history...
3
4			from celery import current_app
			0 ignored issues – show Configuration introduced 2016-01-03 15:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The import `celery` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
5
6			import saruman.tasks.kernel.modprobe
7
8
9			class KernelModprobeTest(unittest.TestCase):
			0 ignored issues – show Coding Style introduced 2016-01-03 15:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
10			def setUp(self):
11			current_app.conf.CELERY_ALWAYS_EAGER = True
12
13			def test_check(self):
			0 ignored issues – show Coding Style introduced 2016-01-03 16:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Coding Style introduced 2016-01-03 16:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
14			rst = saruman.tasks.kernel.modprobe.Check().apply(args=('dummy',)).get()
			0 ignored issues – show Bug introduced 2016-01-03 15:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The Instance of `Check` does not seem to have a member named `apply`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
15			assert isinstance(rst, bool) and rst is not None, "%r doesnt return a boolean or return None" % rst
16
17			def test_add(self):
			0 ignored issues – show Coding Style introduced 2016-01-03 15:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Coding Style introduced 2016-01-03 15:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
18			rst = saruman.tasks.kernel.modprobe.Add().apply(args=('dummy',)).get()
			0 ignored issues – show Bug introduced 2016-01-03 15:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The Instance of `Add` does not seem to have a member named `apply`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
19			assert rst is None, "%r doesnt return None" % rst
20

GitHub Access Token became invalid

Issues (97)

tests/test_modprobe.py (11 issues)

Labels

Severity

Introduced By

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

tychota / saruman

GitHub Access Token became invalid

Issues (97)

tests/test_modprobe.py (11 issues)

Labels

Severity

Introduced By

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files