Complex classes like TDMCreateHtmlCode often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use TDMCreateHtmlCode, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 28 | class TDMCreateHtmlCode |
||
|
|
|||
| 29 | { |
||
| 30 | /* |
||
| 31 | * @public function constructor |
||
| 32 | * @param null |
||
| 33 | */ |
||
| 34 | /** |
||
| 35 | * |
||
| 36 | */ |
||
| 37 | public function __construct() |
||
| 40 | |||
| 41 | /* |
||
| 42 | * @static function &getInstance |
||
| 43 | * @param null |
||
| 44 | */ |
||
| 45 | /** |
||
| 46 | * @return TDMCreateHtmlCode |
||
| 47 | */ |
||
| 48 | public static function &getInstance() |
||
| 57 | |||
| 58 | /* |
||
| 59 | * @public function getHtmlTag |
||
| 60 | * @param string $tag |
||
| 61 | * @param array $attributes |
||
| 62 | * @param string $content |
||
| 63 | * @param bool $closed |
||
| 64 | */ |
||
| 65 | /** |
||
| 66 | * @param $tag |
||
| 67 | * @param $attributes |
||
| 68 | * @param $content |
||
| 69 | * @param $closed |
||
| 70 | * |
||
| 71 | * @return string |
||
| 72 | */ |
||
| 73 | public function getHtmlTag($tag = '', $attributes = array(), $content = '', $closed = true) |
||
| 87 | |||
| 88 | /* |
||
| 89 | * @private function setAttributes |
||
| 90 | * @param array $attributes |
||
| 91 | */ |
||
| 92 | /** |
||
| 93 | * @param $attributes |
||
| 94 | * |
||
| 95 | * @return string |
||
| 96 | */ |
||
| 97 | private function getAttributes($attributes) |
||
| 108 | |||
| 109 | /* |
||
| 110 | * @public function getHtmlEmpty |
||
| 111 | * @param string $empty |
||
| 112 | */ |
||
| 113 | /** |
||
| 114 | * @param $empty |
||
| 115 | * |
||
| 116 | * @return string |
||
| 117 | */ |
||
| 118 | public function getHtmlEmpty($empty = '') |
||
| 122 | |||
| 123 | /* |
||
| 124 | * @public function getHtmlComment |
||
| 125 | * @param string $htmlComment |
||
| 126 | */ |
||
| 127 | /** |
||
| 128 | * @param $htmlComment |
||
| 129 | * |
||
| 130 | * @return string |
||
| 131 | */ |
||
| 132 | public function getHtmlComment($htmlComment = '') |
||
| 136 | |||
| 137 | /* |
||
| 138 | * @public function getHtmlBr |
||
| 139 | * @param string $brNumb |
||
| 140 | * @param string $class |
||
| 141 | */ |
||
| 142 | /** |
||
| 143 | * @param $brNumb |
||
| 144 | * @param $class |
||
| 145 | * |
||
| 146 | * @return string |
||
| 147 | */ |
||
| 148 | public function getHtmlBr($brNumb = 1, $htmlClass = '') |
||
| 158 | |||
| 159 | /* |
||
| 160 | * @public function getHtmlHNumb |
||
| 161 | * @param string $htmlHClass |
||
| 162 | * @param string $content |
||
| 163 | */ |
||
| 164 | /** |
||
| 165 | * @param $content |
||
| 166 | * @param $htmlHClass |
||
| 167 | * |
||
| 168 | * @return string |
||
| 169 | */ |
||
| 170 | public function getHtmlHNumb($content = '', $n = '1', $htmlHClass = '') |
||
| 177 | |||
| 178 | /* |
||
| 179 | * @public function getHtmlDiv |
||
| 180 | * @param string $class |
||
| 181 | * @param string $content |
||
| 182 | */ |
||
| 183 | /** |
||
| 184 | * @param $content |
||
| 185 | * @param $class |
||
| 186 | * |
||
| 187 | * @return string |
||
| 188 | */ |
||
| 189 | public function getHtmlDiv($content = '', $divClass = '') |
||
| 198 | |||
| 199 | /* |
||
| 200 | * @public function getHtmlPre |
||
| 201 | * @param string $class |
||
| 202 | * @param string $content |
||
| 203 | */ |
||
| 204 | /** |
||
| 205 | * @param $content |
||
| 206 | * @param $class |
||
| 207 | * |
||
| 208 | * @return string |
||
| 209 | */ |
||
| 210 | public function getHtmlPre($content = '', $preClass = '') |
||
| 219 | |||
| 220 | /* |
||
| 221 | * @public function getHtmlSpan |
||
| 222 | * @param string $class |
||
| 223 | * @param string $content |
||
| 224 | */ |
||
| 225 | /** |
||
| 226 | * @param $content |
||
| 227 | * @param $class |
||
| 228 | * |
||
| 229 | * @return string |
||
| 230 | */ |
||
| 231 | public function getHtmlSpan($content = '', $spanClass = '') |
||
| 238 | |||
| 239 | /* |
||
| 240 | * @public function getHtmlParagraph |
||
| 241 | * @param string $class |
||
| 242 | * @param string $content |
||
| 243 | */ |
||
| 244 | /** |
||
| 245 | * @param $content |
||
| 246 | * @param $class |
||
| 247 | * |
||
| 248 | * @return string |
||
| 249 | */ |
||
| 250 | public function getHtmlParagraph($content = '', $pClass = '') |
||
| 259 | |||
| 260 | /* |
||
| 261 | * @public function getHtmlI |
||
| 262 | * @param string $class |
||
| 263 | * @param string $content |
||
| 264 | */ |
||
| 265 | /** |
||
| 266 | * @param $content |
||
| 267 | * @param $class |
||
| 268 | * |
||
| 269 | * @return string |
||
| 270 | */ |
||
| 271 | public function getHtmlI($content = '', $iClass = '') |
||
| 278 | |||
| 279 | /* |
||
| 280 | * @public function getHtmlUl |
||
| 281 | * @param string $class |
||
| 282 | * @param string $content |
||
| 283 | */ |
||
| 284 | /** |
||
| 285 | * @param $content |
||
| 286 | * @param $class |
||
| 287 | * |
||
| 288 | * @return string |
||
| 289 | */ |
||
| 290 | public function getHtmlUl($content = '', $ulClass = '') |
||
| 299 | |||
| 300 | /* |
||
| 301 | * @public function getHtmlOl |
||
| 302 | * @param string $class |
||
| 303 | * @param string $content |
||
| 304 | */ |
||
| 305 | /** |
||
| 306 | * @param $content |
||
| 307 | * @param $class |
||
| 308 | * |
||
| 309 | * @return string |
||
| 310 | */ |
||
| 311 | public function getHtmlOl($content = '', $olClass = '') |
||
| 320 | |||
| 321 | /* |
||
| 322 | * @public function getHtmlLi |
||
| 323 | * @param string $class |
||
| 324 | * @param string $content |
||
| 325 | */ |
||
| 326 | /** |
||
| 327 | * @param $content |
||
| 328 | * @param $class |
||
| 329 | * |
||
| 330 | * @return string |
||
| 331 | */ |
||
| 332 | public function getHtmlLi($content = '', $liClass = '') |
||
| 338 | |||
| 339 | /* |
||
| 340 | * @public function getHtmlStrong |
||
| 341 | * @param string $class |
||
| 342 | * @param string $content |
||
| 343 | */ |
||
| 344 | /** |
||
| 345 | * @param $content |
||
| 346 | * @param $class |
||
| 347 | * |
||
| 348 | * @return string |
||
| 349 | */ |
||
| 350 | public function getHtmlStrong($content = '', $strongClass = '') |
||
| 356 | |||
| 357 | /* |
||
| 358 | * @public function getHtmlAnchor |
||
| 359 | * @param string $class |
||
| 360 | * @param string $url |
||
| 361 | * @param string $target |
||
| 362 | * @param string $content |
||
| 363 | */ |
||
| 364 | /** |
||
| 365 | * @param $url |
||
| 366 | * @param $content |
||
| 367 | * @param $target |
||
| 368 | * @param $class |
||
| 369 | * |
||
| 370 | * @return string |
||
| 371 | */ |
||
| 372 | public function getHtmlAnchor($url = '#', $content = ' ', $title = '', $target = '', $aClass = '', $rel = '') |
||
| 380 | |||
| 381 | /* |
||
| 382 | * @public function getHtmlImage |
||
| 383 | * @param string $src |
||
| 384 | * @param string $alt |
||
| 385 | * @param string $class |
||
| 386 | */ |
||
| 387 | /** |
||
| 388 | * @param $src |
||
| 389 | * @param $alt |
||
| 390 | * @param $class |
||
| 391 | * |
||
| 392 | * @return string |
||
| 393 | */ |
||
| 394 | public function getHtmlImage($src = 'blank.gif', $alt = 'blank.gif', $imgClass = '') |
||
| 401 | |||
| 402 | /* |
||
| 403 | * @public function getHtmlTable |
||
| 404 | * @param string $class |
||
| 405 | * @param string $content |
||
| 406 | */ |
||
| 407 | /** |
||
| 408 | * @param $content |
||
| 409 | * @param $class |
||
| 410 | * |
||
| 411 | * @return string |
||
| 412 | */ |
||
| 413 | public function getHtmlTable($content = '', $tableClass = '') |
||
| 422 | |||
| 423 | /* |
||
| 424 | * @public function getHtmlTableThead |
||
| 425 | * @param string $class |
||
| 426 | * @param string $content |
||
| 427 | */ |
||
| 428 | /** |
||
| 429 | * @param $content |
||
| 430 | * @param $class |
||
| 431 | * |
||
| 432 | * @return string |
||
| 433 | */ |
||
| 434 | public function getHtmlTableThead($content = '', $theadClass = '') |
||
| 443 | |||
| 444 | /* |
||
| 445 | * @public function getHtmlTableTbody |
||
| 446 | * @param string $class |
||
| 447 | * @param string $content |
||
| 448 | */ |
||
| 449 | /** |
||
| 450 | * @param $content |
||
| 451 | * @param $class |
||
| 452 | * |
||
| 453 | * @return string |
||
| 454 | */ |
||
| 455 | public function getHtmlTableTbody($content = '', $tbodyClass = '') |
||
| 464 | |||
| 465 | /* |
||
| 466 | * @public function getHtmlTableTfoot |
||
| 467 | * @param string $class |
||
| 468 | * @param string $content |
||
| 469 | */ |
||
| 470 | /** |
||
| 471 | * @param $content |
||
| 472 | * @param $class |
||
| 473 | * |
||
| 474 | * @return string |
||
| 475 | */ |
||
| 476 | public function getHtmlTableTfoot($content = '', $tfootClass = '') |
||
| 485 | |||
| 486 | /* |
||
| 487 | * @public function getHtmlTableRow |
||
| 488 | * @param string $class |
||
| 489 | * @param string $content |
||
| 490 | */ |
||
| 491 | /** |
||
| 492 | * @param $content |
||
| 493 | * @param $class |
||
| 494 | * |
||
| 495 | * @return string |
||
| 496 | */ |
||
| 497 | public function getHtmlTableRow($content = '', $trClass = '') |
||
| 506 | |||
| 507 | /* |
||
| 508 | * @public function getHtmlTableHead |
||
| 509 | * @param string $class |
||
| 510 | * @param string $content |
||
| 511 | */ |
||
| 512 | /** |
||
| 513 | * @param $content |
||
| 514 | * @param $class |
||
| 515 | * @param $colspan |
||
| 516 | * |
||
| 517 | * @return string |
||
| 518 | */ |
||
| 519 | public function getHtmlTableHead($content = '', $thClass = '', $colspan = '') |
||
| 526 | |||
| 527 | /* |
||
| 528 | * @public function getHtmlTableData |
||
| 529 | * @param string $class |
||
| 530 | * @param string $content |
||
| 531 | */ |
||
| 532 | /** |
||
| 533 | * @param $content |
||
| 534 | * @param $class |
||
| 535 | * @param $colspan |
||
| 536 | * |
||
| 537 | * @return string |
||
| 538 | */ |
||
| 539 | public function getHtmlTableData($content = '', $tdClass = '', $colspan = '') |
||
| 546 | } |
||
| 547 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.