TDMCreateFieldElements

Complexity

Total Complexity

6

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	__call()	0	6	2
A	getInstance()	0	9	2
A	getValuesFieldElements()	0	12	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 34 and the first side effect is on line 24.

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */
/**
 * tdmcreate module.
 *
 * @copyright       The XOOPS Project http://sourceforge.net/projects/xoops/
 * @license         GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 *
 * @since           2.5.5
 *
 * @author          Txmod Xoops <support@txmodxoops.org>
 *
 * @version         $Id: 1.91 fieldelements.php 11297 2014-03-24 09:11:10Z timgno $
 */
defined('XOOPS_ROOT_PATH') || die('Restricted access');

/*
*  @Class TDMCreateFieldElements
*  @extends XoopsObject
*/

/**
 * Class TDMCreateFieldElements.
 */
class TDMCreateFieldElements extends XoopsObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /*
    *  @public function constructor class
    *  @param null
    */
    /**
     *
     */
    public function __construct()
    {
        $this->initVar('fieldelement_id', XOBJ_DTYPE_INT);
        $this->initVar('fieldelement_mid', XOBJ_DTYPE_INT);
        $this->initVar('fieldelement_tid', XOBJ_DTYPE_INT);
        $this->initVar('fieldelement_name', XOBJ_DTYPE_TXTBOX);
        $this->initVar('fieldelement_value', XOBJ_DTYPE_TXTBOX);
    }

    /**
     * @param string $method
     * @param array  $args
     *
     * @return mixed
     */
    public function __call($method, $args)
    {
        $arg = isset($args[0]) ? $args[0] : null;

        return $this->getVar($method, $arg);
    }

    /*
    *  @static function &getInstance
    *  @param null
    */
    /**
     * @return TDMCreateFieldElements
     */
    public static function &getInstance()
    {
        static $instance = false;
        if (!$instance) {
            $instance = new self();
        }

        return $instance;
    }

    /**
     * Get Values.
     */
    public function getValuesFieldElements($keys = null, $format = null, $maxDepth = null)
    {
        $ret = $this->getValues($keys, $format, $maxDepth);
        // Values
        $ret['id'] = $this->getVar('fieldelement_id');
        $ret['mid'] = $this->getVar('fieldelement_mid');
        $ret['tid'] = $this->getVar('fieldelement_tid');
        $ret['name'] = $this->getVar('fieldelement_name');
        $ret['value'] = $this->getVar('fieldelement_value');

        return $ret;
    }
}

/*
*  @Class TDMCreateFieldElementsHandler
*  @extends XoopsPersistableObjectHandler
*/

/**
 * Class TDMCreateFieldElementsHandler.
 */
class TDMCreateFieldElementsHandler extends XoopsPersistableObjectHandler

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /*
    *  @public function constructor class
    *  @param mixed $db
    */
    /**
     * @param null|object $db
     */
    public function __construct(&$db)
    {
        parent::__construct($db, 'tdmcreate_fieldelements', 'tdmcreatefieldelements', 'fieldelement_id', 'fieldelement_name');
    }

    /**
     * Get Count Fields.
     */
    public function getCountFieldElements($start = 0, $limit = 0, $sort = 'fieldelement_id ASC, fieldelement_name', $order = 'ASC')
    {
        $criteriaCountFieldElements = new CriteriaCompo();
        $criteriaCountFieldElements = $this->getFieldElementsCriteria($criteriaCountFieldElements, $start, $limit, $sort, $order);

        return parent::getCount($criteriaCountFieldElements);

It seems like you call parent on a different method (getCount() instead of getCountFieldElements()). Are you sure this is correct? If so, you might want to change this to $this->getCount().

    }

    /**
     * Get Objects Fields.
     */
    public function getObjectsFieldElements($start = 0, $limit = 0, $sort = 'fieldelement_id ASC, fieldelement_name', $order = 'ASC')
    {
        $criteriaObjectsFieldElements = new CriteriaCompo();
        $criteriaObjectsFieldElements = $this->getFieldElementsCriteria($criteriaObjectsFieldElements, $start, $limit, $sort, $order);

        return $this->getObjects($criteriaObjectsFieldElements);
    }

    /**
     * Get All Fields.
     */
    public function getAllFieldElements($start = 0, $limit = 0, $sort = 'fieldelement_id ASC, fieldelement_name', $order = 'ASC')
    {
        $criteriaAllFieldElements = new CriteriaCompo();
        $criteriaAllFieldElements = $this->getFieldElementsCriteria($criteriaAllFieldElements, $start, $limit, $sort, $order);

        return $this->getAll($criteriaAllFieldElements);
    }

    /**
     * Get All Fields By Module & Table Id.
     */
    public function getAllFieldElementsByModuleAndTableId($modId, $tabId, $start = 0, $limit = 0, $sort = 'fieldelement_id ASC, fieldelement_name', $order = 'ASC')

This method seems to be duplicated in your project.

    {
        $criteriaAllFieldElementsByModule = new CriteriaCompo();
        $criteriaAllFieldElementsByModule->add(new Criteria('fieldelement_mid', $modId));
        $criteriaAllFieldElementsByModule->add(new Criteria('fieldelement_tid', $tabId));
        $criteriaAllFieldElementsByModule = $this->getFieldElementsCriteria($criteriaAllFieldElementsByModule, $start, $limit, $sort, $order);

        return $this->getAll($criteriaAllFieldElementsByModule);
    }

    /**
     * Get FieldElements Criteria.
     */
    private function getFieldElementsCriteria($criteriaFieldElements, $start, $limit, $sort, $order)
    {
        $criteriaFieldElements->setStart($start);
        $criteriaFieldElements->setLimit($limit);
        $criteriaFieldElements->setSort($sort);
        $criteriaFieldElements->setOrder($order);

        return $criteriaFieldElements;
    }
}