txmodxoops /
tdmcreate
Complex classes like ClassXoopsCode often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ClassXoopsCode, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 28 | class ClassXoopsCode |
||
|
|
|||
| 29 | { |
||
| 30 | /* |
||
| 31 | * @var mixed |
||
| 32 | */ |
||
| 33 | private $phpcode = null; |
||
| 34 | |||
| 35 | /* |
||
| 36 | * @var mixed |
||
| 37 | */ |
||
| 38 | private $xoopscode = null; |
||
| 39 | |||
| 40 | /* |
||
| 41 | * @public function constructor |
||
| 42 | * @param null |
||
| 43 | */ |
||
| 44 | /** |
||
| 45 | * |
||
| 46 | */ |
||
| 47 | public function __construct() |
||
| 52 | |||
| 53 | /* |
||
| 54 | * @static function &getInstance |
||
| 55 | * @param null |
||
| 56 | */ |
||
| 57 | /** |
||
| 58 | * @return ClassXoopsCode |
||
| 59 | */ |
||
| 60 | public static function &getInstance() |
||
| 69 | |||
| 70 | /* |
||
| 71 | * @public function getClassCriteriaCompo |
||
| 72 | * @param $var |
||
| 73 | * |
||
| 74 | * @return string |
||
| 75 | */ |
||
| 76 | public function getClassCriteriaCompo($var, $t = '') |
||
| 80 | |||
| 81 | /* |
||
| 82 | * @public function getClassCriteria |
||
| 83 | * @param $var |
||
| 84 | * @param $param1 |
||
| 85 | * @param $param2 |
||
| 86 | * @param $param3 |
||
| 87 | * |
||
| 88 | * @return string |
||
| 89 | */ |
||
| 90 | public function getClassCriteria($var, $param1, $param2 = '', $param3 = '', $isParam = false, $t = '') |
||
| 103 | |||
| 104 | /* |
||
| 105 | * @public function getClassAdd |
||
| 106 | * @param $var |
||
| 107 | * @param $param |
||
| 108 | * |
||
| 109 | * @return string |
||
| 110 | */ |
||
| 111 | public function getClassAdd($var, $param, $t = '') |
||
| 115 | |||
| 116 | /* |
||
| 117 | * @public function getClassSetStart |
||
| 118 | * @param $var |
||
| 119 | * @param $start |
||
| 120 | * |
||
| 121 | * @return string |
||
| 122 | */ |
||
| 123 | public function getClassSetStart($var, $start, $t = '') |
||
| 127 | |||
| 128 | /* |
||
| 129 | * @public function getClassSetLimit |
||
| 130 | * @param $var |
||
| 131 | * @param $limit |
||
| 132 | * |
||
| 133 | * @return string |
||
| 134 | */ |
||
| 135 | public function getClassSetLimit($var, $limit, $t = '') |
||
| 139 | |||
| 140 | /* |
||
| 141 | * @public function getClassAdd |
||
| 142 | * @param $var |
||
| 143 | * @param $sort |
||
| 144 | * |
||
| 145 | * @return string |
||
| 146 | */ |
||
| 147 | public function getClassSetSort($var, $sort, $t = '') |
||
| 151 | |||
| 152 | /* |
||
| 153 | * @public function getClassAdd |
||
| 154 | * @param $var |
||
| 155 | * @param $order |
||
| 156 | * |
||
| 157 | * @return string |
||
| 158 | */ |
||
| 159 | public function getClassSetOrder($var, $order, $t = '') |
||
| 163 | |||
| 164 | /* |
||
| 165 | * @public function getClassAdd |
||
| 166 | * @param $paramLeft |
||
| 167 | * @param $paramRight |
||
| 168 | * @param $var |
||
| 169 | * @param $t = Indentation |
||
| 170 | * |
||
| 171 | * @return string |
||
| 172 | */ |
||
| 173 | public function getClassInitVar($paramLeft = '', $paramRight = '', $var = 'this', $t = "\t\t") |
||
| 179 | |||
| 180 | /* |
||
| 181 | * @public function getXoopsSimpleForm |
||
| 182 | * @param $left |
||
| 183 | * @param $element |
||
| 184 | * @param $elementsContent |
||
| 185 | * @param $caption |
||
| 186 | * @param $var |
||
| 187 | * @param $filename |
||
| 188 | * @param $type |
||
| 189 | * |
||
| 190 | * @return string |
||
| 191 | */ |
||
| 192 | public function getXoopsSimpleForm($left = '', $element = '', $elementsContent = '', $caption = '', $var = '', $filename = '', $type = 'post', $t = '') |
||
| 203 | |||
| 204 | /* |
||
| 205 | * @public function getClassXoopsThemeForm |
||
| 206 | * @param $var |
||
| 207 | * @param $param1 |
||
| 208 | * @param $param2 |
||
| 209 | * @param $param3 |
||
| 210 | * @param $param4 |
||
| 211 | * @param $isParam |
||
| 212 | * @param $t = Indentation |
||
| 213 | * |
||
| 214 | * @return string |
||
| 215 | */ |
||
| 216 | public function getClassXoopsThemeForm($var, $param1, $param2 = null, $param3 = null, $param4 = null, $isParam = false, $t = "\t\t") |
||
| 227 | |||
| 228 | /* |
||
| 229 | * @public function XoopsFormElementTray |
||
| 230 | * @param $var |
||
| 231 | * @param $param1 |
||
| 232 | * @param $param2 |
||
| 233 | * |
||
| 234 | * @return string |
||
| 235 | */ |
||
| 236 | public function getClassXoopsFormElementTray($var, $param1, $param2 = '', $isParam = false, $t = "\t\t") |
||
| 247 | |||
| 248 | /* |
||
| 249 | * @public function getClassXoopsFormLabel |
||
| 250 | * @param $var |
||
| 251 | * @param $param1 |
||
| 252 | * @param $param2 |
||
| 253 | * |
||
| 254 | * @return string |
||
| 255 | */ |
||
| 256 | public function getClassXoopsFormLabel($var, $param1 = '', $isParam = false, $t = "\t\t") |
||
| 267 | |||
| 268 | /* |
||
| 269 | * @public function getClassXoopsFormFile |
||
| 270 | * @param $var |
||
| 271 | * @param $param1 |
||
| 272 | * @param $param2 |
||
| 273 | * @param $param3 |
||
| 274 | * |
||
| 275 | * @return string |
||
| 276 | */ |
||
| 277 | public function getClassXoopsFormFile($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 288 | |||
| 289 | /* |
||
| 290 | * @public function getClassXoopsFormHidden |
||
| 291 | * @param $var |
||
| 292 | * @param $param1 |
||
| 293 | * @param $param2 |
||
| 294 | * |
||
| 295 | * @return string |
||
| 296 | */ |
||
| 297 | public function getClassXoopsFormHidden($var, $param1, $param2, $isForm = false, $isParam = false, $t = "\t\t") |
||
| 314 | |||
| 315 | /* |
||
| 316 | * @public function getClassXoopsFormText |
||
| 317 | * @param $var |
||
| 318 | * @param $param1 |
||
| 319 | * @param $param2 |
||
| 320 | * @param $param3 |
||
| 321 | * @param $param4 |
||
| 322 | * @param $param5 |
||
| 323 | * |
||
| 324 | * @return string |
||
| 325 | */ |
||
| 326 | public function getClassXoopsFormText($var, $param1, $param2, $param3 = 75, $param4 = 255, $param5, $isParam = false, $t = "\t\t") |
||
| 337 | |||
| 338 | /* |
||
| 339 | * @public function getClassXoopsFormTextArea |
||
| 340 | * @param $var |
||
| 341 | * @param $param1 |
||
| 342 | * @param $param2 |
||
| 343 | * @param $param3 |
||
| 344 | * @param $param4 |
||
| 345 | * @param $param5 |
||
| 346 | * |
||
| 347 | * @return string |
||
| 348 | */ |
||
| 349 | public function getClassXoopsFormTextArea($var, $param1, $param2, $param3, $param4, $isParam = false, $t = "\t\t") |
||
| 361 | |||
| 362 | /* |
||
| 363 | * @public function getClassXoopsFormColorPicker |
||
| 364 | * @param $var |
||
| 365 | * @param $param1 |
||
| 366 | * @param $param2 |
||
| 367 | * @param $param3 |
||
| 368 | * |
||
| 369 | * @return string |
||
| 370 | */ |
||
| 371 | public function getClassXoopsFormColorPicker($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 382 | |||
| 383 | /* |
||
| 384 | * @public function getClassXoopsFormSelectUser |
||
| 385 | * @param $var |
||
| 386 | * @param $param1 |
||
| 387 | * @param $param2 |
||
| 388 | * @param $param3 |
||
| 389 | * |
||
| 390 | * @return string |
||
| 391 | */ |
||
| 392 | public function getClassXoopsFormSelectUser($var, $param1, $param2, $param3 = 'false', $param4, $isParam = false, $t = "\t\t") |
||
| 404 | |||
| 405 | /* |
||
| 406 | * @public function getClassXoopsFormTextDateSelect |
||
| 407 | * @param $var |
||
| 408 | * @param $param1 |
||
| 409 | * @param $param2 |
||
| 410 | * @param $param3 |
||
| 411 | * |
||
| 412 | * @return string |
||
| 413 | */ |
||
| 414 | public function getClassXoopsFormTextDateSelect($var, $param1, $param2, $param3 = '', $param4, $isParam = false, $t = "\t\t") |
||
| 426 | |||
| 427 | /* |
||
| 428 | * @public function getClassXoopsFormEditor |
||
| 429 | * @param $var |
||
| 430 | * @param $param1 |
||
| 431 | * @param $param2 |
||
| 432 | * @param $param3 |
||
| 433 | * |
||
| 434 | * @return string |
||
| 435 | */ |
||
| 436 | public function getClassXoopsFormEditor($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 447 | |||
| 448 | /* |
||
| 449 | * @public function getClassXoopsFormCheckBox |
||
| 450 | * @param $var |
||
| 451 | * @param $param1 |
||
| 452 | * @param $param2 |
||
| 453 | * @param $param3 |
||
| 454 | * |
||
| 455 | * @return string |
||
| 456 | */ |
||
| 457 | public function getClassXoopsFormCheckBox($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 468 | |||
| 469 | /* |
||
| 470 | * @public function getClassXoopsFormRadioYN |
||
| 471 | * @param $var |
||
| 472 | * @param $param1 |
||
| 473 | * @param $param2 |
||
| 474 | * @param $param3 |
||
| 475 | * |
||
| 476 | * @return string |
||
| 477 | */ |
||
| 478 | public function getClassXoopsFormRadioYN($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 489 | |||
| 490 | /* |
||
| 491 | * @public function getClassXoopsFormSelect |
||
| 492 | * @param $var |
||
| 493 | * @param $param1 |
||
| 494 | * @param $param2 |
||
| 495 | * @param $param3 |
||
| 496 | * @param $param4 |
||
| 497 | * @param $param5 |
||
| 498 | * |
||
| 499 | * @return string |
||
| 500 | */ |
||
| 501 | public function getClassXoopsFormSelect($var, $param1, $param2, $param3, $param4, $param5 = 5, $isParam = false, $t = "\t\t") |
||
| 512 | |||
| 513 | /* |
||
| 514 | * @public function getClassXoopsFormTag |
||
| 515 | * @param $var |
||
| 516 | * @param $param1 |
||
| 517 | * @param $param2 |
||
| 518 | * @param $param3 |
||
| 519 | * @param $param4 |
||
| 520 | * @param $param5 |
||
| 521 | * @param $isParam |
||
| 522 | * |
||
| 523 | * @return string |
||
| 524 | */ |
||
| 525 | public function getClassXoopsFormTag($var, $param1, $param2, $param3, $param4, $param5 = 0, $isParam = false, $t = "\t\t") |
||
| 536 | |||
| 537 | /* |
||
| 538 | * @public function getClassXoopsFormButton |
||
| 539 | * @param $var |
||
| 540 | * @param $param1 |
||
| 541 | * @param $param2 |
||
| 542 | * @param $param3 |
||
| 543 | * @param $param4 |
||
| 544 | * @param $isParam |
||
| 545 | * |
||
| 546 | * @return string |
||
| 547 | */ |
||
| 548 | public function getClassXoopsFormButton($var, $param1, $param2, $param3, $param4, $isParam = false, $t = "\t\t") |
||
| 559 | |||
| 560 | /* |
||
| 561 | * @public function getClassAddOption |
||
| 562 | * @param $var |
||
| 563 | * @param $params |
||
| 564 | * |
||
| 565 | * @return string |
||
| 566 | */ |
||
| 567 | public function getClassAddOption($var, $params, $t = "\t\t") |
||
| 571 | |||
| 572 | /* |
||
| 573 | * @public function getClassAddOptionArray |
||
| 574 | * @param $var |
||
| 575 | * @param $params |
||
| 576 | * |
||
| 577 | * @return string |
||
| 578 | */ |
||
| 579 | public function getClassAddOptionArray($var, $params, $t = "\t\t") |
||
| 583 | |||
| 584 | /* |
||
| 585 | * @public function getClassAddElement |
||
| 586 | * @param $var |
||
| 587 | * @param $params |
||
| 588 | * |
||
| 589 | * @return string |
||
| 590 | */ |
||
| 591 | public function getClassAddElement($var = '', $params = '', $t = "\t\t") |
||
| 595 | |||
| 596 | /* |
||
| 597 | * @public function getClassSetDescription |
||
| 598 | * @param $var |
||
| 599 | * @param $params |
||
| 600 | * |
||
| 601 | * @return string |
||
| 602 | */ |
||
| 603 | public function getClassSetDescription($var, $params, $t = "\t\t") |
||
| 607 | |||
| 608 | /* |
||
| 609 | * @public function getClassSetExtra |
||
| 610 | * @param $var |
||
| 611 | * @param $params |
||
| 612 | * |
||
| 613 | * @return string |
||
| 614 | */ |
||
| 615 | public function getClassSetExtra($var, $params, $t = "\t\t") |
||
| 619 | } |
||
| 620 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.