Complex classes like ClassXoopsCode often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ClassXoopsCode, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 28 | class ClassXoopsCode |
||
|
|
|||
| 29 | { |
||
| 30 | /* |
||
| 31 | * @static function getInstance |
||
| 32 | * @param null |
||
| 33 | */ |
||
| 34 | /** |
||
| 35 | * @return ClassXoopsCode |
||
| 36 | */ |
||
| 37 | public static function getInstance() |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @public function getClassCriteriaCompo |
||
| 49 | * |
||
| 50 | * @param $var |
||
| 51 | * @param string $t |
||
| 52 | * |
||
| 53 | * @return string |
||
| 54 | */ |
||
| 55 | public function getClassCriteriaCompo($var, $t = '') |
||
| 59 | |||
| 60 | /** |
||
| 61 | * @public function getClassCriteria |
||
| 62 | * |
||
| 63 | * @param $var |
||
| 64 | * @param $param1 |
||
| 65 | * @param string $param2 |
||
| 66 | * @param string $param3 |
||
| 67 | * @param bool $isParam |
||
| 68 | * @param string $t |
||
| 69 | * |
||
| 70 | * @return string |
||
| 71 | */ |
||
| 72 | public function getClassCriteria($var, $param1, $param2 = '', $param3 = '', $isParam = false, $t = '') |
||
| 85 | |||
| 86 | /** |
||
| 87 | * @public function getClassAdd |
||
| 88 | * |
||
| 89 | * @param $var |
||
| 90 | * @param $param |
||
| 91 | * @param string $t |
||
| 92 | * |
||
| 93 | * @return string |
||
| 94 | */ |
||
| 95 | public function getClassAdd($var, $param, $t = '') |
||
| 99 | |||
| 100 | /** |
||
| 101 | * @public function getClassSetStart |
||
| 102 | * |
||
| 103 | * @param $var |
||
| 104 | * @param $start |
||
| 105 | * @param string $t |
||
| 106 | * |
||
| 107 | * @return string |
||
| 108 | */ |
||
| 109 | public function getClassSetStart($var, $start, $t = '') |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @public function getClassSetLimit |
||
| 116 | * |
||
| 117 | * @param $var |
||
| 118 | * @param $limit |
||
| 119 | * @param string $t |
||
| 120 | * |
||
| 121 | * @return string |
||
| 122 | */ |
||
| 123 | public function getClassSetLimit($var, $limit, $t = '') |
||
| 127 | |||
| 128 | /** |
||
| 129 | * @public function getClassAdd |
||
| 130 | * |
||
| 131 | * @param $var |
||
| 132 | * @param $sort |
||
| 133 | * @param string $t |
||
| 134 | * |
||
| 135 | * @return string |
||
| 136 | */ |
||
| 137 | public function getClassSetSort($var, $sort, $t = '') |
||
| 141 | |||
| 142 | /** |
||
| 143 | * @public function getClassAdd |
||
| 144 | * |
||
| 145 | * @param $var |
||
| 146 | * @param $order |
||
| 147 | * @param string $t |
||
| 148 | * |
||
| 149 | * @return string |
||
| 150 | */ |
||
| 151 | public function getClassSetOrder($var, $order, $t = '') |
||
| 155 | |||
| 156 | /** |
||
| 157 | * @public function getClassAdd |
||
| 158 | * |
||
| 159 | * @param string $paramLeft |
||
| 160 | * @param string $paramRight |
||
| 161 | * @param string $var |
||
| 162 | * @param string $t |
||
| 163 | * |
||
| 164 | * @return string |
||
| 165 | */ |
||
| 166 | public function getClassInitVar($paramLeft = '', $paramRight = '', $var = 'this', $t = "\t\t") |
||
| 172 | |||
| 173 | /** |
||
| 174 | * @public function getClassXoopsPageNav |
||
| 175 | * |
||
| 176 | * @param $var |
||
| 177 | * @param $param1 |
||
| 178 | * @param null $param2 |
||
| 179 | * @param null $param3 |
||
| 180 | * @param null $param4 |
||
| 181 | * @param null $param5 |
||
| 182 | * @param bool $isParam |
||
| 183 | * @param string $t |
||
| 184 | * |
||
| 185 | * @return string |
||
| 186 | */ |
||
| 187 | public function getClassXoopsPageNav($var, $param1, $param2 = null, $param3 = null, $param4 = null, $param5 = null, $isParam = false, $t = '') |
||
| 198 | |||
| 199 | /** |
||
| 200 | * @public function getXoopsSimpleForm |
||
| 201 | * |
||
| 202 | * @param string $left |
||
| 203 | * @param string $element |
||
| 204 | * @param string $elementsContent |
||
| 205 | * @param string $caption |
||
| 206 | * @param string $var |
||
| 207 | * @param string $filename |
||
| 208 | * @param string $type |
||
| 209 | * @param string $t |
||
| 210 | * |
||
| 211 | * @return string |
||
| 212 | */ |
||
| 213 | public function getXoopsSimpleForm($left = '', $element = '', $elementsContent = '', $caption = '', $var = '', $filename = '', $type = 'post', $t = '') |
||
| 224 | |||
| 225 | /** |
||
| 226 | * @public function getClassXoopsThemeForm |
||
| 227 | * |
||
| 228 | * @param $var |
||
| 229 | * @param $param1 |
||
| 230 | * @param null $param2 |
||
| 231 | * @param null $param3 |
||
| 232 | * @param null $param4 |
||
| 233 | * @param bool $isParam |
||
| 234 | * @param string $t |
||
| 235 | * |
||
| 236 | * @return string |
||
| 237 | */ |
||
| 238 | public function getClassXoopsThemeForm($var, $param1, $param2 = null, $param3 = null, $param4 = null, $isParam = false, $t = "\t\t") |
||
| 249 | |||
| 250 | /** |
||
| 251 | * @public function XoopsFormElementTray |
||
| 252 | * |
||
| 253 | * @param $var |
||
| 254 | * @param $param1 |
||
| 255 | * @param string $param2 |
||
| 256 | * @param string $t |
||
| 257 | * |
||
| 258 | * @return string |
||
| 259 | */ |
||
| 260 | public function getClassXoopsFormElementTray($var, $param1, $param2 = '', $t = "\t\t") |
||
| 264 | |||
| 265 | /** |
||
| 266 | * @public function getClassXoopsFormLabel |
||
| 267 | * |
||
| 268 | * @param $var |
||
| 269 | * @param string $param1 |
||
| 270 | * @param null $param2 |
||
| 271 | * @param bool $isParam |
||
| 272 | * @param string $t |
||
| 273 | * |
||
| 274 | * @return string |
||
| 275 | */ |
||
| 276 | public function getClassXoopsFormLabel($var, $param1 = '', $param2 = null, $isParam = false, $t = "\t\t") |
||
| 288 | |||
| 289 | /** |
||
| 290 | * @public function getClassXoopsFormFile |
||
| 291 | * |
||
| 292 | * @param $var |
||
| 293 | * @param $param1 |
||
| 294 | * @param $param2 |
||
| 295 | * @param $param3 |
||
| 296 | * @param bool $isParam |
||
| 297 | * @param string $t |
||
| 298 | * |
||
| 299 | * @return string |
||
| 300 | */ |
||
| 301 | public function getClassXoopsFormFile($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 312 | |||
| 313 | /** |
||
| 314 | * @public function getClassXoopsFormHidden |
||
| 315 | * |
||
| 316 | * @param $var |
||
| 317 | * @param $param1 |
||
| 318 | * @param $param2 |
||
| 319 | * @param bool $isForm |
||
| 320 | * @param bool $isParam |
||
| 321 | * @param string $t |
||
| 322 | * |
||
| 323 | * @return string |
||
| 324 | */ |
||
| 325 | public function getClassXoopsFormHidden($var, $param1, $param2, $isForm = false, $isParam = false, $t = "\t\t") |
||
| 342 | |||
| 343 | /** |
||
| 344 | * @public function getClassXoopsFormText |
||
| 345 | * |
||
| 346 | * @param $var |
||
| 347 | * @param $param1 |
||
| 348 | * @param $param2 |
||
| 349 | * @param int $param3 |
||
| 350 | * @param int $param4 |
||
| 351 | * @param $param5 |
||
| 352 | * @param bool $isParam |
||
| 353 | * @param string $t |
||
| 354 | * |
||
| 355 | * @return string |
||
| 356 | */ |
||
| 357 | public function getClassXoopsFormText($var, $param1, $param2, $param3 = 75, $param4 = 255, $param5, $isParam = false, $t = "\t\t") |
||
| 368 | |||
| 369 | /** |
||
| 370 | * @public function getClassXoopsFormTextArea |
||
| 371 | * |
||
| 372 | * @param $var |
||
| 373 | * @param $param1 |
||
| 374 | * @param $param2 |
||
| 375 | * @param $param3 |
||
| 376 | * @param $param4 |
||
| 377 | * @param bool $isParam |
||
| 378 | * @param string $t |
||
| 379 | * |
||
| 380 | * @return string |
||
| 381 | */ |
||
| 382 | public function getClassXoopsFormTextArea($var, $param1, $param2, $param3, $param4, $isParam = false, $t = "\t\t") |
||
| 394 | |||
| 395 | /** |
||
| 396 | * @public function getClassXoopsFormColorPicker |
||
| 397 | * |
||
| 398 | * @param $var |
||
| 399 | * @param $param1 |
||
| 400 | * @param $param2 |
||
| 401 | * @param $param3 |
||
| 402 | * @param bool $isParam |
||
| 403 | * @param string $t |
||
| 404 | * |
||
| 405 | * @return string |
||
| 406 | */ |
||
| 407 | public function getClassXoopsFormColorPicker($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 418 | |||
| 419 | /** |
||
| 420 | * @public function getClassXoopsFormSelectUser |
||
| 421 | * |
||
| 422 | * @param $var |
||
| 423 | * @param $param1 |
||
| 424 | * @param $param2 |
||
| 425 | * @param string $param3 |
||
| 426 | * @param $param4 |
||
| 427 | * @param bool $isParam |
||
| 428 | * @param string $t |
||
| 429 | * |
||
| 430 | * @return string |
||
| 431 | */ |
||
| 432 | public function getClassXoopsFormSelectUser($var, $param1, $param2, $param3 = 'false', $param4, $isParam = false, $t = "\t\t") |
||
| 444 | |||
| 445 | /** |
||
| 446 | * @public function getClassXoopsFormTextDateSelect |
||
| 447 | * |
||
| 448 | * @param $var |
||
| 449 | * @param $param1 |
||
| 450 | * @param $param2 |
||
| 451 | * @param string $param3 |
||
| 452 | * @param $param4 |
||
| 453 | * @param bool $isParam |
||
| 454 | * @param string $t |
||
| 455 | * |
||
| 456 | * @return string |
||
| 457 | */ |
||
| 458 | public function getClassXoopsFormTextDateSelect($var, $param1, $param2, $param3 = '', $param4, $isParam = false, $t = "\t\t") |
||
| 470 | |||
| 471 | /** |
||
| 472 | * @public function getClassXoopsFormEditor |
||
| 473 | * |
||
| 474 | * @param $var |
||
| 475 | * @param $param1 |
||
| 476 | * @param $param2 |
||
| 477 | * @param $param3 |
||
| 478 | * @param bool $isParam |
||
| 479 | * @param string $t |
||
| 480 | * |
||
| 481 | * @return string |
||
| 482 | */ |
||
| 483 | public function getClassXoopsFormEditor($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 494 | |||
| 495 | /** |
||
| 496 | * @public function getClassXoopsFormCheckBox |
||
| 497 | * |
||
| 498 | * @param $var |
||
| 499 | * @param $param1 |
||
| 500 | * @param $param2 |
||
| 501 | * @param $param3 |
||
| 502 | * @param bool $isParam |
||
| 503 | * @param string $t |
||
| 504 | * |
||
| 505 | * @return string |
||
| 506 | */ |
||
| 507 | public function getClassXoopsFormCheckBox($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 518 | |||
| 519 | /** |
||
| 520 | * @public function getClassXoopsFormRadioYN |
||
| 521 | * |
||
| 522 | * @param $var |
||
| 523 | * @param $param1 |
||
| 524 | * @param $param2 |
||
| 525 | * @param $param3 |
||
| 526 | * @param bool $isParam |
||
| 527 | * @param string $t |
||
| 528 | * |
||
| 529 | * @return string |
||
| 530 | */ |
||
| 531 | public function getClassXoopsFormRadioYN($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 542 | |||
| 543 | /** |
||
| 544 | * @public function getClassXoopsFormSelect |
||
| 545 | * |
||
| 546 | * @param $var |
||
| 547 | * @param $param1 |
||
| 548 | * @param $param2 |
||
| 549 | * @param $param3 |
||
| 550 | * @param null $param4 |
||
| 551 | * @param null $param5 |
||
| 552 | * @param bool $isParam |
||
| 553 | * @param string $t |
||
| 554 | * |
||
| 555 | * @return string |
||
| 556 | */ |
||
| 557 | public function getClassXoopsFormSelect($var, $param1, $param2, $param3, $param4 = null, $param5 = null, $isParam = false, $t = "\t\t") |
||
| 569 | |||
| 570 | /** |
||
| 571 | * @public function getClassXoopsFormTag |
||
| 572 | * |
||
| 573 | * @param $var |
||
| 574 | * @param $param1 |
||
| 575 | * @param $param2 |
||
| 576 | * @param $param3 |
||
| 577 | * @param $param4 |
||
| 578 | * @param int $param5 |
||
| 579 | * @param bool $isParam |
||
| 580 | * @param string $t |
||
| 581 | * |
||
| 582 | * @return string |
||
| 583 | */ |
||
| 584 | public function getClassXoopsFormTag($var, $param1, $param2, $param3, $param4, $param5 = 0, $isParam = false, $t = "\t\t") |
||
| 595 | |||
| 596 | /** |
||
| 597 | * @public function getClassXoopsFormButton |
||
| 598 | * |
||
| 599 | * @param $var |
||
| 600 | * @param $param1 |
||
| 601 | * @param $param2 |
||
| 602 | * @param $param3 |
||
| 603 | * @param $param4 |
||
| 604 | * @param bool $isParam |
||
| 605 | * @param string $t |
||
| 606 | * |
||
| 607 | * @return string |
||
| 608 | */ |
||
| 609 | public function getClassXoopsFormButton($var, $param1, $param2, $param3, $param4, $isParam = false, $t = "\t\t") |
||
| 620 | |||
| 621 | /** |
||
| 622 | * @public function getClassXoopsObjectTree |
||
| 623 | * |
||
| 624 | * @param string $var |
||
| 625 | * @param $param1 |
||
| 626 | * @param $param2 |
||
| 627 | * @param $param3 |
||
| 628 | * @param string $t |
||
| 629 | * |
||
| 630 | * @return string |
||
| 631 | * |
||
| 632 | * @internal param $tableName |
||
| 633 | * @internal param $fieldId |
||
| 634 | * @internal param $fieldParent |
||
| 635 | */ |
||
| 636 | public function getClassXoopsObjectTree($var = 'mytree', $param1, $param2, $param3, $t = '') |
||
| 642 | |||
| 643 | /** |
||
| 644 | * @public function getClassXoopsMakeSelBox |
||
| 645 | * |
||
| 646 | * @param $var |
||
| 647 | * @param $anchor |
||
| 648 | * @param $param1 |
||
| 649 | * @param $param2 |
||
| 650 | * @param string $param3 |
||
| 651 | * @param $param4 |
||
| 652 | * @param string $t |
||
| 653 | * |
||
| 654 | * @return string |
||
| 655 | */ |
||
| 656 | public function getClassXoopsMakeSelBox($var, $anchor, $param1, $param2, $param3 = '--', $param4, $t = '') |
||
| 663 | |||
| 664 | /** |
||
| 665 | * @public function getClassAddOption |
||
| 666 | * |
||
| 667 | * @param $var |
||
| 668 | * @param $params |
||
| 669 | * @param string $t |
||
| 670 | * |
||
| 671 | * @return string |
||
| 672 | */ |
||
| 673 | public function getClassAddOption($var, $params, $t = "\t\t") |
||
| 677 | |||
| 678 | /** |
||
| 679 | * @public function getClassAddOptionArray |
||
| 680 | * |
||
| 681 | * @param $var |
||
| 682 | * @param $params |
||
| 683 | * @param string $t |
||
| 684 | * |
||
| 685 | * @return string |
||
| 686 | */ |
||
| 687 | public function getClassAddOptionArray($var, $params, $t = "\t\t") |
||
| 691 | |||
| 692 | /** |
||
| 693 | * @public function getClassAddElement |
||
| 694 | * |
||
| 695 | * @param string $var |
||
| 696 | * @param string $params |
||
| 697 | * @param string $t |
||
| 698 | * |
||
| 699 | * @return string |
||
| 700 | */ |
||
| 701 | public function getClassAddElement($var = '', $params = '', $t = "\t\t") |
||
| 705 | |||
| 706 | /** |
||
| 707 | * @public function getClassSetDescription |
||
| 708 | * |
||
| 709 | * @param $var |
||
| 710 | * @param $params |
||
| 711 | * @param string $t |
||
| 712 | * |
||
| 713 | * @return string |
||
| 714 | */ |
||
| 715 | public function getClassSetDescription($var, $params, $t = "\t\t") |
||
| 719 | |||
| 720 | /** |
||
| 721 | * @public function getClassSetExtra |
||
| 722 | * |
||
| 723 | * @param $var |
||
| 724 | * @param $params |
||
| 725 | * @param string $t |
||
| 726 | * |
||
| 727 | * @return string |
||
| 728 | */ |
||
| 729 | public function getClassSetExtra($var, $params, $t = "\t\t") |
||
| 733 | } |
||
| 734 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.