txmodxoops /
tdmcreate
Complex classes like TDMCreateHtmlCode often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use TDMCreateHtmlCode, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 28 | class TDMCreateHtmlCode |
||
|
|
|||
| 29 | { |
||
| 30 | /** |
||
| 31 | * @static function getInstance |
||
| 32 | * |
||
| 33 | * @param null |
||
| 34 | * |
||
| 35 | * @return TDMCreateHtmlCode |
||
| 36 | */ |
||
| 37 | public static function getInstance() |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @public function getHtmlTag |
||
| 49 | * @param string $tag |
||
| 50 | * @param array $attributes |
||
| 51 | * @param string $content |
||
| 52 | * @param bool $noClosed |
||
| 53 | * @param bool $noBreak |
||
| 54 | * @param string $t |
||
| 55 | * @return string |
||
| 56 | */ |
||
| 57 | public function getHtmlTag($tag = '', $attributes = [], $content = '', $noClosed = false, $noBreak = false, $t = '') |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @private function setAttributes |
||
| 80 | * @param array $attributes |
||
| 81 | * |
||
| 82 | * @return string |
||
| 83 | */ |
||
| 84 | private function getAttributes($attributes) |
||
| 95 | |||
| 96 | /** |
||
| 97 | * @public function getHtmlEmpty |
||
| 98 | * @param string $empty |
||
| 99 | * |
||
| 100 | * @return string |
||
| 101 | */ |
||
| 102 | public function getHtmlEmpty($empty = '') |
||
| 106 | |||
| 107 | /** |
||
| 108 | * @public function getHtmlComment |
||
| 109 | * @param string $htmlComment |
||
| 110 | * @return string |
||
| 111 | */ |
||
| 112 | public function getHtmlComment($htmlComment = '') |
||
| 116 | |||
| 117 | /** |
||
| 118 | * @public function getHtmlBr |
||
| 119 | * @param int $brNumb |
||
| 120 | * @param string $htmlClass |
||
| 121 | * @param string $t |
||
| 122 | * @return string |
||
| 123 | */ |
||
| 124 | public function getHtmlBr($brNumb = 1, $htmlClass = '', $t = '') |
||
| 134 | |||
| 135 | /** |
||
| 136 | * @public function getHtmlHNumb |
||
| 137 | * @param string $content |
||
| 138 | * @param string $n |
||
| 139 | * @param string $htmlHClass |
||
| 140 | * @param string $t |
||
| 141 | * @return string |
||
| 142 | */ |
||
| 143 | public function getHtmlHNumb($content = '', $n = '1', $htmlHClass = '', $t = '') |
||
| 150 | |||
| 151 | /** |
||
| 152 | * @public function getHtmlDiv |
||
| 153 | * @param string $content |
||
| 154 | * @param string $divClass |
||
| 155 | * @param string $t |
||
| 156 | * @return string |
||
| 157 | */ |
||
| 158 | public function getHtmlDiv($content = '', $divClass = '', $t = '') |
||
| 167 | |||
| 168 | /** |
||
| 169 | * @public function getHtmlPre |
||
| 170 | * @param string $content |
||
| 171 | * @param string $preClass |
||
| 172 | * @param string $t |
||
| 173 | * @return string |
||
| 174 | */ |
||
| 175 | public function getHtmlPre($content = '', $preClass = '', $t = '') |
||
| 184 | |||
| 185 | /** |
||
| 186 | * @public function getHtmlSpan |
||
| 187 | * @param string $content |
||
| 188 | * @param string $spanClass |
||
| 189 | * @param string $t |
||
| 190 | * @return string |
||
| 191 | */ |
||
| 192 | public function getHtmlSpan($content = '', $spanClass = '', $t = '') |
||
| 199 | |||
| 200 | /** |
||
| 201 | * @public function getHtmlParagraph |
||
| 202 | * @param string $content |
||
| 203 | * @param string $pClass |
||
| 204 | * @param string $t |
||
| 205 | * @return string |
||
| 206 | */ |
||
| 207 | public function getHtmlParagraph($content = '', $pClass = '', $t = '') |
||
| 216 | |||
| 217 | /** |
||
| 218 | * @public function getHtmlI |
||
| 219 | * @param string $content |
||
| 220 | * @param string $iClass |
||
| 221 | * @param string $t |
||
| 222 | * @return string |
||
| 223 | */ |
||
| 224 | public function getHtmlI($content = '', $iClass = '', $t = '') |
||
| 231 | |||
| 232 | /** |
||
| 233 | * @public function getHtmlUl |
||
| 234 | * @param string $content |
||
| 235 | * @param string $ulClass |
||
| 236 | * @param string $t |
||
| 237 | * @return string |
||
| 238 | */ |
||
| 239 | public function getHtmlUl($content = '', $ulClass = '', $t = '') |
||
| 248 | |||
| 249 | /** |
||
| 250 | * @public function getHtmlOl |
||
| 251 | * @param string $content |
||
| 252 | * @param string $olClass |
||
| 253 | * @param string $t |
||
| 254 | * @return string |
||
| 255 | */ |
||
| 256 | public function getHtmlOl($content = '', $olClass = '', $t = '') |
||
| 265 | |||
| 266 | /** |
||
| 267 | * @public function getHtmlLi |
||
| 268 | * @param string $content |
||
| 269 | * @param string $liClass |
||
| 270 | * @param string $t |
||
| 271 | * @return string |
||
| 272 | */ |
||
| 273 | public function getHtmlLi($content = '', $liClass = '', $t = '') |
||
| 279 | |||
| 280 | /** |
||
| 281 | * @public function getHtmlStrong |
||
| 282 | * @param string $content |
||
| 283 | * @param string $strongClass |
||
| 284 | * @param string $t |
||
| 285 | * @return string |
||
| 286 | */ |
||
| 287 | public function getHtmlStrong($content = '', $strongClass = '', $t = '') |
||
| 293 | |||
| 294 | /** |
||
| 295 | * @public function getHtmlAnchor |
||
| 296 | * @param string $url |
||
| 297 | * @param string $content |
||
| 298 | * @param string $title |
||
| 299 | * @param string $target |
||
| 300 | * @param string $aClass |
||
| 301 | * @param string $rel |
||
| 302 | * @param string $t |
||
| 303 | * @return string |
||
| 304 | */ |
||
| 305 | public function getHtmlAnchor($url = '#', $content = ' ', $title = '', $target = '', $aClass = '', $rel = '', $t = '') |
||
| 313 | |||
| 314 | /** |
||
| 315 | * @public function getHtmlImage |
||
| 316 | * @param string $src |
||
| 317 | * @param string $alt |
||
| 318 | * @param string $imgClass |
||
| 319 | * @param string $t |
||
| 320 | * @return string |
||
| 321 | */ |
||
| 322 | public function getHtmlImage($src = 'blank.gif', $alt = 'blank.gif', $imgClass = '', $t = '') |
||
| 329 | |||
| 330 | /** |
||
| 331 | * @public function getHtmlTable |
||
| 332 | * @param string $content |
||
| 333 | * @param string $tableClass |
||
| 334 | * @param string $t |
||
| 335 | * @return string |
||
| 336 | */ |
||
| 337 | public function getHtmlTable($content = '', $tableClass = '', $t = '') |
||
| 346 | |||
| 347 | /** |
||
| 348 | * @public function getHtmlTableThead |
||
| 349 | * @param string $content |
||
| 350 | * @param string $theadClass |
||
| 351 | * @param string $t |
||
| 352 | * @return string |
||
| 353 | */ |
||
| 354 | public function getHtmlTableThead($content = '', $theadClass = '', $t = '') |
||
| 363 | |||
| 364 | /** |
||
| 365 | * @public function getHtmlTableTbody |
||
| 366 | * @param string $content |
||
| 367 | * @param string $tbodyClass |
||
| 368 | * @param string $t |
||
| 369 | * @return string |
||
| 370 | */ |
||
| 371 | public function getHtmlTableTbody($content = '', $tbodyClass = '', $t = '') |
||
| 380 | |||
| 381 | /** |
||
| 382 | * @public function getHtmlTableTfoot |
||
| 383 | * @param string $content |
||
| 384 | * @param string $tfootClass |
||
| 385 | * @param string $t |
||
| 386 | * @return string |
||
| 387 | */ |
||
| 388 | public function getHtmlTableTfoot($content = '', $tfootClass = '', $t = '') |
||
| 397 | |||
| 398 | /** |
||
| 399 | * @public function getHtmlTableRow |
||
| 400 | * @param string $content |
||
| 401 | * @param string $trClass |
||
| 402 | * @param string $t |
||
| 403 | * @return string |
||
| 404 | */ |
||
| 405 | public function getHtmlTableRow($content = '', $trClass = '', $t = '') |
||
| 414 | |||
| 415 | /** |
||
| 416 | * @public function getHtmlTableHead |
||
| 417 | * @param string $content |
||
| 418 | * @param string $thClass |
||
| 419 | * @param string $colspan |
||
| 420 | * @param string $t |
||
| 421 | * @return string |
||
| 422 | */ |
||
| 423 | public function getHtmlTableHead($content = '', $thClass = '', $colspan = '', $t = '') |
||
| 430 | |||
| 431 | /** |
||
| 432 | * @public function getHtmlTableData |
||
| 433 | * @param string $content |
||
| 434 | * @param string $tdClass |
||
| 435 | * @param string $colspan |
||
| 436 | * @param string $t |
||
| 437 | * @return string |
||
| 438 | */ |
||
| 439 | public function getHtmlTableData($content = '', $tdClass = '', $colspan = '', $t = '') |
||
| 446 | } |
||
| 447 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.