AdminMenu::getAdminMenuList() - Code Metrics - Inspection of "Timgno" - txmodxoops/tdmcreate - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#42)

by Gino
created 2016-01-11 21:40 UTC
AdminMenu::getAdminMenuList() B

↳ Parent: AdminMenu
Complexity

Conditions	4
Paths	6
Size

Total Lines	26
Code Lines	20
Duplication

Lines	0
Ratio	0 %
Metric	Value
dl	0
loc	26
rs	8.5806
cc	4
eloc	20
nc	6
nop	4
<?php


/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */
/**
 * tdmcreate module.
 *
 * @copyright       The XOOPS Project http://sourceforge.net/projects/xoops/
 * @license         GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 *
 * @since           2.5.0
 *
 * @author          Txmod Xoops http://www.txmodxoops.org
 *
 * @version         $Id: admin_menu.php 12258 2014-01-02 09:33:29Z timgno $
 */
defined('XOOPS_ROOT_PATH') or die('Restricted access');
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);

/**
 * Class AdminMenu.
 */
class AdminMenu extends TDMCreateFile
namespace YourVendor;

class YourClass { }
{
    /*
    *  @public function constructor
    *  @param null
    */
    /**
     *
     */
    public function __construct()
    {
        parent::__construct();
        $this->tdmcfile = TDMCreateFile::getInstance();

        $this->xoopscode = TDMCreateXoopsCode::getInstance();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /*
    *  @static function &getInstance
    *  @param null
    */
    /**
     * @return AdminMenu
     */
    public static function &getInstance()
    {
        static $instance = false;
        if (!$instance) {
            $instance = new self();
        }

        return $instance;
    }

    /*
    *  @public function write
    *  @param string $module
    *  @param object $table
    *  @param array $tables
    *  @param string $filename
    */
    /**
     * @param $module
     * @param $table
     * @param $tables
     * @param $filename
     */
    public function write($module, $tables, $filename)
    {
        $this->setModule($module);
        $this->setTables($tables);
        $this->setFileName($filename);
    }

    /*
     * @private function getAdminMenuArray
     * @param $param
     * @param $adminMenu
     * @param $ref
     *
     * @return string
     */
    private function getAdminMenuArray($param = array(), $adminMenu = false, $ref = false)
    {
        $ret = '';
        foreach ($param as $key => $value) {
            if ($adminMenu) {
                $ret .= $this->xoopscode->getXoopsCodeEqualsOperator("\$adminmenu[\$i]['{$key}']", "{$value}");
            } else {
                if ($ref) {
                    $ret .= $this->xoopscode->getXoopsCodeEqualsOperator("{$key}", "{$value}", true);
                } else {
                    $ret .= $this->xoopscode->getXoopsCodeEqualsOperator("{$key}", "{$value}");
                }
            }
        }

        return $ret;
    }

    /*
    *  @private function getAdminMenuHeader
    *  @param null
    */
    /**
     * @return string
     */
    private function getAdminMenuHeader()
    {
        $dirname = array('$dirname' => 'basename(dirname(__DIR__))');
        $ret = $this->getAdminMenuArray($dirname);
        $mod = array('$moduleHandler' => "xoops_gethandler('module')",
                    '$xoopsModule' => 'XoopsModule::getByDirname($dirname)',
                    '$moduleInfo' => "\$moduleHandler->get(\$xoopsModule->getVar('mid'))", );
        $ret .= $this->getAdminMenuArray($mod, false, true);
        $sys = array('$sysPathIcon32' => "\$moduleInfo->getInfo('sysicons32')");
        $ret .= $this->getAdminMenuArray($sys);

        return $ret;
    }

    /*
    *  @private function getAdminMenuDashboard
    *  @param string $language
    *  @param integer $menu
    */
    /**
     * @param $language
     * @param $menu
     *
     * @return string
     */
    private function getAdminMenuDashboard($language, $menu)
    {
        $param = array('title' => "{$language}{$menu}", 'link' => "'admin/index.php'", 'icon' => "\$sysPathIcon32.'/dashboard.png'");
        $ret = $this->xoopscode->getXoopsCodeEqualsOperator('$i', '1');
        $ret .= $this->getAdminMenuArray($param, true);
        $ret .= $this->getSimpleString('++$i;');

        return $ret;
    }

    /*
    *  @private function getAdminMenuImagesPath
    *  @param array $tables
    *  @param integer $t
    */
    /**
     * @param $tables
     * @param $t
     *
     * @return string
     */
    private function getAdminMenuImagesPath($tables, $t)

    {
        $ret = '';
        $fields = $this->getTableFields($tables[$t]->getVar('table_id'));

        foreach (array_keys($fields) as $f) {
            $fieldElement = $fields[$f]->getVar('field_element');
            switch ($fieldElement) {
                case 13:
                    $ret = $this->xoopscode->getXoopsCodeEqualsOperator("\$adminmenu[\$i]['icon']", "'assets/icons/32/{$tables[$t]->getVar('table_image')}'");
                    break;
                default:
                    $ret = $this->xoopscode->getXoopsCodeEqualsOperator("\$adminmenu[\$i]['icon']", "\$sysPathIcon32.'/{$tables[$t]->getVar('table_image')}'");
                    break;
            }
        }

        return $ret;
    }

    /*
     * @private function getAdminMenuList
     * @param string $module
     * @param string $language
     * @param string $langAbout
     * @param integer $menu    
     *
     * @return string
     */
    private function getAdminMenuList($module, $language, $langAbout, $menu)
    {
        $ret = '';
        $tables = $this->getTableTables($module->getVar('mod_id'), 'table_order');

        foreach (array_keys($tables) as $t) {
            $tablePermissions[] = $tables[$t]->getVar('table_permissions');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            if (1 == $tables[$t]->getVar('table_admin')) {
                ++$menu;
                $param1 = array('title' => "{$language}{$menu}", 'link' => "'admin/{$tables[$t]->getVar('table_name')}.php'", 'icon' => "'assets/icons/32/{$tables[$t]->getVar('table_image')}'");
                $ret .= $this->getAdminMenuArray($param1, true);
                $ret .= $this->getSimpleString('++$i;');
            }
        }
        if (in_array(1, $tablePermissions)) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            ++$menu;
            $param2 = array('title' => "{$language}{$menu}", 'link' => "'admin/permissions.php'", 'icon' => "\$sysPathIcon32.'/permissions.png'");
            $ret .= $this->getAdminMenuArray($param2, true);
            $ret .= $this->getSimpleString('++$i;');
        }
        unset($menu);
        $param3 = array('title' => "{$langAbout}", 'link' => "'admin/about.php'", 'icon' => "\$sysPathIcon32.'/about.png'");
        $ret .= $this->getAdminMenuArray($param3, true);
        $ret .= $this->getSimpleString('unset($i);');

        return $ret;
    }

    /*
    *  @public function render
    *  @param null
    */
    /**
     * @return bool|string
     */
    public function render()

    {
        $module = $this->getModule();
        $filename = $this->getFileName();
        $moduleDirname = $module->getVar('mod_dirname');
        $language = $this->getLanguage($moduleDirname, 'MI', 'ADMENU');
        $langAbout = $this->getLanguage($moduleDirname, 'MI', 'ABOUT');
        $menu = 1;
        $content = $this->getHeaderFilesComments($module, $filename);
        $content .= $this->getAdminMenuHeader();
        $content .= $this->getAdminMenuDashboard($language, $menu);
        $content .= $this->getAdminMenuList($module, $language, $langAbout, $menu);

        $this->tdmcfile->create($moduleDirname, 'admin', $filename, $content, _AM_TDMCREATE_FILE_CREATED, _AM_TDMCREATE_FILE_NOTCREATED);


        return $this->tdmcfile->renderFile();

    }
}

Pull Request — master (#42)

AdminMenu::getAdminMenuList() B

Complexity

Size

Duplication

Logical Operators are used for Control-Flow

Available Fixes

txmodxoops / tdmcreate

Pull Request — master (#42)

AdminMenu::getAdminMenuList() B

Complexity

Size

Duplication

Logical Operators are used for Control-Flow

Available Fixes

Duplication Side-by-Side

Filter issues like
