txmodxoops /
tdmcreate
Complex classes like ClassFormElements often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ClassFormElements, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 28 | class ClassFormElements extends TDMCreateFile |
||
|
|
|||
| 29 | { |
||
| 30 | /* |
||
| 31 | * @var string |
||
| 32 | */ |
||
| 33 | private $tdmcreate = null; |
||
| 34 | |||
| 35 | /* |
||
| 36 | * @var mixed |
||
| 37 | */ |
||
| 38 | private $xoopscode = null; |
||
| 39 | |||
| 40 | /* |
||
| 41 | * @var mixed |
||
| 42 | */ |
||
| 43 | private $classcode = null; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @public function constructor |
||
| 47 | * |
||
| 48 | * @param null |
||
| 49 | */ |
||
| 50 | public function __construct() |
||
| 58 | |||
| 59 | /* |
||
| 60 | * @static function &getInstance |
||
| 61 | * @param null |
||
| 62 | */ |
||
| 63 | /** |
||
| 64 | * @return ClassFormElements |
||
| 65 | */ |
||
| 66 | public static function &getInstance() |
||
| 75 | |||
| 76 | /* |
||
| 77 | * @public function initForm |
||
| 78 | * @param string $module |
||
| 79 | * @param string $table |
||
| 80 | */ |
||
| 81 | /** |
||
| 82 | * @param $module |
||
| 83 | * @param $table |
||
| 84 | */ |
||
| 85 | public function initForm($module, $table) |
||
| 90 | |||
| 91 | /* |
||
| 92 | * @private function getXoopsFormText |
||
| 93 | * @param string $language |
||
| 94 | * @param string $fieldName |
||
| 95 | * @param string $required |
||
| 96 | */ |
||
| 97 | /** |
||
| 98 | * @param $language |
||
| 99 | * @param $fieldName |
||
| 100 | * @param $required |
||
| 101 | * |
||
| 102 | * @return string |
||
| 103 | */ |
||
| 104 | private function getXoopsFormText($language, $fieldName, $fieldDefault, $required = 'false') |
||
| 121 | |||
| 122 | /* |
||
| 123 | * @private function getXoopsFormText |
||
| 124 | * @param string $language |
||
| 125 | * @param string $fieldName |
||
| 126 | * @param string $required |
||
| 127 | */ |
||
| 128 | /** |
||
| 129 | * @param $language |
||
| 130 | * @param $fieldName |
||
| 131 | * @param string $required |
||
| 132 | * |
||
| 133 | * @return string |
||
| 134 | */ |
||
| 135 | private function getXoopsFormTextArea($language, $fieldName, $required = 'false') |
||
| 144 | |||
| 145 | /* |
||
| 146 | * @private function getXoopsFormDhtmlTextArea |
||
| 147 | * @param string $language |
||
| 148 | * @param string $moduleDirname |
||
| 149 | * @param string $fieldName |
||
| 150 | * @param string $required |
||
| 151 | */ |
||
| 152 | /** |
||
| 153 | * @param $language |
||
| 154 | * @param $moduleDirname |
||
| 155 | * @param $fieldName |
||
| 156 | * @param string $required |
||
| 157 | * |
||
| 158 | * @return string |
||
| 159 | */ |
||
| 160 | private function getXoopsFormDhtmlTextArea($language, $moduleDirname, $fieldName, $required = 'false') |
||
| 174 | |||
| 175 | /* |
||
| 176 | * @private function getXoopsFormCheckBox |
||
| 177 | * @param string $language |
||
| 178 | * @param string $fieldName |
||
| 179 | * @param string $required |
||
| 180 | */ |
||
| 181 | /** |
||
| 182 | * @param $language |
||
| 183 | * @param $fieldName |
||
| 184 | * @param string $required |
||
| 185 | * |
||
| 186 | * @return string |
||
| 187 | */ |
||
| 188 | private function getXoopsFormCheckBox($language, $tableSoleName, $fieldName, $fieldElementId, $required = 'false') |
||
| 216 | |||
| 217 | /* |
||
| 218 | * @private function getXoopsFormHidden |
||
| 219 | * @param string $fieldName |
||
| 220 | */ |
||
| 221 | /** |
||
| 222 | * @param $fieldName |
||
| 223 | * |
||
| 224 | * @return string |
||
| 225 | */ |
||
| 226 | private function getXoopsFormHidden($fieldName) |
||
| 235 | |||
| 236 | /* |
||
| 237 | * @private function getXoopsFormImageList |
||
| 238 | * @param string $language |
||
| 239 | * @param string $moduleDirname |
||
| 240 | * @param string $tableName |
||
| 241 | * @param string $fieldName |
||
| 242 | * @param string $required |
||
| 243 | */ |
||
| 244 | /** |
||
| 245 | * @param $language |
||
| 246 | * @param $moduleDirname |
||
| 247 | * @param $tableName |
||
| 248 | * @param $tableSoleName |
||
| 249 | * @param $fieldName |
||
| 250 | * @param string $required |
||
| 251 | * |
||
| 252 | * @return string |
||
| 253 | */ |
||
| 254 | private function getXoopsFormImageList($language, $moduleDirname, $tableName, $tableSoleName, $fieldName, $required = 'false') |
||
| 285 | |||
| 286 | /* |
||
| 287 | * @private function getXoopsFormSelectFile |
||
| 288 | * @param string $language |
||
| 289 | * @param string $moduleDirname |
||
| 290 | * @param string $fieldName |
||
| 291 | * @param string $fieldDefault |
||
| 292 | * @param string $fieldElement |
||
| 293 | * @param string $required |
||
| 294 | */ |
||
| 295 | /** |
||
| 296 | * @param $language |
||
| 297 | * @param $moduleDirname |
||
| 298 | * @param $fieldName |
||
| 299 | * @param string $required |
||
| 300 | * |
||
| 301 | * @return string |
||
| 302 | */ |
||
| 303 | private function getXoopsFormSelectFile($language, $moduleDirname, $fieldName, $required = 'false') |
||
| 333 | |||
| 334 | /* |
||
| 335 | * @private function getXoopsFormUrlFile |
||
| 336 | * @param string $language |
||
| 337 | * @param string $moduleDirname |
||
| 338 | * @param string $fieldName |
||
| 339 | * @param string $fieldDefault |
||
| 340 | * |
||
| 341 | * @param string $required |
||
| 342 | */ |
||
| 343 | /** |
||
| 344 | * @param $language |
||
| 345 | * @param $moduleDirname |
||
| 346 | * @param $fieldName |
||
| 347 | * @param $fieldDefault |
||
| 348 | * @param $required |
||
| 349 | * |
||
| 350 | * @return string |
||
| 351 | */ |
||
| 352 | private function getXoopsFormUrlFile($language, $moduleDirname, $fieldName, $fieldDefault, $required = 'false') |
||
| 366 | |||
| 367 | /* |
||
| 368 | * @private function getXoopsFormUploadImage |
||
| 369 | * @param string $language |
||
| 370 | * @param string $moduleDirname |
||
| 371 | * @param string $tableName |
||
| 372 | * @param string $required |
||
| 373 | */ |
||
| 374 | /** |
||
| 375 | * @param $language |
||
| 376 | * @param $moduleDirname |
||
| 377 | * @param $tableName |
||
| 378 | * @param string $required |
||
| 379 | * |
||
| 380 | * @return string |
||
| 381 | */ |
||
| 382 | private function getXoopsFormUploadImage($language, $moduleDirname, $tableName, $tableSoleName, $fieldName, $required = 'false') |
||
| 413 | |||
| 414 | /* |
||
| 415 | * @private function getXoopsFormUploadFile |
||
| 416 | * @param string $language |
||
| 417 | * @param string $moduleDirname |
||
| 418 | * @param string $tableName |
||
| 419 | * @param string $fieldName |
||
| 420 | * @param string $required |
||
| 421 | */ |
||
| 422 | /** |
||
| 423 | * @param $language |
||
| 424 | * @param $moduleDirname |
||
| 425 | * @param $tableName |
||
| 426 | * @param $fieldName |
||
| 427 | * @param string $required |
||
| 428 | * |
||
| 429 | * @return string |
||
| 430 | */ |
||
| 431 | private function getXoopsFormUploadFile($language, $moduleDirname, $tableName, $fieldName, $required = 'false') |
||
| 441 | |||
| 442 | /* |
||
| 443 | * @private function getXoopsFormColorPicker |
||
| 444 | * @param string $language |
||
| 445 | * @param string $fieldName |
||
| 446 | * @param string $required |
||
| 447 | */ |
||
| 448 | /** |
||
| 449 | * @param $language |
||
| 450 | * @param $moduleDirname |
||
| 451 | * @param $fieldName |
||
| 452 | * @param string $required |
||
| 453 | * |
||
| 454 | * @return string |
||
| 455 | */ |
||
| 456 | private function getXoopsFormColorPicker($language, $moduleDirname, $fieldName, $required = 'false') |
||
| 465 | |||
| 466 | /* |
||
| 467 | * @private function getXoopsFormSelectBox |
||
| 468 | * @param string $language |
||
| 469 | * @param string $tableName |
||
| 470 | * @param string $fieldName |
||
| 471 | * @param string $required |
||
| 472 | */ |
||
| 473 | /** |
||
| 474 | * @param $language |
||
| 475 | * @param $moduleDirname |
||
| 476 | * @param $tableName |
||
| 477 | * @param $fieldName |
||
| 478 | * @param $required |
||
| 479 | * |
||
| 480 | * @return string |
||
| 481 | */ |
||
| 482 | private function getXoopsFormSelectBox($language, $moduleDirname, $tableName, $fieldName, $required = 'false') |
||
| 498 | |||
| 499 | /* |
||
| 500 | * @private function getXoopsFormSelectUser |
||
| 501 | * @param string $language |
||
| 502 | * @param string $fieldName |
||
| 503 | * @param string $required |
||
| 504 | */ |
||
| 505 | /** |
||
| 506 | * @param $language |
||
| 507 | * @param $fieldName |
||
| 508 | * @param string $required |
||
| 509 | * |
||
| 510 | * @return string |
||
| 511 | */ |
||
| 512 | private function getXoopsFormSelectUser($language, $fieldName, $required = 'false') |
||
| 521 | |||
| 522 | /* |
||
| 523 | * @private function getXoopsFormRadioYN |
||
| 524 | * @param string $language |
||
| 525 | * @param string $fieldName |
||
| 526 | * @param string $required |
||
| 527 | */ |
||
| 528 | /** |
||
| 529 | * @param $language |
||
| 530 | * @param $fieldName |
||
| 531 | * @param string $required |
||
| 532 | * |
||
| 533 | * @return string |
||
| 534 | */ |
||
| 535 | private function getXoopsFormRadioYN($language, $fieldName, $required = 'false') |
||
| 546 | |||
| 547 | /* |
||
| 548 | * @private function getXoopsFormTextDateSelect |
||
| 549 | * @param string $language |
||
| 550 | * @param string $fieldName |
||
| 551 | * @param string $required |
||
| 552 | */ |
||
| 553 | /** |
||
| 554 | * @param $language |
||
| 555 | * @param $fieldName |
||
| 556 | * @param string $required |
||
| 557 | * |
||
| 558 | * @return string |
||
| 559 | */ |
||
| 560 | private function getXoopsFormTextDateSelect($language, $fieldName, $required = 'false') |
||
| 569 | |||
| 570 | /* |
||
| 571 | * @private function getXoopsFormTable |
||
| 572 | * @param string $language |
||
| 573 | * @param string $moduleDirname |
||
| 574 | * @param string $table |
||
| 575 | * @param string $fields |
||
| 576 | * @param string $required |
||
| 577 | */ |
||
| 578 | /** |
||
| 579 | * @param $language |
||
| 580 | * @param $moduleDirname |
||
| 581 | * @param $tableName |
||
| 582 | * @param $fieldName |
||
| 583 | * @param $fieldElement |
||
| 584 | * @param string $required |
||
| 585 | * |
||
| 586 | * @return string |
||
| 587 | */ |
||
| 588 | private function getXoopsFormTable($language, $moduleDirname, $tableName, $fieldName, $fieldElement, $required = 'false') |
||
| 607 | |||
| 608 | /* |
||
| 609 | * @private function getXoopsFormTopic |
||
| 610 | * @param string $language |
||
| 611 | * @param string $moduleDirname |
||
| 612 | * @param string $table |
||
| 613 | * @param string $fields |
||
| 614 | * @param string $required |
||
| 615 | */ |
||
| 616 | /** |
||
| 617 | * @param $language |
||
| 618 | * @param $moduleDirname |
||
| 619 | * @param $table |
||
| 620 | * @param $fields |
||
| 621 | * @param string $required |
||
| 622 | * |
||
| 623 | * @return string |
||
| 624 | */ |
||
| 625 | private function getXoopsFormTopic($language, $moduleDirname, $topicTableName, $fieldId, $fieldPid, $fieldMain, $required = 'false') |
||
| 647 | |||
| 648 | /* |
||
| 649 | * @private function getXoopsFormTag |
||
| 650 | * @param string $moduleDirname |
||
| 651 | * @param string $fieldId |
||
| 652 | * @param string $required |
||
| 653 | */ |
||
| 654 | /** |
||
| 655 | * @param $moduleDirname |
||
| 656 | * @param $fieldId |
||
| 657 | * @param string $required |
||
| 658 | * |
||
| 659 | * @return string |
||
| 660 | */ |
||
| 661 | private function getXoopsFormTag($moduleDirname, $fieldId, $required = 'false') |
||
| 675 | |||
| 676 | /* |
||
| 677 | * @public function renderElements |
||
| 678 | * @param null |
||
| 679 | */ |
||
| 680 | /** |
||
| 681 | * @return string |
||
| 682 | */ |
||
| 683 | public function renderElements() |
||
| 805 | } |
||
| 806 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.