Inspection of "Timgno" - txmodxoops/tdmcreate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#51)

by Gino

created 2016-01-28 16:23 UTC

Status

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -98,7 +98,7 @@  discard block
 block discarded – undo
     /**
      * @param $moduleDirname
      * @param $table
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
     /**
      * @param $moduleDirname
      * @param $table
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
     *  @param string $filename
     */
     /**
-     * @param $filename
+     * @param string $filename
      *
      * @return bool|string
      */

Please login to merge, or discard this patch.

class/files/templates/user/TemplatesUserHeader.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -68,7 +68,7 @@  discard block
 block discarded – undo
     /**
      * @param $module
      * @param $tables
-     * @param $filename
+     * @param string $filename
      */
     public function write($module, $filename)
     {
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
     *  @param null
     */
     /**
-     * @return bool|string
+     * @return string
      */
     public function getTemplatesUserHeader($moduleDirname)
     {

Please login to merge, or discard this patch.

class/files/templates/user/TemplatesUserIndex.php 1 patch

Doc Comments +7 added lines, -4 removed lines patch added patch discarded remove patch

@@ -64,7 +64,7 @@  discard block
 block discarded – undo
      *
      * @param $module
      * @param $table
-     * @param $filename
+     * @param string $filename
      */
     public function write($module, $table, $tables, $filename)
     {
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
     *  @param $moduleDirname
     */
     /**
-     * @return bool|string
+     * @return string
      */
     public function getTemplateUserIndexHeader($moduleDirname)
     {
@@ -177,7 +177,8 @@  discard block
 block discarded – undo
     *  @param null
     */
     /**
-     * @return bool|string
+     * @param string $language
+     * @return string
      */
     public function getTemplatesUserIndexBodyDefault($module, $table, $language)
     {
@@ -231,7 +232,8 @@  discard block
 block discarded – undo
     *  @param null
     */
     /**
-     * @return bool|string
+     * @param string $language
+     * @return string
      */
     public function getTemplateUserIndexCategories($moduleDirname, $tableName, $tableSoleName, $language)
     {
@@ -281,6 +283,7 @@  discard block
 block discarded – undo
     *  @param null
     */
     /**
+     * @param string $language
      * @return bool|string
      */
     public function getTemplateUserIndexTable($moduleDirname, $tableName, $tableSoleName, $language)

Please login to merge, or discard this patch.

class/files/templates/user/TemplatesUserPages.php 1 patch

Doc Comments +7 added lines, -5 removed lines patch added patch discarded remove patch

@@ -112,7 +112,8 @@  discard block
 block discarded – undo
     *  @param string $language
     */
     /**
-     * @param $language
+     * @param string $language
+     * @param string $tableName
      *
      * @return string
      */
@@ -134,9 +135,10 @@  discard block
 block discarded – undo
     *  @param string $language
     */
     /**
-     * @param $moduleDirname
+     * @param string $moduleDirname
      * @param $table
-     * @param $language
+     * @param string $language
+     * @param string $tableName
      *
      * @return string
      */
@@ -180,7 +182,7 @@  discard block
 block discarded – undo
     *  @param string $language
     */
     /**
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -211,7 +213,7 @@  discard block
 block discarded – undo
     *  @param string $filename
     */
     /**
-     * @param $filename
+     * @param string $filename
      *
      * @return bool|string
      */

Please login to merge, or discard this patch.

class/files/templates/user/TemplatesUserPagesList.php 1 patch

Doc Comments +2 added lines, -1 removed lines patch added patch discarded remove patch

@@ -68,6 +68,7 @@  discard block
 block discarded – undo
     /**
      * @param $module
      * @param $table
+     * @param string $filename
      */
     public function write($module, $table, $tables, $filename)
     {
@@ -262,7 +263,7 @@  discard block
 block discarded – undo
     /**
      * @param $moduleDirname
      * @param $table
-     * @param $language
+     * @param string $language
      *
      * @return string
      */

Please login to merge, or discard this patch.

class/files/templates/user/TemplatesUserSearch.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -83,7 +83,7 @@  discard block
 block discarded – undo
     /**
      * @param $moduleDirname
      * @param $table
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
     /**
      * @param $moduleDirname
      * @param $table
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
     /**
      * @param $moduleDirname
      * @param $table
-     * @param $language
+     * @param string $language
      *
      * @return string
      */

Please login to merge, or discard this patch.

class/files/templates/user/TemplatesUserSingle.php 1 patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -83,7 +83,7 @@  discard block
 block discarded – undo
     /**
      * @param $moduleDirname
      * @param $table
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
     /**
      * @param $moduleDirname
      * @param $table
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
     /**
      * @param $moduleDirname
      * @param $table
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
     *  @param string $filename
     */
     /**
-     * @param $filename
+     * @param string $filename
      *
      * @return bool|string
      */

Please login to merge, or discard this patch.

class/files/templates/user/TemplatesUserSubmit.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -100,7 +100,7 @@  discard block
 block discarded – undo
     */
     /**
      * @param $moduleDirname
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
     *  @param string $filename
     */
     /**
-     * @param $filename
+     * @param string $filename
      *
      * @return bool|string
      */

Please login to merge, or discard this patch.

class/files/user/UserXoopsVersion.php 2 patches

Doc Comments +22 added lines, -19 removed lines patch added patch discarded remove patch

@@ -74,7 +74,7 @@  discard block
 block discarded – undo
      * @param $module
      * @param $table
      * @param $tables
-     * @param $filename
+     * @param string $filename
      */
     public function write($module, $table, $tables, $filename)
     {
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
     /**
      * @param $module
      * @param $table
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -527,7 +527,7 @@  discard block
 block discarded – undo
     *  @param $language
     */
     /**
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -571,7 +571,7 @@  discard block
 block discarded – undo
     */
     /**
      * @param $moduleDirname
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -636,7 +636,7 @@  discard block
 block discarded – undo
     /**
      * @param $module
      * @param $table
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -911,7 +911,7 @@  discard block
 block discarded – undo
     */
     /**
      * @param $moduleDirname
-     * @param $language
+     * @param string $language
      * @param $filename
      *
      * @return string
@@ -987,9 +987,9 @@  discard block
 block discarded – undo
     */
     /**
      * @param $language
-     * @param $type
-     * @param $name
-     * @param $title
+     * @param string $type
+     * @param string $name
+     * @param string $title
      * @param $from
      *
      * @return string
@@ -1013,10 +1013,11 @@  discard block
 block discarded – undo
     */
     /**
      * @param $language
-     * @param $type
-     * @param $name
-     * @param $title
+     * @param string $type
+     * @param string $name
+     * @param string $title
      * @param $from
+     * @param string $allow
      *
      * @return string
      */
@@ -1041,9 +1042,9 @@  discard block
 block discarded – undo
     */
     /**
      * @param $language
-     * @param $type
-     * @param $name
-     * @param $title
+     * @param string $type
+     * @param string $name
+     * @param string $title
      * @param $from
      * @param $item
      * @param $allow
@@ -1071,12 +1072,14 @@  discard block
 block discarded – undo
     */
     /**
      * @param $language
-     * @param $type
-     * @param $name
-     * @param $title
+     * @param string $type
+     * @param string $name
+     * @param string $title
      * @param $from
      * @param $item
-     * @param $mail
+     * @param string $mail
+     * @param string $category
+     * @param string $table
      *
      * @return string
      */

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1022,7 +1022,7 @@
 block discarded – undo
      */
     private function getXoopsVersionNotificationCategory($language, $type, $name, $title, $from, $item, $allow)
     {
-        $title = strtoupper($title);//{$from}
+        $title = strtoupper($title); //{$from}
         $ret = "
 \$modversion['notification']['{$type}'][] = array(
     'name' => '{$name}',

Please login to merge, or discard this patch.

		@@ -1022,7 +1022,7 @@
		block discarded – undo
1022	1022	*/
1023	1023	private function getXoopsVersionNotificationCategory($language, $type, $name, $title, $from, $item, $allow)
1024	1024	{
1025		- $title = strtoupper($title);//{$from}
	1025	+ $title = strtoupper($title); //{$from}
1026	1026	$ret = "
1027	1027	\$modversion['notification']['{$type}'][] = array(
1028	1028	'name' => '{$name}',

		@@ -98,7 +98,7 @@ discard block
		block discarded – undo
98	98	/**
99	99	* @param $moduleDirname
100	100	* @param $table
101		- * @param $language
	101	+ * @param string $language
102	102	*
103	103	* @return string
104	104	*/
		@@ -128,7 +128,7 @@ discard block
		block discarded – undo
128	128	/**
129	129	* @param $moduleDirname
130	130	* @param $table
131		- * @param $language
	131	+ * @param string $language
132	132	*
133	133	* @return string
134	134	*/
		@@ -185,7 +185,7 @@ discard block
		block discarded – undo
185	185	* @param string $filename
186	186	*/
187	187	/**
188		- * @param $filename
	188	+ * @param string $filename
189	189	*
190	190	* @return bool\|string
191	191	*/

		@@ -68,7 +68,7 @@ discard block
		block discarded – undo
68	68	/**
69	69	* @param $module
70	70	* @param $tables
71		- * @param $filename
	71	+ * @param string $filename
72	72	*/
73	73	public function write($module, $filename)
74	74	{
		@@ -81,7 +81,7 @@ discard block
		block discarded – undo
81	81	* @param null
82	82	*/
83	83	/**
84		- * @return bool\|string
	84	+ * @return string
85	85	*/
86	86	public function getTemplatesUserHeader($moduleDirname)
87	87	{

		@@ -64,7 +64,7 @@ discard block
		block discarded – undo
64	64	*
65	65	* @param $module
66	66	* @param $table
67		- * @param $filename
	67	+ * @param string $filename
68	68	*/
69	69	public function write($module, $table, $tables, $filename)
70	70	{
		@@ -79,7 +79,7 @@ discard block
		block discarded – undo
79	79	* @param $moduleDirname
80	80	*/
81	81	/**
82		- * @return bool\|string
	82	+ * @return string
83	83	*/
84	84	public function getTemplateUserIndexHeader($moduleDirname)
85	85	{
		@@ -177,7 +177,8 @@ discard block
		block discarded – undo
177	177	* @param null
178	178	*/
179	179	/**
180		- * @return bool\|string
	180	+ * @param string $language
	181	+ * @return string
181	182	*/
182	183	public function getTemplatesUserIndexBodyDefault($module, $table, $language)
183	184	{
		@@ -231,7 +232,8 @@ discard block
		block discarded – undo
231	232	* @param null
232	233	*/
233	234	/**
234		- * @return bool\|string
	235	+ * @param string $language
	236	+ * @return string
235	237	*/
236	238	public function getTemplateUserIndexCategories($moduleDirname, $tableName, $tableSoleName, $language)
237	239	{
		@@ -281,6 +283,7 @@ discard block
		block discarded – undo
281	283	* @param null
282	284	*/
283	285	/**
	286	+ * @param string $language
284	287	* @return bool\|string
285	288	*/
286	289	public function getTemplateUserIndexTable($moduleDirname, $tableName, $tableSoleName, $language)

		@@ -112,7 +112,8 @@ discard block
		block discarded – undo
112	112	* @param string $language
113	113	*/
114	114	/**
115		- * @param $language
	115	+ * @param string $language
	116	+ * @param string $tableName
116	117	*
117	118	* @return string
118	119	*/
		@@ -134,9 +135,10 @@ discard block
		block discarded – undo
134	135	* @param string $language
135	136	*/
136	137	/**
137		- * @param $moduleDirname
	138	+ * @param string $moduleDirname
138	139	* @param $table
139		- * @param $language
	140	+ * @param string $language
	141	+ * @param string $tableName
140	142	*
141	143	* @return string
142	144	*/
		@@ -180,7 +182,7 @@ discard block
		block discarded – undo
180	182	* @param string $language
181	183	*/
182	184	/**
183		- * @param $language
	185	+ * @param string $language
184	186	*
185	187	* @return string
186	188	*/
		@@ -211,7 +213,7 @@ discard block
		block discarded – undo
211	213	* @param string $filename
212	214	*/
213	215	/**
214		- * @param $filename
	216	+ * @param string $filename
215	217	*
216	218	* @return bool\|string
217	219	*/

		@@ -68,6 +68,7 @@ discard block
		block discarded – undo
68	68	/**
69	69	* @param $module
70	70	* @param $table
	71	+ * @param string $filename
71	72	*/
72	73	public function write($module, $table, $tables, $filename)
73	74	{
		@@ -262,7 +263,7 @@ discard block
		block discarded – undo
262	263	/**
263	264	* @param $moduleDirname
264	265	* @param $table
265		- * @param $language
	266	+ * @param string $language
266	267	*
267	268	* @return string
268	269	*/

		@@ -83,7 +83,7 @@ discard block
		block discarded – undo
83	83	/**
84	84	* @param $moduleDirname
85	85	* @param $table
86		- * @param $language
	86	+ * @param string $language
87	87	*
88	88	* @return string
89	89	*/
		@@ -122,7 +122,7 @@ discard block
		block discarded – undo
122	122	/**
123	123	* @param $moduleDirname
124	124	* @param $table
125		- * @param $language
	125	+ * @param string $language
126	126	*
127	127	* @return string
128	128	*/
		@@ -183,7 +183,7 @@ discard block
		block discarded – undo
183	183	/**
184	184	* @param $moduleDirname
185	185	* @param $table
186		- * @param $language
	186	+ * @param string $language
187	187	*
188	188	* @return string
189	189	*/

		@@ -100,7 +100,7 @@ discard block
		block discarded – undo
100	100	*/
101	101	/**
102	102	* @param $moduleDirname
103		- * @param $language
	103	+ * @param string $language
104	104	*
105	105	* @return string
106	106	*/
		@@ -145,7 +145,7 @@ discard block
		block discarded – undo
145	145	* @param string $filename
146	146	*/
147	147	/**
148		- * @param $filename
	148	+ * @param string $filename
149	149	*
150	150	* @return bool\|string
151	151	*/

		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74	* @param $module
75	75	* @param $table
76	76	* @param $tables
77		- * @param $filename
	77	+ * @param string $filename
78	78	*/
79	79	public function write($module, $table, $tables, $filename)
80	80	{
		@@ -238,7 +238,7 @@ discard block
		block discarded – undo
238	238	/**
239	239	* @param $module
240	240	* @param $table
241		- * @param $language
	241	+ * @param string $language
242	242	*
243	243	* @return string
244	244	*/
		@@ -527,7 +527,7 @@ discard block
		block discarded – undo
527	527	* @param $language
528	528	*/
529	529	/**
530		- * @param $language
	530	+ * @param string $language
531	531	*
532	532	* @return string
533	533	*/
		@@ -571,7 +571,7 @@ discard block
		block discarded – undo
571	571	*/
572	572	/**
573	573	* @param $moduleDirname
574		- * @param $language
	574	+ * @param string $language
575	575	*
576	576	* @return string
577	577	*/
		@@ -636,7 +636,7 @@ discard block
		block discarded – undo
636	636	/**
637	637	* @param $module
638	638	* @param $table
639		- * @param $language
	639	+ * @param string $language
640	640	*
641	641	* @return string
642	642	*/
		@@ -911,7 +911,7 @@ discard block
		block discarded – undo
911	911	*/
912	912	/**
913	913	* @param $moduleDirname
914		- * @param $language
	914	+ * @param string $language
915	915	* @param $filename
916	916	*
917	917	* @return string
		@@ -987,9 +987,9 @@ discard block
		block discarded – undo
987	987	*/
988	988	/**
989	989	* @param $language
990		- * @param $type
991		- * @param $name
992		- * @param $title
	990	+ * @param string $type
	991	+ * @param string $name
	992	+ * @param string $title
993	993	* @param $from
994	994	*
995	995	* @return string
		@@ -1013,10 +1013,11 @@ discard block
		block discarded – undo
1013	1013	*/
1014	1014	/**
1015	1015	* @param $language
1016		- * @param $type
1017		- * @param $name
1018		- * @param $title
	1016	+ * @param string $type
	1017	+ * @param string $name
	1018	+ * @param string $title
1019	1019	* @param $from
	1020	+ * @param string $allow
1020	1021	*
1021	1022	* @return string
1022	1023	*/
		@@ -1041,9 +1042,9 @@ discard block
		block discarded – undo
1041	1042	*/
1042	1043	/**
1043	1044	* @param $language
1044		- * @param $type
1045		- * @param $name
1046		- * @param $title
	1045	+ * @param string $type
	1046	+ * @param string $name
	1047	+ * @param string $title
1047	1048	* @param $from
1048	1049	* @param $item
1049	1050	* @param $allow
		@@ -1071,12 +1072,14 @@ discard block
		block discarded – undo
1071	1072	*/
1072	1073	/**
1073	1074	* @param $language
1074		- * @param $type
1075		- * @param $name
1076		- * @param $title
	1075	+ * @param string $type
	1076	+ * @param string $name
	1077	+ * @param string $title
1077	1078	* @param $from
1078	1079	* @param $item
1079		- * @param $mail
	1080	+ * @param string $mail
	1081	+ * @param string $category
	1082	+ * @param string $table
1080	1083	*
1081	1084	* @return string
1082	1085	*/

txmodxoops / tdmcreate

Pull Request — master (#51)

Status

Category

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +7 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +7 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +22 added lines, -19 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch