View GitHub Repository tdmcreate

Schedule Inspection
Subscribe
Passed
Pull Request — master (#145)
by Goffy
04:27
created
Status
Category
Toggle Patches
class/Files/CreateCodeIndents.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -22,11 +22,11 @@
 
 block discarded – undo
22 22 
 $show_table = true;
23 23
24 24 
 echo '<!doctype html>';
25 
-echo nl() . '<html>' . nl(1) . '<head>' . nl(2) . '<title>This is a title</title>' . nl(1) . '</head>' . nl(1) . '<body>' . nl(2) . '<div id="some_container">';
25 
+echo nl().'<html>'.nl(1).'<head>'.nl(2).'<title>This is a title</title>'.nl(1).'</head>'.nl(1).'<body>'.nl(2).'<div id="some_container">';
26 26 
 if ($show_table) {
27 
-    echo nl(3) . '<table>' . nl(4) . '<tr>' . nl(5) . '<td>This is a cell in a table</td>' . nl(4) . '</tr>' . nl(3) . '</table>';
27 
+    echo nl(3).'<table>'.nl(4).'<tr>'.nl(5).'<td>This is a cell in a table</td>'.nl(4).'</tr>'.nl(3).'</table>';
28 28 
 }
29 
-echo nl(2) . '</div><!--some_container-->' . nl(2) . '<p>This is some text in a paragraph</p>' . nl(1) . '</body>' . nl() . '</html>';
29 
+echo nl(2).'</div><!--some_container-->'.nl(2).'<p>This is some text in a paragraph</p>'.nl(1).'</body>'.nl().'</html>';
30 30 
 ?>
31 31 
 <!doctype html>
32 32 
 <html>
Please login to merge, or discard this patch.
class/Files/Admin/AdminIndex.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -85,28 +85,28 @@  discard block
 
 block discarded – undo
85 85 
         $language         = $this->getLanguage($moduleDirname, 'AM');
86 86 
         $languageThereAre = $this->getLanguage($moduleDirname, 'AM', 'THEREARE_');
87 87 
         $ret              = $this->getInclude();
88 
-        $ret              .= $pc->getPhpCodeCommentLine('Count elements');
88 
+        $ret .= $pc->getPhpCodeCommentLine('Count elements');
89 89 
         $tableName        = null;
90 90 
         foreach (array_keys($tables) as $i) {
91 91 
             $tableName    = $tables[$i]->getVar('table_name');
92 92 
             $ucfTableName = ucfirst($tableName);
93 
-            $ret          .= $xc->getXcEqualsOperator("\$count{$ucfTableName}", "\${$tableName}Handler->getCount()");
93 
+            $ret .= $xc->getXcEqualsOperator("\$count{$ucfTableName}", "\${$tableName}Handler->getCount()");
94 94 
         }
95 95 
         $ret .= $pc->getPhpCodeCommentLine('Template Index');
96 96 
         $ret .= $axc->getAdminTemplateMain((string)$moduleDirname, 'index');
97 97 
         $ret .= $pc->getPhpCodeCommentLine('InfoBox Statistics');
98 
-        $ret .= $axc->getAxcAddInfoBox($language . 'STATISTICS');
98 
+        $ret .= $axc->getAxcAddInfoBox($language.'STATISTICS');
99 99 
         $ret .= $pc->getPhpCodeCommentLine('Info elements');
100 100 
         foreach (array_keys($tables) as $i) {
101 101 
             $tableName      = $tables[$i]->getVar('table_name');
102 102 
             $tableInstall[] = $tables[$i]->getVar('table_install');
103 
-            $stuTableName   = $languageThereAre . mb_strtoupper($tableName);
103 
+            $stuTableName   = $languageThereAre.mb_strtoupper($tableName);
104 104 
             $ucfTableName   = ucfirst($tableName);
105 
-            $ret            .= $axc->getAxcAddInfoBoxLine($language . 'STATISTICS', $stuTableName, "\$count{$ucfTableName}");
105 
+            $ret .= $axc->getAxcAddInfoBoxLine($language.'STATISTICS', $stuTableName, "\$count{$ucfTableName}");
106 106 
         }
107 107
108 108 
         if (null === $tableName) {
109 
-            $ret .= $axc->getAxcAddInfoBoxLine($language . 'STATISTICS', 'No statistics', '0');
109 
+            $ret .= $axc->getAxcAddInfoBoxLine($language.'STATISTICS', 'No statistics', '0');
110 110 
         }
111 111 
         if (is_array($tables) && in_array(1, $tableInstall)) {
112 112 
             $ret              .= $pc->getPhpCodeCommentLine('Upload Folders');
 
@@ -123,7 +123,7 @@  discard block
 
 block discarded – undo
123 123 
             $ret     .= $pc->getPhpCodeCommentLine('Uploads Folders Created');
124 124 
             $boxLine = $axc->getAxcAddConfigBoxLine('$folder[$i]', 'folder', '', "\t");
125 125 
             $boxLine .= $axc->getAxcAddConfigBoxLine("array(\$folder[\$i], '777')", 'chmod', '', "\t");
126 
-            $ret     .= $pc->getPhpCodeForeach('folder', true, false, 'i', $boxLine, '') . PHP_EOL;
126 
+            $ret     .= $pc->getPhpCodeForeach('folder', true, false, 'i', $boxLine, '').PHP_EOL;
127 127 
         }
128 128 
         $ret .= $pc->getPhpCodeCommentLine('Render Index');
129 129 
         $ret .= $xc->getXcTplAssign('navigation', "\$adminObject->displayNavigation('index.php')");
 
@@ -145,7 +145,7 @@  discard block
 
 block discarded – undo
145 145 
         $moduleDirname = $module->getVar('mod_dirname');
146 146 
         $filename      = $this->getFileName();
147 147 
         $content       = $this->getHeaderFilesComments($module, $filename);
148 
-        $content       .= $this->getAdminIndex($module);
148 
+        $content .= $this->getAdminIndex($module);
149 149
150 150 
         $this->create($moduleDirname, 'admin', $filename, $content, _AM_TDMCREATE_FILE_CREATED, _AM_TDMCREATE_FILE_NOTCREATED);
151 151
Please login to merge, or discard this patch.
class/Files/Admin/AdminPermissions.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -96,7 +96,7 @@  discard block
 
 block discarded – undo
96 96 
                 $tableName = $tables[$t]->getVar('table_name');
97 97 
             }
98 98 
         }
99 
-        $ret           = $this->getInclude('header');
99 
+        $ret = $this->getInclude('header');
100 100 
         $ret           .= $pc->getPhpCodeIncludeDir('XOOPS_ROOT_PATH', 'class/xoopsform/grouppermform', true);
101 101 
         $ret           .= $xc->getXoopsHandlerLine($moduleDirname, $tableName);
102 102 
         $ret           .= $pc->getPhpCodeCommentLine('Check admin have access to this page');
 
@@ -110,8 +110,8 @@  discard block
 
 block discarded – undo
110 110 
             'submit'  => "{$language}PERMISSIONS_SUBMIT",
111 111 
             'view'    => "{$language}PERMISSIONS_VIEW",
112 112 
         ];
113 
-        $formSelect    = $xc->getXoopsFormSelectExtraOptions('formSelect', '\'\'', 'op', $optionsSelect, 'onchange="document.fselperm.submit()"');
114 
-        $ret           .= $cc->getXoopsSimpleForm('permTableForm', 'formSelect', $formSelect, '\'\'', 'fselperm', 'permissions');
113 
+        $formSelect = $xc->getXoopsFormSelectExtraOptions('formSelect', '\'\'', 'op', $optionsSelect, 'onchange="document.fselperm.submit()"');
114 
+        $ret .= $cc->getXoopsSimpleForm('permTableForm', 'formSelect', $formSelect, '\'\'', 'fselperm', 'permissions');
115 115
116 116 
         return $ret;
117 117 
     }
 
@@ -199,7 +199,7 @@  discard block
 
 block discarded – undo
199 199 
         $if2       = $xc->getXcObjHandlerAll($tableName, $fieldMain, 0, 0, "\t\t");
200 200 
         $getVar1   = $xc->getXcGetVar('', "{$tableName}All[\$i]", $fieldId, true);
201 201 
         $getVar2   = $xc->getXcGetVar('', "{$tableName}All[\$i]", $fieldMain, true);
202 
-        $foreach2  = $xc->getXcAddItem('permform', $getVar1, $getVar2, "\t") . "\r";
202 
+        $foreach2  = $xc->getXcAddItem('permform', $getVar1, $getVar2, "\t")."\r";
203 203 
         $if2       .= $pc->getPhpCodeForeach("{$tableName}All", true, false, 'i', $foreach2, "\t\t");
204 204 
         $if2       .= $xc->getXcTplAssign('form', '$permform->render()', true, "\t\t");
205 205 
         $elseInter = $xc->getXcRedirectHeader($tableName, '?op=new', '3', "{$language}NO_PERMISSIONS_SET", true, "\t\t");
Please login to merge, or discard this patch.
class/Files/Admin/AdminMenu.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -109,7 +109,7 @@
 
 block discarded – undo
109 109 
             '$moduleInfo'    => "\$moduleHandler->get(\$xoopsModule->getVar('mid'))",
110 110 
         ];
111 111 
         $ret     .= $this->getAdminMenuArray($mod);
112 
-        $sys     = ['$sysPathIcon32' => "\$moduleInfo->getInfo('sysicons32')"];
112 
+        $sys = ['$sysPathIcon32' => "\$moduleInfo->getInfo('sysicons32')"];
113 113 
         $ret     .= $this->getAdminMenuArray($sys);
114 114
115 115 
         return $ret;
Please login to merge, or discard this patch.
class/Files/Admin/AdminHeader.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -91,7 +91,7 @@  discard block
 
 block discarded – undo
91 91 
         $table            = $this->getTable();
92 92 
         $tables           = $this->getTables();
93 93 
         $ret              = $this->phpcode->getPhpCodeIncludeDir('dirname(dirname(dirname(__DIR__)))', 'include/cp_header');
94 
-        $ret              .= $this->phpcode->getPhpCodeIncludeDir('dirname(__DIR__)', 'include/common', true);
94 
+        $ret .= $this->phpcode->getPhpCodeIncludeDir('dirname(__DIR__)', 'include/common', true);
95 95 
         $sysicons16       = $this->xc->getXcGetInfo('', 'sysicons16', true);
96 96 
         $sysicons32       = $this->xc->getXcGetInfo('', 'sysicons32', true);
97 97 
         $dirmoduleadmin   = $this->xc->getXcGetInfo('', 'dirmoduleadmin', true);
 
@@ -109,12 +109,12 @@  discard block
 
 block discarded – undo
109 109 
         if (is_array($tables)) {
110 110 
             foreach (array_keys($tables) as $i) {
111 111 
                 $tableName = $tables[$i]->getVar('table_name');
112 
-                $ret       .= $this->xc->getXcEqualsOperator("\${$tableName}Handler", "\${$moduleDirname}->getHandler('{$tableName}')", null, true);
112 
+                $ret .= $this->xc->getXcEqualsOperator("\${$tableName}Handler", "\${$moduleDirname}->getHandler('{$tableName}')", null, true);
113 113 
             }
114 114 
         }
115 115 
         $ret            .= $this->xc->getXcEqualsOperator('$myts', 'MyTextSanitizer::getInstance()', null, false);
116 116 
         $ret            .= $this->phpcode->getPhpCodeCommentLine();
117 
-        $template       = $this->phpcode->getPhpCodeIncludeDir('XOOPS_ROOT_PATH', 'class/template', true, false, 'include', "\t");
117 
+        $template = $this->phpcode->getPhpCodeIncludeDir('XOOPS_ROOT_PATH', 'class/template', true, false, 'include', "\t");
118 118 
         $template       .= $this->xc->getXcEqualsOperator('$xoopsTpl', 'new \XoopsTpl()', null, false, "\t");
119 119 
         $ret            .= $this->phpcode->getPhpCodeConditions('!isset($xoopsTpl)', ' || ', '!is_object($xoopsTpl)', $template, false);
120 120 
         $ret            .= $this->phpcode->getPhpCodeCommentLine('System icons path');
 
@@ -150,7 +150,7 @@  discard block
 
 block discarded – undo
150 150 
         $filename      = $this->getFileName();
151 151 
         $moduleDirname = $module->getVar('mod_dirname');
152 152 
         $content       = $this->getHeaderFilesComments($module, $filename);
153 
-        $content       .= $this->getAdminHeader($moduleDirname);
153 
+        $content .= $this->getAdminHeader($moduleDirname);
154 154
155 155 
         $this->create($moduleDirname, 'admin', $filename, $content, _AM_TDMCREATE_FILE_CREATED, _AM_TDMCREATE_FILE_NOTCREATED);
156 156
Please login to merge, or discard this patch.
class/Files/CreateSmartyCode.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -92,7 +92,7 @@
 
 block discarded – undo
92 92 
         $str = '';
93 93 
         foreach ($attributes as $name => $value) {
94 94 
             if ('_' !== $name) {
95 
-                $str .= ' ' . $name . '="' . $value . '"';
95 
+                $str .= ' '.$name.'="'.$value.'"';
96 96 
             }
97 97 
         }
98 98
Please login to merge, or discard this patch.
class/Files/CreateHtmlCode.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -92,7 +92,7 @@
 
 block discarded – undo
92 92 
         $str = '';
93 93 
         foreach ($attributes as $name => $value) {
94 94 
             if ('_' !== $name) {
95 
-                $str .= ' ' . $name . '="' . $value . '"';
95 
+                $str .= ' '.$name.'="'.$value.'"';
96 96 
             }
97 97 
         }
98 98
Please login to merge, or discard this patch.
class/Files/Language/LanguageMain.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -111,12 +111,12 @@  discard block
 
 block discarded – undo
111 111 
             $ret              .= $this->defines->getDefine($language, "{$stuTableName}_TITLE", "{$ucfTableName} title");
112 112 
             $ret              .= $this->defines->getDefine($language, "{$stuTableName}_DESC", "{$ucfTableName} description");
113 113 
             $ret              .= $this->defines->getAboveDefines("Caption of {$ucfTableSoleName}");
114 
-            $fields           = $this->getTableFields($tables[$i]->getVar('table_mid'), $tables[$i]->getVar('table_id'));
114 
+            $fields = $this->getTableFields($tables[$i]->getVar('table_mid'), $tables[$i]->getVar('table_id'));
115 115 
             foreach (array_keys($fields) as $f) {
116 116 
                 $fieldName     = $fields[$f]->getVar('field_name');
117 117 
                 $rpFieldName   = $this->getRightString($fieldName);
118 118 
                 $fieldNameDesc = ucfirst($rpFieldName);
119 
-                $ret           .= $this->defines->getDefine($language, $stuTableSoleName . '_' . $rpFieldName, $fieldNameDesc);
119 
+                $ret .= $this->defines->getDefine($language, $stuTableSoleName.'_'.$rpFieldName, $fieldNameDesc);
120 120 
             }
121 121 
         }
122 122 
         $ret .= $this->defines->getDefine($language, 'INDEX_THEREARE', "There are %s {$ucfTableName}");
 
@@ -165,7 +165,7 @@  discard block
 
 block discarded – undo
165 165 
         $content       .= $this->geLanguagetMain($module, $language);
166 166 
         $content       .= $this->geLanguagetMainFooter($language);
167 167
168 
-        $this->create($moduleDirname, 'language/' . $GLOBALS['xoopsConfig']['language'], $filename, $content, _AM_TDMCREATE_FILE_CREATED, _AM_TDMCREATE_FILE_NOTCREATED);
168 
+        $this->create($moduleDirname, 'language/'.$GLOBALS['xoopsConfig']['language'], $filename, $content, _AM_TDMCREATE_FILE_CREATED, _AM_TDMCREATE_FILE_NOTCREATED);
169 169
170 170 
         return $this->renderFile();
171 171 
     }
Please login to merge, or discard this patch.
class/Files/Language/LanguageAdmin.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -87,7 +87,7 @@  discard block
 
 block discarded – undo
87 87 
             $tableName    = $tables[$t]->getVar('table_name');
88 88 
             $stuTableName = mb_strtoupper($tableName);
89 89 
             $stlTableName = mb_strtolower($tableName);
90 
-            $ret          .= $this->defines->getDefine($language, "THEREARE_{$stuTableName}", "There are <span class='bold'>%s</span> {$stlTableName} in the database", true);
90 
+            $ret .= $this->defines->getDefine($language, "THEREARE_{$stuTableName}", "There are <span class='bold'>%s</span> {$stlTableName} in the database", true);
91 91 
         }
92 92
93 93 
         return $ret;
 
@@ -107,7 +107,7 @@  discard block
 
 block discarded – undo
107 107 
             $tableName    = $tables[$t]->getVar('table_name');
108 108 
             $stuTableName = mb_strtoupper($tableName);
109 109 
             $stlTableName = mb_strtolower($tableName);
110 
-            $ret          .= $this->defines->getDefine($language, "THEREARENT_{$stuTableName}", "There aren't {$stlTableName}", true);
110 
+            $ret .= $this->defines->getDefine($language, "THEREARENT_{$stuTableName}", "There aren't {$stlTableName}", true);
111 111 
         }
112 112 
         $ret .= $this->defines->getAboveDefines('Save/Delete');
113 113 
         $ret .= $this->defines->getDefine($language, 'FORM_OK', 'Successfully saved');
 
@@ -121,7 +121,7 @@  discard block
 
 block discarded – undo
121 121 
             $tableSoleName    = $tables[$t]->getVar('table_solename');
122 122 
             $stuTableSoleName = mb_strtoupper($tableSoleName);
123 123 
             $ucfTableSoleName = ucfirst($tableSoleName);
124 
-            $ret              .= $this->defines->getDefine($language, "ADD_{$stuTableSoleName}", "Add New {$ucfTableSoleName}");
124 
+            $ret .= $this->defines->getDefine($language, "ADD_{$stuTableSoleName}", "Add New {$ucfTableSoleName}");
125 125 
         }
126 126 
         $ret .= $this->defines->getAboveDefines('Lists');
127 127 
 
@@ -129,7 +129,7 @@  discard block
 
 block discarded – undo
129 129 
             $tableName    = $tables[$t]->getVar('table_name');
130 130 
             $stuTableName = mb_strtoupper($tableName);
131 131 
             $ucfTableName = ucfirst($tableName);
132 
-            $ret          .= $this->defines->getDefine($language, "{$stuTableName}_LIST", "List of {$ucfTableName}");
132 
+            $ret .= $this->defines->getDefine($language, "{$stuTableName}_LIST", "List of {$ucfTableName}");
133 133 
         }
134 134
135 135 
         return $ret;
 
@@ -182,7 +182,7 @@  discard block
 
 block discarded – undo
182 182 
                     $fieldNameDesc = false !== mb_strpos($rpFieldName, '_') ? str_replace('_', ' ', ucfirst($rpFieldName)) : ucfirst($rpFieldName);
183 183 
                 }
184 184
185 
-                $ret          .= $this->defines->getDefine($language, $tableSoleName . '_' . $rpFieldName, $fieldNameDesc);
185 
+                $ret .= $this->defines->getDefine($language, $tableSoleName.'_'.$rpFieldName, $fieldNameDesc);
186 186 
                 $stuTableName = mb_strtoupper($tableName);
187 187
188 188 
                 switch ($fieldElement) {
 
@@ -278,7 +278,7 @@  discard block
 
 block discarded – undo
278 278 
         }
279 279 
         $content .= $this->getLanguageAdminFoot($language);
280 280
281 
-        $this->create($moduleDirname, 'language/' . $GLOBALS['xoopsConfig']['language'], $filename, $content, _AM_TDMCREATE_FILE_CREATED, _AM_TDMCREATE_FILE_NOTCREATED);
281 
+        $this->create($moduleDirname, 'language/'.$GLOBALS['xoopsConfig']['language'], $filename, $content, _AM_TDMCREATE_FILE_CREATED, _AM_TDMCREATE_FILE_NOTCREATED);
282 282
283 283 
         return $this->renderFile();
284 284 
     }
Please login to merge, or discard this patch.