txmodxoops /
tdmcreate
Complex classes like ClassXoopsCode often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ClassXoopsCode, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 28 | class ClassXoopsCode |
||
|
|
|||
| 29 | { |
||
| 30 | /* |
||
| 31 | * @static function &getInstance |
||
| 32 | * @param null |
||
| 33 | */ |
||
| 34 | /** |
||
| 35 | * @return ClassXoopsCode |
||
| 36 | */ |
||
| 37 | public static function &getInstance() |
||
| 46 | |||
| 47 | /* |
||
| 48 | * @public function getClassCriteriaCompo |
||
| 49 | * @param $var |
||
| 50 | * |
||
| 51 | * @return string |
||
| 52 | */ |
||
| 53 | public function getClassCriteriaCompo($var, $t = '') |
||
| 57 | |||
| 58 | /* |
||
| 59 | * @public function getClassCriteria |
||
| 60 | * @param $var |
||
| 61 | * @param $param1 |
||
| 62 | * @param $param2 |
||
| 63 | * @param $param3 |
||
| 64 | * |
||
| 65 | * @return string |
||
| 66 | */ |
||
| 67 | public function getClassCriteria($var, $param1, $param2 = '', $param3 = '', $isParam = false, $t = '') |
||
| 80 | |||
| 81 | /* |
||
| 82 | * @public function getClassAdd |
||
| 83 | * @param $var |
||
| 84 | * @param $param |
||
| 85 | * |
||
| 86 | * @return string |
||
| 87 | */ |
||
| 88 | public function getClassAdd($var, $param, $t = '') |
||
| 92 | |||
| 93 | /* |
||
| 94 | * @public function getClassSetStart |
||
| 95 | * @param $var |
||
| 96 | * @param $start |
||
| 97 | * |
||
| 98 | * @return string |
||
| 99 | */ |
||
| 100 | public function getClassSetStart($var, $start, $t = '') |
||
| 104 | |||
| 105 | /* |
||
| 106 | * @public function getClassSetLimit |
||
| 107 | * @param $var |
||
| 108 | * @param $limit |
||
| 109 | * |
||
| 110 | * @return string |
||
| 111 | */ |
||
| 112 | public function getClassSetLimit($var, $limit, $t = '') |
||
| 116 | |||
| 117 | /* |
||
| 118 | * @public function getClassAdd |
||
| 119 | * @param $var |
||
| 120 | * @param $sort |
||
| 121 | * |
||
| 122 | * @return string |
||
| 123 | */ |
||
| 124 | public function getClassSetSort($var, $sort, $t = '') |
||
| 128 | |||
| 129 | /* |
||
| 130 | * @public function getClassAdd |
||
| 131 | * @param $var |
||
| 132 | * @param $order |
||
| 133 | * |
||
| 134 | * @return string |
||
| 135 | */ |
||
| 136 | public function getClassSetOrder($var, $order, $t = '') |
||
| 140 | |||
| 141 | /* |
||
| 142 | * @public function getClassAdd |
||
| 143 | * @param $paramLeft |
||
| 144 | * @param $paramRight |
||
| 145 | * @param $var |
||
| 146 | * @param $t = Indentation |
||
| 147 | * |
||
| 148 | * @return string |
||
| 149 | */ |
||
| 150 | public function getClassInitVar($paramLeft = '', $paramRight = '', $var = 'this', $t = "\t\t") |
||
| 156 | |||
| 157 | /* |
||
| 158 | * @public function getClassXoopsPageNav |
||
| 159 | * @param $var |
||
| 160 | * @param $param1 |
||
| 161 | * @param $param2 |
||
| 162 | * @param $param3 |
||
| 163 | * @param $param4 |
||
| 164 | * @param $param5 |
||
| 165 | * @param $isParam |
||
| 166 | * @param $t = Indentation |
||
| 167 | * |
||
| 168 | * @return string |
||
| 169 | */ |
||
| 170 | public function getClassXoopsPageNav($var, $param1, $param2 = null, $param3 = null, $param4 = null, $param5 = null, $isParam = false, $t = '') |
||
| 181 | |||
| 182 | /* |
||
| 183 | * @public function getXoopsSimpleForm |
||
| 184 | * @param $left |
||
| 185 | * @param $element |
||
| 186 | * @param $elementsContent |
||
| 187 | * @param $caption |
||
| 188 | * @param $var |
||
| 189 | * @param $filename |
||
| 190 | * @param $type |
||
| 191 | * |
||
| 192 | * @return string |
||
| 193 | */ |
||
| 194 | public function getXoopsSimpleForm($left = '', $element = '', $elementsContent = '', $caption = '', $var = '', $filename = '', $type = 'post', $t = '') |
||
| 205 | |||
| 206 | /* |
||
| 207 | * @public function getClassXoopsThemeForm |
||
| 208 | * @param $var |
||
| 209 | * @param $param1 |
||
| 210 | * @param $param2 |
||
| 211 | * @param $param3 |
||
| 212 | * @param $param4 |
||
| 213 | * @param $isParam |
||
| 214 | * @param $t = Indentation |
||
| 215 | * |
||
| 216 | * @return string |
||
| 217 | */ |
||
| 218 | public function getClassXoopsThemeForm($var, $param1, $param2 = null, $param3 = null, $param4 = null, $isParam = false, $t = "\t\t") |
||
| 229 | |||
| 230 | /* |
||
| 231 | * @public function XoopsFormElementTray |
||
| 232 | * @param $var |
||
| 233 | * @param $param1 |
||
| 234 | * @param $param2 |
||
| 235 | * |
||
| 236 | * @return string |
||
| 237 | */ |
||
| 238 | public function getClassXoopsFormElementTray($var, $param1, $param2 = '', $t = "\t\t") |
||
| 242 | |||
| 243 | /* |
||
| 244 | * @public function getClassXoopsFormLabel |
||
| 245 | * @param $var |
||
| 246 | * @param $param1 |
||
| 247 | * @param $param2 |
||
| 248 | * |
||
| 249 | * @return string |
||
| 250 | */ |
||
| 251 | public function getClassXoopsFormLabel($var, $param1 = '', $param2 = null, $isParam = false, $t = "\t\t") |
||
| 263 | |||
| 264 | /* |
||
| 265 | * @public function getClassXoopsFormFile |
||
| 266 | * @param $var |
||
| 267 | * @param $param1 |
||
| 268 | * @param $param2 |
||
| 269 | * @param $param3 |
||
| 270 | * |
||
| 271 | * @return string |
||
| 272 | */ |
||
| 273 | public function getClassXoopsFormFile($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 284 | |||
| 285 | /* |
||
| 286 | * @public function getClassXoopsFormHidden |
||
| 287 | * @param $var |
||
| 288 | * @param $param1 |
||
| 289 | * @param $param2 |
||
| 290 | * |
||
| 291 | * @return string |
||
| 292 | */ |
||
| 293 | public function getClassXoopsFormHidden($var, $param1, $param2, $isForm = false, $isParam = false, $t = "\t\t") |
||
| 310 | |||
| 311 | /* |
||
| 312 | * @public function getClassXoopsFormText |
||
| 313 | * @param $var |
||
| 314 | * @param $param1 |
||
| 315 | * @param $param2 |
||
| 316 | * @param $param3 |
||
| 317 | * @param $param4 |
||
| 318 | * @param $param5 |
||
| 319 | * |
||
| 320 | * @return string |
||
| 321 | */ |
||
| 322 | public function getClassXoopsFormText($var, $param1, $param2, $param3 = 75, $param4 = 255, $param5, $isParam = false, $t = "\t\t") |
||
| 333 | |||
| 334 | /* |
||
| 335 | * @public function getClassXoopsFormTextArea |
||
| 336 | * @param $var |
||
| 337 | * @param $param1 |
||
| 338 | * @param $param2 |
||
| 339 | * @param $param3 |
||
| 340 | * @param $param4 |
||
| 341 | * @param $param5 |
||
| 342 | * |
||
| 343 | * @return string |
||
| 344 | */ |
||
| 345 | public function getClassXoopsFormTextArea($var, $param1, $param2, $param3, $param4, $isParam = false, $t = "\t\t") |
||
| 357 | |||
| 358 | /* |
||
| 359 | * @public function getClassXoopsFormColorPicker |
||
| 360 | * @param $var |
||
| 361 | * @param $param1 |
||
| 362 | * @param $param2 |
||
| 363 | * @param $param3 |
||
| 364 | * |
||
| 365 | * @return string |
||
| 366 | */ |
||
| 367 | public function getClassXoopsFormColorPicker($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 378 | |||
| 379 | /* |
||
| 380 | * @public function getClassXoopsFormSelectUser |
||
| 381 | * @param $var |
||
| 382 | * @param $param1 |
||
| 383 | * @param $param2 |
||
| 384 | * @param $param3 |
||
| 385 | * |
||
| 386 | * @return string |
||
| 387 | */ |
||
| 388 | public function getClassXoopsFormSelectUser($var, $param1, $param2, $param3 = 'false', $param4, $isParam = false, $t = "\t\t") |
||
| 400 | |||
| 401 | /* |
||
| 402 | * @public function getClassXoopsFormTextDateSelect |
||
| 403 | * @param $var |
||
| 404 | * @param $param1 |
||
| 405 | * @param $param2 |
||
| 406 | * @param $param3 |
||
| 407 | * |
||
| 408 | * @return string |
||
| 409 | */ |
||
| 410 | public function getClassXoopsFormTextDateSelect($var, $param1, $param2, $param3 = '', $param4, $isParam = false, $t = "\t\t") |
||
| 422 | |||
| 423 | /* |
||
| 424 | * @public function getClassXoopsFormEditor |
||
| 425 | * @param $var |
||
| 426 | * @param $param1 |
||
| 427 | * @param $param2 |
||
| 428 | * @param $param3 |
||
| 429 | * |
||
| 430 | * @return string |
||
| 431 | */ |
||
| 432 | public function getClassXoopsFormEditor($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 443 | |||
| 444 | /* |
||
| 445 | * @public function getClassXoopsFormCheckBox |
||
| 446 | * @param $var |
||
| 447 | * @param $param1 |
||
| 448 | * @param $param2 |
||
| 449 | * @param $param3 |
||
| 450 | * |
||
| 451 | * @return string |
||
| 452 | */ |
||
| 453 | public function getClassXoopsFormCheckBox($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 464 | |||
| 465 | /* |
||
| 466 | * @public function getClassXoopsFormRadioYN |
||
| 467 | * @param $var |
||
| 468 | * @param $param1 |
||
| 469 | * @param $param2 |
||
| 470 | * @param $param3 |
||
| 471 | * |
||
| 472 | * @return string |
||
| 473 | */ |
||
| 474 | public function getClassXoopsFormRadioYN($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 485 | |||
| 486 | /* |
||
| 487 | * @public function getClassXoopsFormSelect |
||
| 488 | * @param $var |
||
| 489 | * @param $param1 |
||
| 490 | * @param $param2 |
||
| 491 | * @param $param3 |
||
| 492 | * @param $param4 |
||
| 493 | * @param $param5 |
||
| 494 | * |
||
| 495 | * @return string |
||
| 496 | */ |
||
| 497 | public function getClassXoopsFormSelect($var, $param1, $param2, $param3, $param4 = null, $param5 = null, $isParam = false, $t = "\t\t") |
||
| 509 | |||
| 510 | /* |
||
| 511 | * @public function getClassXoopsFormTag |
||
| 512 | * @param $var |
||
| 513 | * @param $param1 |
||
| 514 | * @param $param2 |
||
| 515 | * @param $param3 |
||
| 516 | * @param $param4 |
||
| 517 | * @param $param5 |
||
| 518 | * @param $isParam |
||
| 519 | * |
||
| 520 | * @return string |
||
| 521 | */ |
||
| 522 | public function getClassXoopsFormTag($var, $param1, $param2, $param3, $param4, $param5 = 0, $isParam = false, $t = "\t\t") |
||
| 533 | |||
| 534 | /* |
||
| 535 | * @public function getClassXoopsFormButton |
||
| 536 | * @param $var |
||
| 537 | * @param $param1 |
||
| 538 | * @param $param2 |
||
| 539 | * @param $param3 |
||
| 540 | * @param $param4 |
||
| 541 | * @param $isParam |
||
| 542 | * |
||
| 543 | * @return string |
||
| 544 | */ |
||
| 545 | public function getClassXoopsFormButton($var, $param1, $param2, $param3, $param4, $isParam = false, $t = "\t\t") |
||
| 556 | |||
| 557 | /** |
||
| 558 | * @public function getClassXoopsObjectTree |
||
| 559 | * |
||
| 560 | * @param $var |
||
| 561 | * @param $tableName |
||
| 562 | * @param $fieldId |
||
| 563 | * @param $fieldParent |
||
| 564 | * |
||
| 565 | * @return string |
||
| 566 | */ |
||
| 567 | public function getClassXoopsObjectTree($var = 'mytree', $param1, $param2, $param3, $t = '') |
||
| 573 | |||
| 574 | /** |
||
| 575 | * @public function getClassXoopsMakeSelBox |
||
| 576 | * |
||
| 577 | * @param $var |
||
| 578 | * @param $anchor |
||
| 579 | * @param $param1 |
||
| 580 | * @param $param2 |
||
| 581 | * @param $param3 |
||
| 582 | * @param $param4 |
||
| 583 | * |
||
| 584 | * @return string |
||
| 585 | */ |
||
| 586 | public function getClassXoopsMakeSelBox($var, $anchor, $param1, $param2, $param3 = '--', $param4, $t = '') |
||
| 593 | |||
| 594 | /* |
||
| 595 | * @public function getClassAddOption |
||
| 596 | * @param $var |
||
| 597 | * @param $params |
||
| 598 | * |
||
| 599 | * @return string |
||
| 600 | */ |
||
| 601 | public function getClassAddOption($var, $params, $t = "\t\t") |
||
| 605 | |||
| 606 | /* |
||
| 607 | * @public function getClassAddOptionArray |
||
| 608 | * @param $var |
||
| 609 | * @param $params |
||
| 610 | * |
||
| 611 | * @return string |
||
| 612 | */ |
||
| 613 | public function getClassAddOptionArray($var, $params, $t = "\t\t") |
||
| 617 | |||
| 618 | /* |
||
| 619 | * @public function getClassAddElement |
||
| 620 | * @param $var |
||
| 621 | * @param $params |
||
| 622 | * |
||
| 623 | * @return string |
||
| 624 | */ |
||
| 625 | public function getClassAddElement($var = '', $params = '', $t = "\t\t") |
||
| 629 | |||
| 630 | /* |
||
| 631 | * @public function getClassSetDescription |
||
| 632 | * @param $var |
||
| 633 | * @param $params |
||
| 634 | * |
||
| 635 | * @return string |
||
| 636 | */ |
||
| 637 | public function getClassSetDescription($var, $params, $t = "\t\t") |
||
| 641 | |||
| 642 | /* |
||
| 643 | * @public function getClassSetExtra |
||
| 644 | * @param $var |
||
| 645 | * @param $params |
||
| 646 | * |
||
| 647 | * @return string |
||
| 648 | */ |
||
| 649 | public function getClassSetExtra($var, $params, $t = "\t\t") |
||
| 653 | } |
||
| 654 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.