Inspection of "Merge pull request #134 from mambax7/master" - txmodxoops/tdmcreate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6b7a6d...74143b )

by Gino

created 2016-09-26 18:38 UTC

Status

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -191,7 +191,7 @@
 block discarded – undo
     /**
     *  @public function render
     *  @param null
-    * @return bool|string
+    * @return null|string
     */
     public function render()
     {

Please login to merge, or discard this patch.

class/files/admin/AdminFooter.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -191,7 +191,7 @@
 block discarded – undo
     /**
     *  @public function render
     *  @param null
-    * @return bool|string
+    * @return null|string
     */
     public function render()
     {

Please login to merge, or discard this patch.

class/files/admin/AdminIndex.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -191,7 +191,7 @@
 block discarded – undo
     /**
     *  @public function render
     *  @param null
-    * @return bool|string
+    * @return null|string
     */
     public function render()
     {

Please login to merge, or discard this patch.

class/files/TDMCreateSmartyCode.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -254,7 +254,7 @@
 block discarded – undo
      * @param string $operator
      * @param string $type
      * @param string $contentIf
-     * @param mixed  $contentElse
+     * @param string  $contentElse
      * @param bool   $count
      *
      * @return string

Please login to merge, or discard this patch.

class/fields.php 1 patch

Doc Comments +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -162,9 +162,9 @@  discard block
 block discarded – undo
     /**
      * @private function getFormNewLine
      *
-     * @param $form
-     * @param $class
-     * @param $i
+     * @param TDMCreateThemeForm $form
+     * @param string $class
+     * @param integer $i
      * @param $fieldMid
      * @param $fieldTid
      * @param $fName
@@ -449,7 +449,7 @@  discard block
 block discarded – undo
      *  @private function getFooterForm
      *
      *  @param null
-     * @param $form
+     * @param TDMCreateThemeForm $form
      *
      * @return mixed
      */
@@ -603,10 +603,10 @@  discard block
 block discarded – undo
     /**
      * Get Fields Criteria.
      * @param $crFields
-     * @param $start
-     * @param $limit
-     * @param $sort
-     * @param $order
+     * @param integer $start
+     * @param integer $limit
+     * @param string $sort
+     * @param string $order
      * @return
      */
     private function getFieldsCriteria($crFields, $start, $limit, $sort, $order)

Please login to merge, or discard this patch.

class/files/admin/AdminAbout.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -191,7 +191,7 @@
 block discarded – undo
     /**
     *  @public function render
     *  @param null
-    * @return bool|string
+    * @return null|string
     */
     public function render()
     {

Please login to merge, or discard this patch.

class/files/admin/AdminPages.php 1 patch

Doc Comments +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -55,9 +55,9 @@  discard block
 block discarded – undo
 
     /**
      * @public function write
-     * @param $module
+     * @param string $module
      * @param $table
-     * @param $filename
+     * @param string $filename
      */
     public function write($module, $table, $filename)
     {
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
      * @private  function getAdminPagesList
      * @param        $moduleDirname
      * @param        $table
-     * @param        $language
+     * @param        string $language
      * @param        $fields
      * @param        $fieldId
      * @param        $fieldInForm
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
      * @param        $moduleDirname
      * @param        $tableName
      * @param        $fieldInForm
-     * @param        $language
+     * @param        string $language
      * @param string $t
      * @return string
      */
@@ -193,8 +193,8 @@  discard block
 block discarded – undo
     *  @private function getPermissionsSave
     *  @param $moduleDirname
     *  @param $fieldId
-    *  @param $ccFieldId
-    *  @param $newFieldId
+    *  @param string $ccFieldId
+    *  @param string $newFieldId
     *  @param $perm
     *
     *  @return string
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
      * @param        $tableName
      * @param        $tableCategory
      * @param        $tableSolename
-     * @param        $language
+     * @param        string $language
      * @param        $fields
      * @param        $fieldId
      * @param        $fieldMain
@@ -309,7 +309,7 @@  discard block
 block discarded – undo
      * @private  function getAdminPagesEdit
      * @param        $moduleDirname
      * @param        $table
-     * @param        $language
+     * @param        string $language
      * @param        $fieldId
      * @param        $fieldInForm
      * @param string $t
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
     /**
      * @private function getAdminPagesDelete
      * @param        $tableName
-     * @param        $language
+     * @param        string $language
      * @param        $fieldId
      * @param        $fieldMain
      * @param string $t
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
      * @public function render
      * @param null
      *
-     * @return bool|string
+     * @return null|string
      */
     public function render()
     {

Please login to merge, or discard this patch.

class/files/admin/AdminPermissions.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -74,7 +74,7 @@  discard block
 block discarded – undo
      * @private function getPermissionsHeader
      *
      * @param $module
-     * @param $language
+     * @param string $language
      *
      * @return string
      */
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
     /**
      *  @private function getPermissionsSwitch
      *  @param $moduleDirname
-     *  @param $language
+     *  @param string $language
      *
      *  @return string
      */
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
      *
      *  @param null
      *
-     *  @return bool|string
+     *  @return null|string
      */
     public function render()
     {

Please login to merge, or discard this patch.

class/files/admin/AdminXoopsCode.php 1 patch

Doc Comments +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -59,7 +59,7 @@  discard block
 block discarded – undo
      * @public function getAdminTemplateMain
      * @param        $language
      * @param        $tableName
-     * @param        $stuTableSoleName
+     * @param        string $stuTableSoleName
      * @param string $op
      * @param string $type
      *
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
 
     /**
      * @public function getAxcAddInfoBox
-     * @param        $language
+     * @param        string $language
      *
      * @param string $t
      * @return string
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
 
     /**
      * @public function getAxcAddInfoBoxLine
-     * @param        $language
+     * @param        string $language
      * @param string $label
      * @param string $var
      *
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
 
     /**
      * @public function getAxcAddConfigBoxLine
-     * @param        $language
+     * @param        string $language
      * @param string $label
      * @param string $var
      *
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
     /**
      * @private function getAxcImageFileSetVar
      * @param        $moduleDirname
-     * @param        $dirname
+     * @param        string $dirname
      * @param        $tableName
      * @param        $fieldName
      * @param bool   $formatUrl
@@ -327,8 +327,8 @@  discard block
 block discarded – undo
     /**
      * @public function getAxcFetchMedia
      *
-     * @param        $anchor
-     * @param        $var
+     * @param        string $anchor
+     * @param        string $var
      *
      * @param string $t
      * @return string
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
     /**
      * @public function getAxcSetPrefix
      *
-     * @param        $anchor
+     * @param        string $anchor
      * @param        $var
      *
      * @param string $t

Please login to merge, or discard this patch.

		@@ -254,7 +254,7 @@
		block discarded – undo
254	254	* @param string $operator
255	255	* @param string $type
256	256	* @param string $contentIf
257		- * @param mixed $contentElse
	257	+ * @param string $contentElse
258	258	* @param bool $count
259	259	*
260	260	* @return string

		@@ -162,9 +162,9 @@ discard block
		block discarded – undo
162	162	/**
163	163	* @private function getFormNewLine
164	164	*
165		- * @param $form
166		- * @param $class
167		- * @param $i
	165	+ * @param TDMCreateThemeForm $form
	166	+ * @param string $class
	167	+ * @param integer $i
168	168	* @param $fieldMid
169	169	* @param $fieldTid
170	170	* @param $fName
		@@ -449,7 +449,7 @@ discard block
		block discarded – undo
449	449	* @private function getFooterForm
450	450	*
451	451	* @param null
452		- * @param $form
	452	+ * @param TDMCreateThemeForm $form
453	453	*
454	454	* @return mixed
455	455	*/
		@@ -603,10 +603,10 @@ discard block
		block discarded – undo
603	603	/**
604	604	* Get Fields Criteria.
605	605	* @param $crFields
606		- * @param $start
607		- * @param $limit
608		- * @param $sort
609		- * @param $order
	606	+ * @param integer $start
	607	+ * @param integer $limit
	608	+ * @param string $sort
	609	+ * @param string $order
610	610	* @return
611	611	*/
612	612	private function getFieldsCriteria($crFields, $start, $limit, $sort, $order)

		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74	* @private function getPermissionsHeader
75	75	*
76	76	* @param $module
77		- * @param $language
	77	+ * @param string $language
78	78	*
79	79	* @return string
80	80	*/
		@@ -110,7 +110,7 @@ discard block
		block discarded – undo
110	110	/**
111	111	* @private function getPermissionsSwitch
112	112	* @param $moduleDirname
113		- * @param $language
	113	+ * @param string $language
114	114	*
115	115	* @return string
116	116	*/
		@@ -198,7 +198,7 @@ discard block
		block discarded – undo
198	198	*
199	199	* @param null
200	200	*
201		- * @return bool\|string
	201	+ * @return null\|string
202	202	*/
203	203	public function render()
204	204	{

		@@ -191,7 +191,7 @@
		block discarded – undo
191	191	/**
192	192	* @public function render
193	193	* @param null
194		- * @return bool\|string
	194	+ * @return null\|string
195	195	*/
196	196	public function render()
197	197	{

		@@ -55,9 +55,9 @@ discard block
		block discarded – undo
55	55
56	56	/**
57	57	* @public function write
58		- * @param $module
	58	+ * @param string $module
59	59	* @param $table
60		- * @param $filename
	60	+ * @param string $filename
61	61	*/
62	62	public function write($module, $table, $filename)
63	63	{
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105	* @private function getAdminPagesList
106	106	* @param $moduleDirname
107	107	* @param $table
108		- * @param $language
	108	+ * @param string $language
109	109	* @param $fields
110	110	* @param $fieldId
111	111	* @param $fieldInForm
		@@ -162,7 +162,7 @@ discard block
		block discarded – undo
162	162	* @param $moduleDirname
163	163	* @param $tableName
164	164	* @param $fieldInForm
165		- * @param $language
	165	+ * @param string $language
166	166	* @param string $t
167	167	* @return string
168	168	*/
		@@ -193,8 +193,8 @@ discard block
		block discarded – undo
193	193	* @private function getPermissionsSave
194	194	* @param $moduleDirname
195	195	* @param $fieldId
196		- * @param $ccFieldId
197		- * @param $newFieldId
	196	+ * @param string $ccFieldId
	197	+ * @param string $newFieldId
198	198	* @param $perm
199	199	*
200	200	* @return string
		@@ -218,7 +218,7 @@ discard block
		block discarded – undo
218	218	* @param $tableName
219	219	* @param $tableCategory
220	220	* @param $tableSolename
221		- * @param $language
	221	+ * @param string $language
222	222	* @param $fields
223	223	* @param $fieldId
224	224	* @param $fieldMain
		@@ -309,7 +309,7 @@ discard block
		block discarded – undo
309	309	* @private function getAdminPagesEdit
310	310	* @param $moduleDirname
311	311	* @param $table
312		- * @param $language
	312	+ * @param string $language
313	313	* @param $fieldId
314	314	* @param $fieldInForm
315	315	* @param string $t
		@@ -350,7 +350,7 @@ discard block
		block discarded – undo
350	350	/**
351	351	* @private function getAdminPagesDelete
352	352	* @param $tableName
353		- * @param $language
	353	+ * @param string $language
354	354	* @param $fieldId
355	355	* @param $fieldMain
356	356	* @param string $t
		@@ -367,7 +367,7 @@ discard block
		block discarded – undo
367	367	* @public function render
368	368	* @param null
369	369	*
370		- * @return bool\|string
	370	+ * @return null\|string
371	371	*/
372	372	public function render()
373	373	{

		@@ -59,7 +59,7 @@ discard block
		block discarded – undo
59	59	* @public function getAdminTemplateMain
60	60	* @param $language
61	61	* @param $tableName
62		- * @param $stuTableSoleName
	62	+ * @param string $stuTableSoleName
63	63	* @param string $op
64	64	* @param string $type
65	65	*
		@@ -94,7 +94,7 @@ discard block
		block discarded – undo
94	94
95	95	/**
96	96	* @public function getAxcAddInfoBox
97		- * @param $language
	97	+ * @param string $language
98	98	*
99	99	* @param string $t
100	100	* @return string
		@@ -106,7 +106,7 @@ discard block
		block discarded – undo
106	106
107	107	/**
108	108	* @public function getAxcAddInfoBoxLine
109		- * @param $language
	109	+ * @param string $language
110	110	* @param string $label
111	111	* @param string $var
112	112	*
		@@ -127,7 +127,7 @@ discard block
		block discarded – undo
127	127
128	128	/**
129	129	* @public function getAxcAddConfigBoxLine
130		- * @param $language
	130	+ * @param string $language
131	131	* @param string $label
132	132	* @param string $var
133	133	*
		@@ -235,7 +235,7 @@ discard block
		block discarded – undo
235	235	/**
236	236	* @private function getAxcImageFileSetVar
237	237	* @param $moduleDirname
238		- * @param $dirname
	238	+ * @param string $dirname
239	239	* @param $tableName
240	240	* @param $fieldName
241	241	* @param bool $formatUrl
		@@ -327,8 +327,8 @@ discard block
		block discarded – undo
327	327	/**
328	328	* @public function getAxcFetchMedia
329	329	*
330		- * @param $anchor
331		- * @param $var
	330	+ * @param string $anchor
	331	+ * @param string $var
332	332	*
333	333	* @param string $t
334	334	* @return string
		@@ -341,7 +341,7 @@ discard block
		block discarded – undo
341	341	/**
342	342	* @public function getAxcSetPrefix
343	343	*
344		- * @param $anchor
	344	+ * @param string $anchor
345	345	* @param $var
346	346	*
347	347	* @param string $t

txmodxoops / tdmcreate

Push — master ( 6b7a6d...74143b )

Status

Category

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +8 added lines, -8 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +10 added lines, -10 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +8 added lines, -8 removed lines patch added patch discarded remove patch