txmodxoops /
tdmcreate
Complex classes like ClassXoopsCode often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ClassXoopsCode, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 28 | class ClassXoopsCode |
||
|
|
|||
| 29 | { |
||
| 30 | /* |
||
| 31 | * @var mixed |
||
| 32 | */ |
||
| 33 | private $xc = null; |
||
| 34 | |||
| 35 | /* |
||
| 36 | * @public function constructor |
||
| 37 | * @param null |
||
| 38 | */ |
||
| 39 | /** |
||
| 40 | * |
||
| 41 | */ |
||
| 42 | public function __construct() |
||
| 46 | |||
| 47 | /* |
||
| 48 | * @static function &getInstance |
||
| 49 | * @param null |
||
| 50 | */ |
||
| 51 | /** |
||
| 52 | * @return ClassXoopsCode |
||
| 53 | */ |
||
| 54 | public static function &getInstance() |
||
| 63 | |||
| 64 | /* |
||
| 65 | * @public function getClassCriteriaCompo |
||
| 66 | * @param $var |
||
| 67 | * |
||
| 68 | * @return string |
||
| 69 | */ |
||
| 70 | public function getClassCriteriaCompo($var, $t = '') |
||
| 74 | |||
| 75 | /* |
||
| 76 | * @public function getClassCriteria |
||
| 77 | * @param $var |
||
| 78 | * @param $param1 |
||
| 79 | * @param $param2 |
||
| 80 | * @param $param3 |
||
| 81 | * |
||
| 82 | * @return string |
||
| 83 | */ |
||
| 84 | public function getClassCriteria($var, $param1, $param2 = '', $param3 = '', $isParam = false, $t = '') |
||
| 97 | |||
| 98 | /* |
||
| 99 | * @public function getClassAdd |
||
| 100 | * @param $var |
||
| 101 | * @param $param |
||
| 102 | * |
||
| 103 | * @return string |
||
| 104 | */ |
||
| 105 | public function getClassAdd($var, $param, $t = '') |
||
| 109 | |||
| 110 | /* |
||
| 111 | * @public function getClassSetStart |
||
| 112 | * @param $var |
||
| 113 | * @param $start |
||
| 114 | * |
||
| 115 | * @return string |
||
| 116 | */ |
||
| 117 | public function getClassSetStart($var, $start, $t = '') |
||
| 121 | |||
| 122 | /* |
||
| 123 | * @public function getClassSetLimit |
||
| 124 | * @param $var |
||
| 125 | * @param $limit |
||
| 126 | * |
||
| 127 | * @return string |
||
| 128 | */ |
||
| 129 | public function getClassSetLimit($var, $limit, $t = '') |
||
| 133 | |||
| 134 | /* |
||
| 135 | * @public function getClassAdd |
||
| 136 | * @param $var |
||
| 137 | * @param $sort |
||
| 138 | * |
||
| 139 | * @return string |
||
| 140 | */ |
||
| 141 | public function getClassSetSort($var, $sort, $t = '') |
||
| 145 | |||
| 146 | /* |
||
| 147 | * @public function getClassAdd |
||
| 148 | * @param $var |
||
| 149 | * @param $order |
||
| 150 | * |
||
| 151 | * @return string |
||
| 152 | */ |
||
| 153 | public function getClassSetOrder($var, $order, $t = '') |
||
| 157 | |||
| 158 | /* |
||
| 159 | * @public function getClassAdd |
||
| 160 | * @param $paramLeft |
||
| 161 | * @param $paramRight |
||
| 162 | * @param $var |
||
| 163 | * @param $t = Indentation |
||
| 164 | * |
||
| 165 | * @return string |
||
| 166 | */ |
||
| 167 | public function getClassInitVar($paramLeft = '', $paramRight = '', $var = 'this', $t = "\t\t") |
||
| 173 | |||
| 174 | /* |
||
| 175 | * @public function getXoopsSimpleForm |
||
| 176 | * @param $left |
||
| 177 | * @param $element |
||
| 178 | * @param $elementsContent |
||
| 179 | * @param $caption |
||
| 180 | * @param $var |
||
| 181 | * @param $filename |
||
| 182 | * @param $type |
||
| 183 | * |
||
| 184 | * @return string |
||
| 185 | */ |
||
| 186 | public function getXoopsSimpleForm($left = '', $element = '', $elementsContent = '', $caption = '', $var = '', $filename = '', $type = 'post', $t = '') |
||
| 197 | |||
| 198 | /* |
||
| 199 | * @public function getClassXoopsThemeForm |
||
| 200 | * @param $var |
||
| 201 | * @param $param1 |
||
| 202 | * @param $param2 |
||
| 203 | * @param $param3 |
||
| 204 | * @param $param4 |
||
| 205 | * @param $isParam |
||
| 206 | * @param $t = Indentation |
||
| 207 | * |
||
| 208 | * @return string |
||
| 209 | */ |
||
| 210 | public function getClassXoopsThemeForm($var, $param1, $param2 = null, $param3 = null, $param4 = null, $isParam = false, $t = "\t\t") |
||
| 221 | |||
| 222 | /* |
||
| 223 | * @public function XoopsFormElementTray |
||
| 224 | * @param $var |
||
| 225 | * @param $param1 |
||
| 226 | * @param $param2 |
||
| 227 | * |
||
| 228 | * @return string |
||
| 229 | */ |
||
| 230 | public function getClassXoopsFormElementTray($var, $param1, $param2 = '', $t = "\t\t") |
||
| 234 | |||
| 235 | /* |
||
| 236 | * @public function getClassXoopsFormLabel |
||
| 237 | * @param $var |
||
| 238 | * @param $param1 |
||
| 239 | * @param $param2 |
||
| 240 | * |
||
| 241 | * @return string |
||
| 242 | */ |
||
| 243 | public function getClassXoopsFormLabel($var, $param1 = '', $param2 = null, $isParam = false, $t = "\t\t") |
||
| 255 | |||
| 256 | /* |
||
| 257 | * @public function getClassXoopsFormFile |
||
| 258 | * @param $var |
||
| 259 | * @param $param1 |
||
| 260 | * @param $param2 |
||
| 261 | * @param $param3 |
||
| 262 | * |
||
| 263 | * @return string |
||
| 264 | */ |
||
| 265 | public function getClassXoopsFormFile($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 276 | |||
| 277 | /* |
||
| 278 | * @public function getClassXoopsFormHidden |
||
| 279 | * @param $var |
||
| 280 | * @param $param1 |
||
| 281 | * @param $param2 |
||
| 282 | * |
||
| 283 | * @return string |
||
| 284 | */ |
||
| 285 | public function getClassXoopsFormHidden($var, $param1, $param2, $isForm = false, $isParam = false, $t = "\t\t") |
||
| 302 | |||
| 303 | /* |
||
| 304 | * @public function getClassXoopsFormText |
||
| 305 | * @param $var |
||
| 306 | * @param $param1 |
||
| 307 | * @param $param2 |
||
| 308 | * @param $param3 |
||
| 309 | * @param $param4 |
||
| 310 | * @param $param5 |
||
| 311 | * |
||
| 312 | * @return string |
||
| 313 | */ |
||
| 314 | public function getClassXoopsFormText($var, $param1, $param2, $param3 = 75, $param4 = 255, $param5, $isParam = false, $t = "\t\t") |
||
| 325 | |||
| 326 | /* |
||
| 327 | * @public function getClassXoopsFormTextArea |
||
| 328 | * @param $var |
||
| 329 | * @param $param1 |
||
| 330 | * @param $param2 |
||
| 331 | * @param $param3 |
||
| 332 | * @param $param4 |
||
| 333 | * @param $param5 |
||
| 334 | * |
||
| 335 | * @return string |
||
| 336 | */ |
||
| 337 | public function getClassXoopsFormTextArea($var, $param1, $param2, $param3, $param4, $isParam = false, $t = "\t\t") |
||
| 349 | |||
| 350 | /* |
||
| 351 | * @public function getClassXoopsFormColorPicker |
||
| 352 | * @param $var |
||
| 353 | * @param $param1 |
||
| 354 | * @param $param2 |
||
| 355 | * @param $param3 |
||
| 356 | * |
||
| 357 | * @return string |
||
| 358 | */ |
||
| 359 | public function getClassXoopsFormColorPicker($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 370 | |||
| 371 | /* |
||
| 372 | * @public function getClassXoopsFormSelectUser |
||
| 373 | * @param $var |
||
| 374 | * @param $param1 |
||
| 375 | * @param $param2 |
||
| 376 | * @param $param3 |
||
| 377 | * |
||
| 378 | * @return string |
||
| 379 | */ |
||
| 380 | public function getClassXoopsFormSelectUser($var, $param1, $param2, $param3 = 'false', $param4, $isParam = false, $t = "\t\t") |
||
| 392 | |||
| 393 | /* |
||
| 394 | * @public function getClassXoopsFormTextDateSelect |
||
| 395 | * @param $var |
||
| 396 | * @param $param1 |
||
| 397 | * @param $param2 |
||
| 398 | * @param $param3 |
||
| 399 | * |
||
| 400 | * @return string |
||
| 401 | */ |
||
| 402 | public function getClassXoopsFormTextDateSelect($var, $param1, $param2, $param3 = '', $param4, $isParam = false, $t = "\t\t") |
||
| 414 | |||
| 415 | /* |
||
| 416 | * @public function getClassXoopsFormEditor |
||
| 417 | * @param $var |
||
| 418 | * @param $param1 |
||
| 419 | * @param $param2 |
||
| 420 | * @param $param3 |
||
| 421 | * |
||
| 422 | * @return string |
||
| 423 | */ |
||
| 424 | public function getClassXoopsFormEditor($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 435 | |||
| 436 | /* |
||
| 437 | * @public function getClassXoopsFormCheckBox |
||
| 438 | * @param $var |
||
| 439 | * @param $param1 |
||
| 440 | * @param $param2 |
||
| 441 | * @param $param3 |
||
| 442 | * |
||
| 443 | * @return string |
||
| 444 | */ |
||
| 445 | public function getClassXoopsFormCheckBox($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 456 | |||
| 457 | /* |
||
| 458 | * @public function getClassXoopsFormRadioYN |
||
| 459 | * @param $var |
||
| 460 | * @param $param1 |
||
| 461 | * @param $param2 |
||
| 462 | * @param $param3 |
||
| 463 | * |
||
| 464 | * @return string |
||
| 465 | */ |
||
| 466 | public function getClassXoopsFormRadioYN($var, $param1, $param2, $param3, $isParam = false, $t = "\t\t") |
||
| 477 | |||
| 478 | /* |
||
| 479 | * @public function getClassXoopsFormSelect |
||
| 480 | * @param $var |
||
| 481 | * @param $param1 |
||
| 482 | * @param $param2 |
||
| 483 | * @param $param3 |
||
| 484 | * @param $param4 |
||
| 485 | * @param $param5 |
||
| 486 | * |
||
| 487 | * @return string |
||
| 488 | */ |
||
| 489 | public function getClassXoopsFormSelect($var, $param1, $param2, $param3, $param4 = null, $param5 = null, $isParam = false, $t = "\t\t") |
||
| 501 | |||
| 502 | /* |
||
| 503 | * @public function getClassXoopsFormTag |
||
| 504 | * @param $var |
||
| 505 | * @param $param1 |
||
| 506 | * @param $param2 |
||
| 507 | * @param $param3 |
||
| 508 | * @param $param4 |
||
| 509 | * @param $param5 |
||
| 510 | * @param $isParam |
||
| 511 | * |
||
| 512 | * @return string |
||
| 513 | */ |
||
| 514 | public function getClassXoopsFormTag($var, $param1, $param2, $param3, $param4, $param5 = 0, $isParam = false, $t = "\t\t") |
||
| 525 | |||
| 526 | /* |
||
| 527 | * @public function getClassXoopsFormButton |
||
| 528 | * @param $var |
||
| 529 | * @param $param1 |
||
| 530 | * @param $param2 |
||
| 531 | * @param $param3 |
||
| 532 | * @param $param4 |
||
| 533 | * @param $isParam |
||
| 534 | * |
||
| 535 | * @return string |
||
| 536 | */ |
||
| 537 | public function getClassXoopsFormButton($var, $param1, $param2, $param3, $param4, $isParam = false, $t = "\t\t") |
||
| 548 | |||
| 549 | /** |
||
| 550 | * @public function getClassXoopsObjectTree |
||
| 551 | * |
||
| 552 | * @param $var |
||
| 553 | * @param $tableName |
||
| 554 | * @param $fieldId |
||
| 555 | * @param $fieldParent |
||
| 556 | * |
||
| 557 | * @return string |
||
| 558 | */ |
||
| 559 | public function getClassXoopsObjectTree($var = 'mytree', $param1, $param2, $param3, $t = '') |
||
| 565 | |||
| 566 | /** |
||
| 567 | * @public function getClassXoopsMakeSelBox |
||
| 568 | * |
||
| 569 | * @param $var |
||
| 570 | * @param $anchor |
||
| 571 | * @param $param1 |
||
| 572 | * @param $param2 |
||
| 573 | * @param $param3 |
||
| 574 | * @param $param4 |
||
| 575 | * |
||
| 576 | * @return string |
||
| 577 | */ |
||
| 578 | public function getClassXoopsMakeSelBox($var, $anchor, $param1, $param2, $param3 = '--', $param4, $t = '') |
||
| 585 | |||
| 586 | /* |
||
| 587 | * @public function getClassAddOption |
||
| 588 | * @param $var |
||
| 589 | * @param $params |
||
| 590 | * |
||
| 591 | * @return string |
||
| 592 | */ |
||
| 593 | public function getClassAddOption($var, $params, $t = "\t\t") |
||
| 597 | |||
| 598 | /* |
||
| 599 | * @public function getClassAddOptionArray |
||
| 600 | * @param $var |
||
| 601 | * @param $params |
||
| 602 | * |
||
| 603 | * @return string |
||
| 604 | */ |
||
| 605 | public function getClassAddOptionArray($var, $params, $t = "\t\t") |
||
| 609 | |||
| 610 | /* |
||
| 611 | * @public function getClassAddElement |
||
| 612 | * @param $var |
||
| 613 | * @param $params |
||
| 614 | * |
||
| 615 | * @return string |
||
| 616 | */ |
||
| 617 | public function getClassAddElement($var = '', $params = '', $t = "\t\t") |
||
| 621 | |||
| 622 | /* |
||
| 623 | * @public function getClassSetDescription |
||
| 624 | * @param $var |
||
| 625 | * @param $params |
||
| 626 | * |
||
| 627 | * @return string |
||
| 628 | */ |
||
| 629 | public function getClassSetDescription($var, $params, $t = "\t\t") |
||
| 633 | |||
| 634 | /* |
||
| 635 | * @public function getClassSetExtra |
||
| 636 | * @param $var |
||
| 637 | * @param $params |
||
| 638 | * |
||
| 639 | * @return string |
||
| 640 | */ |
||
| 641 | public function getClassSetExtra($var, $params, $t = "\t\t") |
||
| 645 | } |
||
| 646 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.