mymodule_notify_iteminfo()

Complexity

Conditions	6
Paths	8

Size

Total Lines	41
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function mymodule_notify_iteminfo($category, $item_id)
{
    global $xoopsModule, $xoopsModuleConfig, $xoopsDB;
    //
    if (empty($xoopsModule) || $xoopsModule->getVar('dirname') != 'mymodule')
    {
        $moduleHandler = xoops_getHandler('module');
        $module = $moduleHandler->getByDirname('mymodule');

The method getByDirname() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsModuleHandler or XoopsPersistableObjectHandler.

        $configHandler = xoops_getHandler('config');
        $config =& $configHandler->getConfigsByCat(0, $module->getVar('mid'));

The assignment to $config is dead and can be removed.

The method getConfigsByCat() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsPersistableObjectHandler.

    } else {
        $module = $xoopsModule;

The assignment to $module is dead and can be removed.

        $config = $xoopsModuleConfig;
    }
    //
    switch($category) {
        case 'global':
            $item['name'] = '';

$item was never initialized. Although not strictly required by PHP, it is generally a good practice to add $item = array(); before regardless.

            $item['url'] = '';
            return $item;
        break;

break is not strictly necessary here and could be removed.

        case 'category':
            // Assume we have a valid category id
            $sql = 'SELECT art_title FROM ' . $xoopsDB->prefix('mymodule_articles') . ' WHERE art_id = '. $item_id;
            $result = $xoopsDB->query($sql); // TODO: error check
            $result_array = $xoopsDB->fetchArray($result);
            $item['name'] = $result_array['art_title'];
            $item['url'] = MYMODULE_URL . '/articles.php?art_id=' . $item_id;
            return $item;
        break;
        case 'article':
            // Assume we have a valid link id
            $sql = 'SELECT art_id, art_title FROM '.$xoopsDB->prefix('mymodule_articles') . ' WHERE art_id = ' . $item_id;
            $result = $xoopsDB->query($sql); // TODO: error check
            $result_array = $xoopsDB->fetchArray($result);
            $item['name'] = $result_array['art_title'];
			$item['url'] = MYMODULE_URL . '/single.php?cid=' . $result_array['cid'] . '&art_id=' . $item_id;
			return $item;
        break;
    }
    return null;
}