b_mymodule2_testfields_show()

Complexity

Conditions	8
Paths	12

Size

Total Lines	56
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
function b_mymodule2_testfields_show($options)
{
    include_once XOOPS_ROOT_PATH.'/modules/mymodule2/class/testfields.php';
    $myts = MyTextSanitizer::getInstance();

The assignment to $myts is dead and can be removed.

    $GLOBALS['xoopsTpl']->assign('mymodule2_upload_url', MYMODULE2_UPLOAD_URL);
    $block       = array();
    $typeBlock   = $options[0];
    $limit       = $options[1];
    $lenghtTitle = $options[2];

The assignment to $lenghtTitle is dead and can be removed.

    $helper = Helper::getInstance();
    $testfieldsHandler = $helper->getHandler('testfields');
    $criteria = new \CriteriaCompo();
    array_shift($options);
    array_shift($options);
    array_shift($options);
	switch($typeBlock)
	{
		// For the block: testfields last
		case 'last':
			//$criteria->add(new \Criteria('tf_display', 1));
			$criteria->setSort('tf_created');
			$criteria->setOrder('DESC');
		break;
		// For the block: testfields new
		case 'new':
			//$criteria->add(new \Criteria('tf_display', 1));
			$criteria->add(new \Criteria('tf_created', strtotime(date(_SHORTDATESTRING)), '>='));
			$criteria->add(new \Criteria('tf_created', strtotime(date(_SHORTDATESTRING))+86400, '<='));
			$criteria->setSort('tf_created');
			$criteria->setOrder('ASC');
		break;
		// For the block: testfields hits
		case 'hits':
            $criteria->setSort('tf_hits');
            $criteria->setOrder('DESC');
        break;
		// For the block: testfields top
		case 'top':
            $criteria->setSort('tf_top');
            $criteria->setOrder('ASC');
        break;
		// For the block: testfields random
		case 'random':
			//$criteria->add(new \Criteria('tf_display', 1));
			$criteria->setSort('RAND()');
		break;
	}
    $criteria->setLimit($limit);
    $testfieldsAll = $testfieldsHandler->getAll($criteria);

The method getAll() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoUserHandler or XoopsPersistableObjectHandler.

	unset($criteria);
	if (count($testfieldsAll) > 0) {
        foreach(array_keys($testfieldsAll) as $i)
        {
        }
    }
    return $block;
}
}