txmodxoops /
tdmcreate
| Conditions | 21 |
| Paths | 2620 |
| Total Lines | 98 |
| Code Lines | 76 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 152 | public function getLanguageAdminClass($language, $tables) |
||
| 153 | { |
||
| 154 | $ret = $this->defines->getAboveHeadDefines('Admin Classes'); |
||
| 155 | |||
| 156 | foreach (array_keys($tables) as $t) { |
||
| 157 | $tableId = $tables[$t]->getVar('table_id'); |
||
| 158 | $tableMid = $tables[$t]->getVar('table_mid'); |
||
| 159 | $tableSoleName = $tables[$t]->getVar('table_solename'); |
||
| 160 | $ucfTableSoleName = ucfirst($tableSoleName); |
||
| 161 | |||
| 162 | $fields = $this->getTableFields($tableMid, $tableId); |
||
| 163 | $fieldInForm = 0; |
||
| 164 | |||
| 165 | foreach (array_keys($fields) as $f) { |
||
| 166 | if ($fieldInForm < $fields[$f]->getVar('field_inform')) { |
||
| 167 | $fieldInForm = $fields[$f]->getVar('field_inform'); |
||
| 168 | } |
||
| 169 | } |
||
| 170 | if (1 == $fieldInForm) { |
||
| 171 | $ret .= $this->defines->getAboveDefines("{$ucfTableSoleName} add/edit"); |
||
| 172 | $ret .= $this->defines->getDefine($language, "{$tableSoleName}_ADD", "Add {$ucfTableSoleName}"); |
||
| 173 | $ret .= $this->defines->getDefine($language, "{$tableSoleName}_EDIT", "Edit {$ucfTableSoleName}"); |
||
| 174 | } |
||
| 175 | $ret .= $this->defines->getAboveDefines("Elements of {$ucfTableSoleName}"); |
||
| 176 | |||
| 177 | $fieldStatus = 0; |
||
| 178 | $fieldSampleListValue = 0; |
||
| 179 | foreach (array_keys($fields) as $f) { |
||
| 180 | $fieldName = $fields[$f]->getVar('field_name'); |
||
| 181 | $fieldElement = $fields[$f]->getVar('field_element'); |
||
| 182 | |||
| 183 | $rpFieldName = $this->getRightString($fieldName); |
||
| 184 | if ($fieldElement > 16) { |
||
| 185 | $fieldElements = Tdmcreate\Helper::getInstance()->getHandler('fieldelements')->get($fieldElement); |
||
| 186 | $fieldElementName = $fieldElements->getVar('fieldelement_name'); |
||
| 187 | $fieldNameDesc = mb_substr($fieldElementName, mb_strrpos($fieldElementName, ':'), mb_strlen($fieldElementName)); |
||
| 188 | $fieldNameDesc = str_replace(': ', '', $fieldNameDesc); |
||
| 189 | } else { |
||
| 190 | $fieldNameDesc = false !== mb_strpos($rpFieldName, '_') ? str_replace('_', ' ', ucfirst($rpFieldName)) : ucfirst($rpFieldName); |
||
| 191 | } |
||
| 192 | |||
| 193 | $ret .= $this->defines->getDefine($language, $tableSoleName . '_' . $rpFieldName, $fieldNameDesc); |
||
| 194 | |||
| 195 | switch ($fieldElement) { |
||
| 196 | case 10: |
||
| 197 | $ret .= $this->defines->getDefine($language, $tableSoleName . '_' . $rpFieldName . '_UPLOADS', "{$fieldNameDesc} in frameworks images: %s"); |
||
| 198 | break; |
||
| 199 | case 12: |
||
| 200 | $ret .= $this->defines->getDefine($language, $tableSoleName . '_' . $rpFieldName . '_UPLOADS', "{$fieldNameDesc} in uploads"); |
||
| 201 | break; |
||
| 202 | case 11: |
||
| 203 | case 13: |
||
| 204 | case 14: |
||
| 205 | $ret .= $this->defines->getDefine($language, $tableSoleName . '_' . $rpFieldName . '_UPLOADS', "{$fieldNameDesc} in %s :"); |
||
| 206 | break; |
||
| 207 | case 16: |
||
| 208 | $fieldStatus++; |
||
| 209 | break; |
||
| 210 | case 20: |
||
| 211 | case 22: |
||
| 212 | $fieldSampleListValue++; |
||
| 213 | break; |
||
| 214 | } |
||
| 215 | if (16 === (int)$fieldElement) { |
||
| 216 | $fieldStatus++; |
||
| 217 | } |
||
| 218 | if (20 === (int)$fieldElement || 20 === (int)$fieldElement) { |
||
| 219 | $fieldSampleListValue++; |
||
| 220 | } |
||
| 221 | } |
||
| 222 | } |
||
| 223 | $ret .= $this->defines->getAboveDefines('General'); |
||
| 224 | $ret .= $this->defines->getDefine($language, 'FORM_UPLOAD', 'Upload file'); |
||
| 225 | $ret .= $this->defines->getDefine($language, 'FORM_UPLOAD_NEW', 'Upload new file: '); |
||
| 226 | $ret .= $this->defines->getDefine($language, 'FORM_UPLOAD_SIZE', 'Max file size: '); |
||
| 227 | $ret .= $this->defines->getDefine($language, 'FORM_UPLOAD_SIZE_MB', 'MB'); |
||
| 228 | $ret .= $this->defines->getDefine($language, 'FORM_UPLOAD_IMG_WIDTH', 'Max image width: '); |
||
| 229 | $ret .= $this->defines->getDefine($language, 'FORM_UPLOAD_IMG_HEIGHT', 'Max image height: '); |
||
| 230 | $ret .= $this->defines->getDefine($language, 'FORM_IMAGE_PATH', 'Files in %s :'); |
||
| 231 | $ret .= $this->defines->getDefine($language, 'FORM_ACTION', 'Action'); |
||
| 232 | $ret .= $this->defines->getDefine($language, 'FORM_EDIT', 'Modification'); |
||
| 233 | $ret .= $this->defines->getDefine($language, 'FORM_DELETE', 'Clear'); |
||
| 234 | |||
| 235 | if ($fieldStatus > 0) { |
||
| 236 | $ret .= $this->defines->getAboveDefines('Status'); |
||
| 237 | $ret .= $this->defines->getDefine($language, 'STATUS_NONE', 'No status'); |
||
| 238 | $ret .= $this->defines->getDefine($language, 'STATUS_OFFLINE', 'Offline'); |
||
| 239 | $ret .= $this->defines->getDefine($language, 'STATUS_SUBMITTED', 'Submitted'); |
||
| 240 | $ret .= $this->defines->getDefine($language, 'STATUS_APPROVED', 'Approved'); |
||
| 241 | } |
||
| 242 | if ($fieldSampleListValue > 0) { |
||
| 243 | $ret .= $this->defines->getAboveDefines('Sample List Values'); |
||
| 244 | $ret .= $this->defines->getDefine($language, 'LIST_1', 'Sample List Value 1'); |
||
| 245 | $ret .= $this->defines->getDefine($language, 'LIST_2', 'Sample List Value 2'); |
||
| 246 | $ret .= $this->defines->getDefine($language, 'LIST_3', 'Sample List Value 3'); |
||
| 247 | } |
||
| 248 | |||
| 249 | return $ret; |
||
| 250 | } |
||
| 325 |
Loading history...
