Issues in customers.py (master) - Issues in master - txerpa/besepa-python - Measure and Improve Code Quality continuously with Scrutinizer

Issues (51)

besepa/customers.py (4 issues)

Labels

Severity

Informational 4

from besepa import util
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from besepa.resource import Create, Delete, Find, List, Post, Resource, Update


class Customer(List, Find, Create, Delete, Update, Post):
    """Customer class wrapping the REST api/1/customers endpoint

    Usage::

        >>> customers = Customer.all()

        >>> customer = Customer.new({})
        >>> customer.create()  # return True or False
    """
    path = "api/1/customers"

    def create_bank_account(self, attributes):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        # /customers/<CUSTOMER-ID>/bank_accounts
        return self.post('bank_accounts', attributes)

    def list_bank_accounts(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        # /customers/<CUSTOMER-ID>/bank_accounts
        endpoint = util.join_url(self.path, str(self['id']), 'bank_accounts')
        response = self.api.get(endpoint)
        try:
            return Resource(response, api=self.api)
        except AttributeError:
            # To handle the case when response is JSON Array
            if isinstance(response, list):
                new_resp = [Resource(elem, api=self.api) for elem in response]
                return new_resp

    def create_debit(self, attributes):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        # /customers/invoices/<CUSTOMER-ID>/debits
        return self.post('debits', attributes)


Customer.convert_resources['bank_accounts'] = Resource
Customer.convert_resources['bank_account'] = Resource
Customer.convert_resources['mandate'] = Resource


1			from besepa import util
			0 ignored issues – show Coding Style introduced 2017-10-17 11:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			from besepa.resource import Create, Delete, Find, List, Post, Resource, Update
3
4
5			class Customer(List, Find, Create, Delete, Update, Post):
6			"""Customer class wrapping the REST api/1/customers endpoint
7
8			Usage::
9
10			>>> customers = Customer.all()
11
12			>>> customer = Customer.new({})
13			>>> customer.create() # return True or False
14			"""
15			path = "api/1/customers"
16
17			def create_bank_account(self, attributes):
			0 ignored issues – show Coding Style introduced 2017-10-17 11:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
18			# /customers/<CUSTOMER-ID>/bank_accounts
19			return self.post('bank_accounts', attributes)
20
21			def list_bank_accounts(self):
			0 ignored issues – show Coding Style introduced 2017-10-17 11:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
22			# /customers/<CUSTOMER-ID>/bank_accounts
23			endpoint = util.join_url(self.path, str(self['id']), 'bank_accounts')
24			response = self.api.get(endpoint)
25			try:
26			return Resource(response, api=self.api)
27			except AttributeError:
28			# To handle the case when response is JSON Array
29			if isinstance(response, list):
30			new_resp = [Resource(elem, api=self.api) for elem in response]
31			return new_resp
32
33			def create_debit(self, attributes):
			0 ignored issues – show Coding Style introduced 2017-10-24 08:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
34			# /customers/invoices/<CUSTOMER-ID>/debits
35			return self.post('debits', attributes)
36
37
38			Customer.convert_resources['bank_accounts'] = Resource
39			Customer.convert_resources['bank_account'] = Resource
40			Customer.convert_resources['mandate'] = Resource
41

GitHub Access Token became invalid

Issues (51)

besepa/customers.py (4 issues)

Labels

Severity

Introduced By

txerpa / besepa-python

GitHub Access Token became invalid

Issues (51)

besepa/customers.py (4 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like