Application - Code Metrics - Inspection of "Changes to make this lib stable version 0.0.1" - tworzenieweb/sql-provisioner - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bc1002...bc42f8 )

by Łukasz

created 2017-05-03 14:12 UTC

Application A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	10
lcom	1
cbo	4
dl	0
loc	76
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	boot()	11	1
A	registerCommands()	6	2
A	getConfigPath()	4	1
A	getComposerBinPath()	4	1
A	registerChecks()	6	2
A	getCommandForId()	8	2

<?php

namespace Tworzenieweb\SqlProvisioner;

use RuntimeException;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;

/**
 * @author Luke Adamczewski
 * @package Tworzenieweb\SqlProvisioner
 */
class Application extends \Symfony\Component\Console\Application
{
    /** @var ContainerBuilder */
    private $container;

    /**
     * @param string $name
     * @param string $version
     */
    public function __construct($name = 'UNKNOWN', $version = 'UNKNOWN')
    {
        parent::__construct($name, $version);
        $this->boot();
    }



    private function boot()
    {
        $this->container = new ContainerBuilder();
        $this->container->setParameter('sql_provisioner.composer_bin_path', $this->getComposerBinPath());

        $loader = new XmlFileLoader($this->container, new FileLocator($this->getConfigPath()));
        $loader->load('services.xml');
        $this->registerCommands();
        $this->registerChecks();
        $this->container->compile();
    }

    protected function registerCommands()
    {
        foreach ($this->container->findTaggedServiceIds('console.command') as $commandId => $command) {
            $this->add($this->getCommandForId($commandId));
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        }
    }



    /**
     * @return string
     */
    private function getConfigPath()
    {
        return __DIR__ . '/../config';
    }

    /**
     * @return string
     */
    private function getComposerBinPath()
    {
        return __DIR__ . '/../vendor/bin';
    }



    private function registerChecks()
    {
        foreach ($this->container->findTaggedServiceIds('provision.check') as $serviceId => $command) {
            $this->container->get('processor.candidate')->addCheck($this->container->get($serviceId));
        }
    }

    /**
     * @param string $commandId
     * @return Command
     */
    protected function getCommandForId($commandId)
    {
        if (!$this->container->has($commandId)) {
            throw new RuntimeException(sprintf('There is no command class for id %s', $commandId));
        }

        return $this->container->get($commandId);
    }
}

1			<?php
2
3			namespace Tworzenieweb\SqlProvisioner;
4
5			use RuntimeException;
6			use Symfony\Component\Config\FileLocator;
7			use Symfony\Component\Console\Command\Command;
8			use Symfony\Component\DependencyInjection\ContainerBuilder;
9			use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
10
11			/**
12			* @author Luke Adamczewski
13			* @package Tworzenieweb\SqlProvisioner
14			*/
15			class Application extends \Symfony\Component\Console\Application
16			{
17			/** @var ContainerBuilder */
18			private $container;
19
20			/**
21			* @param string $name
22			* @param string $version
23			*/
24			public function __construct($name = 'UNKNOWN', $version = 'UNKNOWN')
25			{
26			parent::__construct($name, $version);
27			$this->boot();
28			}
29
30
31
32			private function boot()
33			{
34			$this->container = new ContainerBuilder();
35			$this->container->setParameter('sql_provisioner.composer_bin_path', $this->getComposerBinPath());
36
37			$loader = new XmlFileLoader($this->container, new FileLocator($this->getConfigPath()));
38			$loader->load('services.xml');
39			$this->registerCommands();
40			$this->registerChecks();
41			$this->container->compile();
42			}
43
44			protected function registerCommands()
45			{
46			foreach ($this->container->findTaggedServiceIds('console.command') as $commandId => $command) {
47			$this->add($this->getCommandForId($commandId));
			0 ignored issues – show Bug introduced 2017-05-02 14:15 UTC by Report Bug Copy Issue Report It seems like `$this->getCommandForId($commandId)` can be `null`; however, `add()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
48			}
49			}
50
51
52
53			/**
54			* @return string
55			*/
56			private function getConfigPath()
57			{
58			return __DIR__ . '/../config';
59			}
60
61			/**
62			* @return string
63			*/
64			private function getComposerBinPath()
65			{
66			return __DIR__ . '/../vendor/bin';
67			}
68
69
70
71			private function registerChecks()
72			{
73			foreach ($this->container->findTaggedServiceIds('provision.check') as $serviceId => $command) {
74			$this->container->get('processor.candidate')->addCheck($this->container->get($serviceId));
75			}
76			}
77
78			/**
79			* @param string $commandId
80			* @return Command
81			*/
82			protected function getCommandForId($commandId)
83			{
84			if (!$this->container->has($commandId)) {
85			throw new RuntimeException(sprintf('There is no command class for id %s', $commandId));
86			}
87
88			return $this->container->get($commandId);
89			}
90			}

tworzenieweb / sql-provisioner

Push — master ( bc1002...bc42f8 )

Application A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like