woocommerce-template.php ➔ is_discontinued() - Code Metrics - Inspection of "prefix functions with dp_ per .org plugin review t..." - twoelevenjay/woocommerce-discontinued-products - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ba5b71...784334 )

by Leon

created 2016-07-10 06:59 UTC

woocommerce-template.php ➔ is_discontinued() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	5
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	7
rs	9.4285

<?php
/**
 * WooCommerce Discontinued Products Template Functions
 *
 * @package woocommerce
 * @since 1.0.0
 */

if ( ! function_exists( 'dp_is_discontinued' ) ) {

	/**
	 * Is discontiued.
	 * Check if product is discontinued.
	 *
	 * @since 1.0.0
	 * @param int $product_id Optional. ID of the product to check.

	 */
	function dp_is_discontinued( $product_id = null ) {


		global $post;
function myFunction($a, $b) {
    // Do something
}
		$product_id = $product_id !== null ? $product_id : $post->ID;
$a = "a";
$ab = "ab";
$abc = "abc";
		$is_discontinued = get_post_meta( $product_id, '_is_discontinued', true );
		return $is_discontinued === 'yes';
	}
}

if ( ! function_exists( 'dp_alternative_products' ) ) {

	/**
	 * Alternative Products.
	 * Output buttons to alternative products.
	 *
	 * @since 1.0.0
	 */
	function dp_alternative_products() {

		global $post;
function myFunction($a, $b) {
    // Do something
}
		$alt_products = get_post_meta( $post->ID, '_alt_products', true );
		$alt_products = is_array( $alt_products ) ? $alt_products : array();
		$text = _( 'This product has been discontinued.' );
$a = "a";
$ab = "ab";
$abc = "abc";
		$notice = empty( $alt_products ) ? $text : $text . ' ' . _( 'You may be interested in:' );
$a = "a";
$ab = "ab";
$abc = "abc";
		?>
		<h4><?php echo esc_html( $notice ); ?></h4>
		<?php
		foreach ( $alt_products as $alt_product ) {
			?>
			<a href="<?php echo esc_url( get_permalink( $alt_product ) ); ?>" class="button"><?php echo get_the_title( $alt_product ); ?></a>
			<?php
		}
	}
}


Push — master ( ba5b71...784334 )

woocommerce-template.php ➔ is_discontinued() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			* WooCommerce Discontinued Products Template Functions
4			*
5			* @package woocommerce
6			* @since 1.0.0
7			*/
8
9			if ( ! function_exists( 'dp_is_discontinued' ) ) {
10
11			/**
12			* Is discontiued.
13			* Check if product is discontinued.
14			*
15			* @since 1.0.0
16			* @param int $product_id Optional. ID of the product to check.
			0 ignored issues – show Documentation introduced 2016-07-08 20:42 UTC by Report Bug Copy Issue Report Should the type for parameter `$product_id` not be `integer\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
17			*/
18			function dp_is_discontinued( $product_id = null ) {
			0 ignored issues – show Coding Style introduced 2016-07-10 07:01 UTC by Report Bug Copy Issue Report `function dp_is_discontinued()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
19
20			global $post;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-08 20:42 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
21			$product_id = $product_id !== null ? $product_id : $post->ID;
			0 ignored issues – show Coding Style introduced 2016-07-08 20:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22			$is_discontinued = get_post_meta( $product_id, '_is_discontinued', true );
23			return $is_discontinued === 'yes';
24			}
25			}
26
27			if ( ! function_exists( 'dp_alternative_products' ) ) {
28
29			/**
30			* Alternative Products.
31			* Output buttons to alternative products.
32			*
33			* @since 1.0.0
34			*/
35			function dp_alternative_products() {
36
37			global $post;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-08 20:42 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
38			$alt_products = get_post_meta( $post->ID, '_alt_products', true );
39			$alt_products = is_array( $alt_products ) ? $alt_products : array();
40			$text = _( 'This product has been discontinued.' );
			0 ignored issues – show Coding Style introduced 2016-07-08 21:52 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
41			$notice = empty( $alt_products ) ? $text : $text . ' ' . _( 'You may be interested in:' );
			0 ignored issues – show Coding Style introduced 2016-07-08 21:52 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
42			?>
43			<h4><?php echo esc_html( $notice ); ?></h4>
44			<?php
45			foreach ( $alt_products as $alt_product ) {
46			?>
47			<a href="<?php echo esc_url( get_permalink( $alt_product ) ); ?>" class="button"><?php echo get_the_title( $alt_product ); ?></a>
48			<?php
49			}
50			}
51			}
52

twoelevenjay / woocommerce-discontinued-products

Push — master ( ba5b71...784334 )

woocommerce-template.php ➔ is_discontinued() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like