CMB2_Meta_Box - Code Metrics - Inspection of "reducing NPath complexity" - twoelevenjay/CMB2-Admin-Extension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ff21ec...826c43 )

by Leon

created 2016-07-13 07:50 UTC

CMB2_Meta_Box B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	336
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes	10
Bugs	4	Features	0

Metric	Value
c	10
b	4
f	0
dl	0
loc	336
rs	8.3673
wmc	45
lcom	2
cbo	0

12 Methods

Rating	Name	Size	Complexity
A	__construct()	6	1
A	get_instance()	8	2
A	is_cmb2_allowed()	14	4
A	hide_cmb2_plugins()	13	4
A	enqueue_scripts()	10	2
B	is_repeatable()	27	1
A	has_options()	16	1
A	add_option_arg()	12	3
B	add_strpos_arg()	11	5
A	add_arg()	12	3
A	should_add_arg()	4	3
F	init_user_defined_meta_boxes_and_fields()	86	16

How to fix Complexity

<?php
/**
 * CMB2 Meta Box
 *
 * @since  0.1.0
 *
 * @category  WordPress_Plugin
 * @package   CMB2 Admin Extension
 * @author    twoelevenjay
 * @license   GPL-2.0+
 */

if ( ! class_exists( 'CMB2_Meta_Box' ) ) {

	/**
	 * Class CMB2_Meta_Box.
	 */
	class CMB2_Meta_Box {

		/**
		 * Field prefix.
		 *
		 * @var string
		 */
		private $prefix = '_cmb2_';

		/**
		 * Current field array.
		 * Store the current field while adding user defined fields
		 *
		 * @var array
		 */
		private $field = array();

		/**
		 * Current field arguments array.
		 * Store the current field arguments while adding user defined fields
		 *
		 * @var array
		 */
		private $field_args = array();

		/**
		 * Instance of this class.
		 *
		 * @var object
		 */
		protected static $instance;

		/**
		 * Initiate CMB2 Admin Extension object.
		 *
		 * @since 0.0.1
		 */
		public function __construct() {

			add_action( 'pre_current_active_plugins', array( $this, 'hide_cmb2_plugins' ) );
			add_action( 'admin_enqueue_scripts', array( $this, 'enqueue_scripts' ) );
			add_action( 'cmb2_init', array( $this, 'init_user_defined_meta_boxes_and_fields' ) );
		}

		/**
		 * Return an instance of this class.
		 *
		 * @return object A single instance of this class.
		 */
		public static function get_instance() {
			// If the single instance hasn't been set, set it now.
			if ( self::$instance === null ) {
				self::$instance = new self;
			}

			return self::$instance;
		}


		/**
		 * Determine if current user has permission to CMB2 view plugins.
		 *
		 * @since  0.0.1
		 */
		public function is_cmb2_allowed() {

			$cmb2_settings = get_option( '_cmb2_settings' );

			if ( empty( $cmb2_settings ) ) {
				// No settings saved.
				return true;
			}

			$current_user  = wp_get_current_user();
			$allowed_users = isset( $cmb2_settings['_cmb2_user_multicheckbox'] ) ? $cmb2_settings['_cmb2_user_multicheckbox'] : array();

			return empty( $allowed_users ) || in_array( $current_user->ID, $allowed_users, true );
		}

		/**
		 * Only show CMB2 plugins to users defined in settings.
		 *
		 * @since  0.0.1
		 */
		public function hide_cmb2_plugins() {

			global $wp_list_table;
function myFunction($a, $b) {
    // Do something
}
			if ( ! $this->is_cmb2_allowed() ) {
				$to_hide = array( CMB2AE_CMB2_PLUGIN_FILE, 'cmb2-admin-extension/cmb2-admin-extension.php' );
				$plugins = $wp_list_table->items;
				foreach ( array_keys( $plugins ) as $key ) {
					if ( in_array( $key, $to_hide, true ) ) {
						unset( $wp_list_table->items[ $key ] );
					}
				}
			}
		}

		/**
		 * Enqueue CMB2 Admin Extension scripts and styles.
		 *
		 * @since  0.0.8
		 */
		public function enqueue_scripts() {

			$screen = get_current_screen();
			if ( $screen->post_type === 'meta_box' ) {


				wp_register_style( 'cmb2_admin_styles', CMB2AE_URI . '/css/meta-box-fields.css', false, '0.0.8' );
				wp_enqueue_style( 'cmb2_admin_styles' );
				wp_enqueue_script( 'cmb2_admin_scripts', CMB2AE_URI . '/js/meta-box-fields.js', true, array( 'jquery' ), '0.0.8' );
			}
		}

		/**
		 * Check if the field type is repeatable.
		 *
		 * @since  0.0.6
		 * @param  string $field_type A CMB2 field type.
		 * @return bollean.

		 */
		public function is_repeatable( $field_type ) {

			$repeatable_fields = array(
				'text',
				'text_small',
				'text_medium',
				'text_email',
				'text_url',
				'text_money',
				'textarea',
				'textarea_small',
				'textarea_code',
				'text_date',
				'text_time',
				'select_timezone',
				'text_date_timestamp',
				'text_datetime_timestamp',
				'text_datetime_timestamp_timezone',
				'colorpicker',
				'select',
				'multicheck',
				'multicheck_inline',
				'file',
				'file_list',
			);
			return in_array( $field_type, $repeatable_fields, true );
		}

		/**
		 * Check if field types should have the options argument.
		 *
		 * @since  0.0.6
		 * @param  string $field_type A CMB2 field type.
		 * @return bollean.

		 */
		public function has_options( $field_type ) {

			$options_fields = array(
				'radio',
				'radio_inline',
				'taxonomy_radio',
				'taxonomy_radio_inline',
				'select',
				'taxonomy_select',
				'multicheck',
				'multicheck_inline',
				'taxonomy_multicheck',
				'taxonomy_multicheck_inline',
			);
			return in_array( $field_type, $options_fields, true );
		}

		/**
		 * Conditional to check if the field argument should be added..
		 *
		 * @since 1.1.4
		 * @param string $options string of options for fields liek select.
		 */
		public function add_option_arg( $options ) {

			$options = explode( PHP_EOL, $options );

			foreach ( $options as $option ) {
				$opt_arr = explode( ',', $option );
				if ( ! isset( $opt_arr[1] ) ) {
					continue;
				}
				$field_options[ $opt_arr[0] ] = $opt_arr[1];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			}
			$this->field_args['options'] = $field_options;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}

		/**
		 * Conditional to check if the field argument should be added..
		 *
		 * @since 1.1.4
		 * @param array $arg_value A CMB2 field type.
		 */
		public function add_strpos_arg( $arg_value ) {

			if ( strpos( $this->field['_cmb2_field_type_select'], $arg_value[0] ) !== false && isset( $this->field[ $arg_value[2] ] ) && $this->field[ $arg_value[2] ] !== '' ) {


				if ( is_array( $arg_value[1] ) ) {
					$this->field_args[ $arg_value[1][0] ][ $arg_value[1][1] ] = $this->field[ $arg_value[2] ];
					return;
				}
				$this->field_args[ $arg_value[1] ] = $this->field[ $arg_value[2] ];
			}
		}

		/**
		 * Conditional to check if the field argument should be added..
		 *
		 * @since 1.1.4
		 * @param string       $arg   Field definition.
		 * @param string|array $value A CMB2 field type.
		 */
		public function add_arg( $arg, $value ) {

			if ( $this->should_add_arg( $this->field, $arg, $value ) ) {


				if ( is_array( $value ) ) {

					$this->field_args[ $arg ][ $value[0] ] = $this->field[ $value[1] ];
					return;
				}
				$this->field_args[ $arg ] = $this->field[ $value ];
			}
		}

		/**
		 * Conditional to check if the field argument should be added..
		 *
		 * @since  1.1.4
		 * @param  array  $field      Field definition.
		 * @param  string $field_type A CMB2 field type.
		 * @param  string $field_key  $field key to check.
		 * @return bollean.

		 */
		static function should_add_arg( $field, $field_type, $field_key ) {


			return ( $field['_cmb2_field_type_select'] === $field_type && ( ! empty( $field[ $field_key ] ) && $field[ $field_key ] !== '' ) );
		}

		/**
		 * Loop through user defined meta_box and creates the custom meta boxes and fields.
		 *
		 * @since 0.0.1
		 */
		public function init_user_defined_meta_boxes_and_fields() {

			$args = array(
				'post_type'        => 'meta_box',
				'post_status'      => 'publish',
				'posts_per_page'   => -1,

				'suppress_filters' => false,
			);

			$prefix = $this->prefix;

			$user_meta_boxes = get_posts( $args );

			foreach ( $user_meta_boxes as $user_meta_box ) {

				$metabox_id = $user_meta_box->ID;

				$title          = get_the_title( $metabox_id );
				$id             = str_replace( '-', '_', $user_meta_box->post_name );
				$post_type      = cmbf( $metabox_id, $prefix . 'post_type_multicheckbox' );
				$context        = cmbf( $metabox_id, $prefix . 'context_radio' );
				$priority       = cmbf( $metabox_id, $prefix . 'priority_radio' );
				$show_names     = cmbf( $metabox_id, $prefix . 'show_names' ) === 'on' ? true : false;
				$disable_styles = cmbf( $metabox_id, $prefix . 'disable_styles' ) === 'on' ? true : false;
				$closed         = cmbf( $metabox_id, $prefix . 'closed' ) === 'on' ? true : false;
				$fields         = cmbf( $metabox_id, $prefix . 'custom_field' );

				/**
				 * Initiate the metabox.
				 */
				${ 'cmb_' . $id } = new_cmb2_box( array(
					'id'           => $id,
					'title'        => $title,
					'object_types' => $post_type, // Post type.
					'context'      => $context,
					'priority'     => $priority,
					'show_names'   => $show_names,
					'cmb_styles'   => $disable_styles,
					'closed'       => $closed,
				) );

				foreach ( $fields as $field ) {

					$this->field = $field;
$a = "a";
$ab = "ab";
$abc = "abc";
					$field_id    = '_' . strtolower( str_replace( ' ', '_', $field['_cmb2_name_text'] ) );
$a = "a";
$ab = "ab";
$abc = "abc";
					$this->field_args  = array(
$a = "a";
$ab = "ab";
$abc = "abc";
						'name' => $field['_cmb2_name_text'],
						'desc' => $field['_cmb2_decription_textarea'],
						'id'   => $field_id,
						'type' => $field['_cmb2_field_type_select'],
					);

					$options = isset( $field['_cmb2_options_textarea'] ) ? $field['_cmb2_options_textarea'] : false;
					if ( $options ) {
						$this->add_option_arg( $options );
					}
					$should_add_strpos = array(
						array( 'tax', 'taxonomy', '_cmb2_tax_options_radio_inline' ),
						array( 'tax', array( 'options', 'no_terms_text' ), '_cmb2_no_terms_text' ),
						array( 'multicheck', 'select_all_button', '_cmb2_select_all_checkbox' ),
					);
					foreach ( $should_add_strpos as $arg_value ) {
						$this->add_strpos_arg( $arg_value );
					}
					if ( isset( $field['_cmb2_repeatable_checkbox'] ) && $field['_cmb2_repeatable_checkbox'] === 'on' && $this->is_repeatable( $field['_cmb2_field_type_select'] ) ) {

						$field_args['repeatable'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
					}
					if ( isset( $field['_cmb2_none_checkbox'] ) && $field['_cmb2_none_checkbox'] === 'on' && $this->has_options( $field['_cmb2_field_type_select'] ) ) {

						$field_args['show_option_none'] = true;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
					}
					$should_add = array(
						'protocols' => '_cmb2_protocols_checkbox',
						'before_field' => '_cmb2_currency_text',
						'time_format' => '_cmb2_time_format',
						'date_format' => '_cmb2_date_format',
						'timezone_meta_key' => '_cmb2_time_zone_key_select',
						'options' => array( 'add_upload_file_text', '_cmb2_add_upload_file_text' ),
					);
					foreach ( $should_add as $arg => $value ) {
						$this->add_arg( $arg, $value );
					}
					${ 'cmb_' . $id }->add_field( $this->field_args );

				}
			}
		}
	}
}

if ( ! function_exists( 'cmb2ae_metabox' ) ) {
	/**
	 * Main instance of CMB2_Meta_Box.
	 *
	 * @since  0.1.0
	 * @return object Main instance of the CMB2_Meta_Box class.
	 */
	function cmb2ae_metabox() {
		return CMB2_Meta_Box::get_instance();
	}
}


Push — master ( ff21ec...826c43 )

CMB2_Meta_Box B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

How to fix Complexity

Complex Class

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

1			<?php
2			/**
3			* CMB2 Meta Box
4			*
5			* @since 0.1.0
6			*
7			* @category WordPress_Plugin
8			* @package CMB2 Admin Extension
9			* @author twoelevenjay
10			* @license GPL-2.0+
11			*/
12
13			if ( ! class_exists( 'CMB2_Meta_Box' ) ) {
14
15			/**
16			* Class CMB2_Meta_Box.
17			*/
18			class CMB2_Meta_Box {
19
20			/**
21			* Field prefix.
22			*
23			* @var string
24			*/
25			private $prefix = '_cmb2_';
26
27			/**
28			* Current field array.
29			* Store the current field while adding user defined fields
30			*
31			* @var array
32			*/
33			private $field = array();
34
35			/**
36			* Current field arguments array.
37			* Store the current field arguments while adding user defined fields
38			*
39			* @var array
40			*/

twoelevenjay / CMB2-Admin-Extension

Push — master ( ff21ec...826c43 )

CMB2_Meta_Box B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

How to fix Complexity

Complex Class

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like