Subreality\Dilmun\Enki\MySql

Complexity

Total Complexity

4

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	connect()	0	16	2
A	disconnect()	0	12	2

<?php

namespace Subreality\Dilmun\Enki;

use Subreality\Dilmun\LoggedClassTrait;

/**
 * Class MySql
 * @package Subreality\Dilmun\Enki
 */
class MySql implements EnkiInterface
{
    use LoggedClassTrait;

    private $pdo;

    /**
     * @param $host
     * @param $user
     * @param $pass
     * @param $name
     *
     * @return mixed

Consider making the return type a bit more specific; maybe use boolean.

     */
    public function connect($host, $user, $pass, $name)
    {
        try {
            $this->pdo = new \PDO("mysql:{$host};dbname={$name}", $user, $pass);

            $connected = true;
        } catch (\PDOException $pdo_e) {
            $context["exception"] = $pdo_e;

$context was never initialized. Although not strictly required by PHP, it is generally a good practice to add $context = array(); before regardless.

            $this->updateLog("error", "MySQL connection failed with the following message: {message}", $context);
            
            $connected = false;
        }

        return $connected;
    }

    /**
     * @return bool
     */
    public function disconnect()
    {
        if ($this->pdo instanceof \PDO) {
            $this->pdo = null;

            $disconnected = true;
        } else {
            $disconnected = false;
        }

        return $disconnected;
    }
}