Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | View Code Duplication | class UserInfo extends AbstractUriPart |
|
9 | { |
||
10 | protected static $unencoded_characters = array(":"); |
||
11 | protected static $compositions = array( |
||
12 | "unreserved_characters", |
||
13 | "sub_delims_characters", |
||
14 | ); |
||
15 | |||
16 | protected static $part_pattern; |
||
17 | |||
18 | /** |
||
19 | * UserInfo constructor. Accepts a string representing a URI user info component. Construction will throw an |
||
20 | * exception if the user info is not a string. |
||
21 | * |
||
22 | * Construction accepts strings that have been percent-encoded as well as strings that have not been percent-encoded |
||
23 | * and will encode invalid characters. |
||
24 | * |
||
25 | * Construction with a string that includes both encoded and decoded characters will be assumed to be an encoded |
||
26 | * string, resulting in double-encoding. |
||
27 | * |
||
28 | * userinfo = *( unreserved / pct-encoded / sub-delims / ":" ) |
||
29 | * unreserved = ALPHA / DIGIT / "-" / "." / "_" / "~" |
||
30 | * pct-encoded = "%" HEXDIG HEXDIG |
||
31 | * sub-delims = "!" / "$" / "&" / "'" / "(" / ")" / "*" / "+" / "," / ";" / "=" |
||
32 | * |
||
33 | * @see https://tools.ietf.org/html/rfc3986#appendix-A |
||
34 | * |
||
35 | * @throws \InvalidArgumentException |
||
36 | * |
||
37 | * @param string $user_info A string representing a URI fragment |
||
38 | */ |
||
39 | 115 | public function __construct($user_info) |
|
43 | |||
44 | /** |
||
45 | * Returns a string representation of the user info formatted so that it can be compiled into a complete URI string |
||
46 | * per the Uri object's string specification. |
||
47 | * |
||
48 | * If user info is empty, toUriString returns an empty string; if user info is not empty, toUriString returns |
||
49 | * the user info suffixed with an at(@). |
||
50 | * |
||
51 | * @see Uri::__toString |
||
52 | * |
||
53 | * @return string A string representation of the user info formatted for a complete URI string |
||
54 | */ |
||
55 | 85 | public function toUriString() |
|
65 | } |
||
66 |