Entity::invokeTest() - Code Metrics - Inspection of "Update dependencies" - tvdijen/simplesamlphp-module-monitor - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — monitor-2.5.x (8b654c)

by Tim

created 2018-10-17 21:15 UTC

Entity::invokeTest() B

↳ Parent: Entity

Complexity

Conditions	6
Paths	6

Size

Total Lines	59
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	38
nc	6
nop	0
dl	0
loc	59
rs	8.6897
c	0
b	0
f	0

How to fix Long Method

<?php

namespace SimpleSAML\Modules\Monitor\TestSuite\Metadata;

use \SimpleSAML\Modules\Monitor\State as State;
use \SimpleSAML\Modules\Monitor\TestConfiguration as TestConfiguration;
use \SimpleSAML\Modules\Monitor\TestCase as TestCase;
use \SimpleSAML\Modules\Monitor\TestData as TestData;
use \SimpleSAML\Modules\Monitor\TestResult as TestResult;

final class Entity extends \SimpleSAML\Modules\Monitor\TestSuiteFactory
{
    /**
     * @var array
     */
    private $entityMetadata;

    /**
     * @var string
     */
    private $entityId;

    /**
     * @param integer|null;
     */
    private $certExpirationWarning = null;

    /**
     * @param TestConfiguration $configuration
     * @param TestData $testData
     */
    public function __construct($configuration, $testData)
    {
        $moduleConfig = $configuration->getModuleConfig();
        $entityMetadata = $testData->getInputItem('entityMetadata');
        $entityId = $testData->getInputItem('entityId');

        assert(is_array($entityMetadata));
        assert(is_string($entityId));

        $this->certExpirationWarning = $moduleConfig->getValue('certExpirationWarning', 28);
        $this->entityMetadata = $entityMetadata;
        $this->entityId = $entityId;

        $this->setCategory('Metadata entity');
        parent::__construct($configuration);
    }

    /**
     * @return void
     */
    public function invokeTest()
    {
        $input = [
            'entityId' => $this->entityId,
            'entityMetadata' => $this->entityMetadata,
        ];
        $testData = new TestData($input);

        $expTest = new TestCase\Metadata\Expiration($testData);
        $expTestResult = $expTest->getTestResult();
        $expTestResult->setSubject($this->entityId);
        $this->addTestResult($expTestResult);

        if (array_key_exists('keys', $this->entityMetadata)) {
            $keys = $this->entityMetadata['keys'];
            foreach ($keys as $key) {
                $input = array(
                    'category' => $this->getType($key),
                    'certData' => "-----BEGIN CERTIFICATE-----\n" .chunk_split($key['X509Certificate'], 64)."-----END CERTIFICATE-----\n",
                    'certExpirationWarning' => $this->certExpirationWarning,
                );
                $testData = new TestData($input);

                $certTest = new TestCase\Cert\Data($testData);
                $certTestResult = $certTest->getTestResult();

                $this->addTestResult($certTestResult);
            }
        } else {
            // saml20-idp-hosted
            $files = [];
            if (array_key_exists('certificate', $this->entityMetadata)) {
                $files[] = $this->entityMetadata['certificate'];
            }
            if (array_key_exists('new_certificate', $this->entityMetadata)) {
                $files[] = $this->entityMetadata['new_certificate'];
            }

            foreach ($files as $file) {
                $input = [
                    'category' => $this->getType(['signing' => true]),
                    'certFile' => \SimpleSAML\Utils\Config::getCertPath($file),
                    'certExpirationWarning' => $this->certExpirationWarning,
                ];

                $testData = new TestData($input);

                $certTest = new TestCase\Cert\File($testData);
                $certTestResult = $certTest->getTestResult();

                $this->addTestResult($certTestResult);
            }
        }

        $state = $this->calculateState();

        $testResult = new TestResult('Metadata endpoint');
        $testResult->setState($state);
        $this->setTestResult($testResult);
    }

    /**
     * @param array $key
     *
     * @return string
     */
    public function getType($key)
    {
        if ($key['encryption'] === true && $key['signing'] === false) {
            $category = 'Encryption certificate';
        } elseif ($key['encryption'] === false && $key['signing'] === true) {
            $category = 'Signing certificate';
        } else {
            $category = 'Unknown type';
        }
        return $category;
    }
}


1			<?php
2
3			namespace SimpleSAML\Modules\Monitor\TestSuite\Metadata;
4
5			use \SimpleSAML\Modules\Monitor\State as State;
6			use \SimpleSAML\Modules\Monitor\TestConfiguration as TestConfiguration;
7			use \SimpleSAML\Modules\Monitor\TestCase as TestCase;
8			use \SimpleSAML\Modules\Monitor\TestData as TestData;
9			use \SimpleSAML\Modules\Monitor\TestResult as TestResult;
10
11			final class Entity extends \SimpleSAML\Modules\Monitor\TestSuiteFactory
12			{
13			/**
14			* @var array
15			*/
16			private $entityMetadata;
17
18			/**
19			* @var string
20			*/
21			private $entityId;
22
23			/**
24			* @param integer\|null;
25			*/
26			private $certExpirationWarning = null;
27
28			/**
29			* @param TestConfiguration $configuration
30			* @param TestData $testData
31			*/
32			public function __construct($configuration, $testData)
33			{
34			$moduleConfig = $configuration->getModuleConfig();
35			$entityMetadata = $testData->getInputItem('entityMetadata');
36			$entityId = $testData->getInputItem('entityId');
37
38			assert(is_array($entityMetadata));
39			assert(is_string($entityId));
40
41			$this->certExpirationWarning = $moduleConfig->getValue('certExpirationWarning', 28);
42			$this->entityMetadata = $entityMetadata;
43			$this->entityId = $entityId;
44
45			$this->setCategory('Metadata entity');
46			parent::__construct($configuration);
47			}
48
49			/**
50			* @return void
51			*/
52			public function invokeTest()
53			{
54			$input = [
55			'entityId' => $this->entityId,
56			'entityMetadata' => $this->entityMetadata,
57			];
58			$testData = new TestData($input);
59
60			$expTest = new TestCase\Metadata\Expiration($testData);
61			$expTestResult = $expTest->getTestResult();
62			$expTestResult->setSubject($this->entityId);
63			$this->addTestResult($expTestResult);
64
65			if (array_key_exists('keys', $this->entityMetadata)) {
66			$keys = $this->entityMetadata['keys'];
67			foreach ($keys as $key) {
68			$input = array(
69			'category' => $this->getType($key),
70			'certData' => "-----BEGIN CERTIFICATE-----\n" .chunk_split($key['X509Certificate'], 64)."-----END CERTIFICATE-----\n",
71			'certExpirationWarning' => $this->certExpirationWarning,
72			);
73			$testData = new TestData($input);
74
75			$certTest = new TestCase\Cert\Data($testData);
76			$certTestResult = $certTest->getTestResult();
77
78			$this->addTestResult($certTestResult);
79			}
80			} else {
81			// saml20-idp-hosted
82			$files = [];
83			if (array_key_exists('certificate', $this->entityMetadata)) {
84			$files[] = $this->entityMetadata['certificate'];
85			}
86			if (array_key_exists('new_certificate', $this->entityMetadata)) {
87			$files[] = $this->entityMetadata['new_certificate'];
88			}
89
90			foreach ($files as $file) {
91			$input = [
92			'category' => $this->getType(['signing' => true]),
93			'certFile' => \SimpleSAML\Utils\Config::getCertPath($file),
94			'certExpirationWarning' => $this->certExpirationWarning,
95			];
96
97			$testData = new TestData($input);
98
99			$certTest = new TestCase\Cert\File($testData);
100			$certTestResult = $certTest->getTestResult();
101
102			$this->addTestResult($certTestResult);
103			}
104			}
105
106			$state = $this->calculateState();
107
108			$testResult = new TestResult('Metadata endpoint');
109			$testResult->setState($state);
110			$this->setTestResult($testResult);
111			}
112
113			/**
114			* @param array $key
115			*
116			* @return string
117			*/
118			public function getType($key)
119			{
120			if ($key['encryption'] === true && $key['signing'] === false) {
121			$category = 'Encryption certificate';
122			} elseif ($key['encryption'] === false && $key['signing'] === true) {
123			$category = 'Signing certificate';
124			} else {
125			$category = 'Unknown type';
126			}
127			return $category;
128			}
129			}
130

tvdijen / simplesamlphp-module-monitor

Branch — monitor-2.5.x (8b654c)

Entity::invokeTest() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like