Server

Complexity

Total Complexity

3

Size/Duplication

Total Lines	26
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	11	11	3

<?php

namespace \SimpleSAML\Module\monitor\DependencyInjection;

class Server

This class seems to be duplicated in your project.

The property $SERVER_NAME is not named in camelCase.

The property $SERVER_PORT is not named in camelCase.

The property $HTTP_AUTHORIZATION is not named in camelCase.

The property $SERVER_PROTOCOL is not named in camelCase.

{
    // The canonical list of acceptable server parameters
    /**
     * @var mixed
     */
    public $SERVER_NAME, $SERVER_PORT, $HTTP_AUTHORIZATION, $SERVER_PROTOCOL;

$SERVER_NAME does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

It is generally advisable to only define one property per statement.

    /**
     * @param array $serverVars
     *
     * @return Request
     */

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

    public function __construct($serverVars)
    {
        $objectVars = get_object_vars($this);
        foreach ($serverVars as $property => $value)
        {
            if (array_key_exists($property, $objectVars)) {
                $this->$property = $value;
            }
        }
        return $this;

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }
}