SimpleSAML\Module\monitor\TestCase\AuthSource\Ldap\Bind

Complexity

Total Complexity

5

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	9	1
B	invokeTest()	0	22	4

<?php

namespace SimpleSAML\Module\monitor\TestCase\AuthSource\Ldap;

use \SimpleSAML\Module\monitor\State as State;
use \SimpleSAML\Module\monitor\TestData as TestData;
use \SimpleSAML\Module\monitor\TestResult as TestResult;

final class Bind extends \SimpleSAML\Module\monitor\TestCaseFactory
{
    /*
     * @var \SimpleSAML_Auth_LDAP|null
     */
    private $connection = null;

    /*
     * @var string|null
     */
    private $username = null;

    /*
     * @var string|null
     */

    private $password = null;


    /*
     * @param TestData $testData
     *
     * @return void
     */
    protected function initialize($testData)
    {
        $this->connection = $testData->getInput('connection');

It seems like $testData->getInput('connection') can also be of type array. However, the property $connection is declared as type null|SimpleSAML_Auth_LDAP. Maybe add an additional type check?

        $authSourceData = $testData->getInput('authSourceData');

        $this->username = $authSourceData['search.username'];
        $this->password = $authSourceData['search.password'];

        parent::initialize($testData);
    }

   
    /*
     * @return void
     */
    public function invokeTest()
    {
        try {
            $bind = $this->connection->bind($this->username, $this->password);

The method bind() does not exist on null.

        } catch (\Exception $error) {
            // Fallthru
        }

        $testResult = new TestResult('LDAP Bind', $this->username);
        if (isSet($error)) {
            $msg = str_replace('Library - LDAP bind(): ', '', $error->getMessage());
            $testResult->setState(State::FATAL);
        } elseif ($bind === true) {
            $msg = 'Bind succesful';
            $testResult->setState(State::OK);
        } else {
            $msg = ldap_error($this->connection).' ('.ldap_errno($this->connection).')';

It seems like $this->connection can also be of type SimpleSAML_Auth_LDAP; however, parameter $link_identifier of ldap_error() does only seem to accept resource, maybe add an additional type check?

It seems like $this->connection can also be of type SimpleSAML_Auth_LDAP; however, parameter $link_identifier of ldap_errno() does only seem to accept resource, maybe add an additional type check?

            $testResult->setState(State::ERROR);
        }

        $testResult->setMessage($msg);
        $this->setTestResult($testResult);
    }
}