SimpleSAML\Module\monitor\TestSuite\Configuration

Complexity

Total Complexity

7

Size/Duplication

Total Lines	90
Duplicated Lines	15.56 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
B	invokeTestSuite()	14	54	6

<?php

namespace SimpleSAML\Module\monitor\TestSuite;

use \SimpleSAML\Module\monitor\TestConfiguration as TestConfiguration;
use \SimpleSAML\Module\monitor\TestCase as TestCase;
use \SimpleSAML\Module\monitor\TestData as TestData;
use \SimpleSAML\Utils as Utils;

final class Configuration extends \SimpleSAML\Module\monitor\TestSuiteFactory
{
    /**
     * @param string|null
     */
    private $metadataCert = null;

    /**
     * @param string|null;
     */
    private $serverName = null;

    /**
     * @param integer|null;
     */
    private $serverPort = null;

    /**
     * @param TestConfiguration $configuration
     */
    public function __construct($configuration)
    {
        $globalConfig = $configuration->getGlobalConfig();
        $serverVars = $configuration->getServerVars();

        $this->metadataCert = $globalConfig->getString('metadata.sign.certificate', null);
        $this->serverName = $serverVars->get('SERVER_NAME');
        $this->serverPort = $serverVars->get('SERVER_PORT');

        parent::__construct($configuration);
    }

    /**
     * @return void
     */
    protected function invokeTestSuite()
    {
        // Check network connection to full public URL
        $input = [
            'connectString' => 'ssl://'.$hostname.':'.$port,

The variable $hostname does not exist. Did you forget to declare it?

The variable $port does not exist. Did you forget to declare it?

            'context' => stream_context_create([
                "ssl" => [
                    "capture_peer_cert" => true,
                    "verify_peer" => false,
                    "verify_peer_name" => false
                ]
            ]),
        ];

        $connTest = new TestCase\Network\ConnectUri($this, new TestData($input));
        $connTestResult = $connTest->getTestResult();

        $this->addTest($connTest);

        if ($connTestResult->getState() === State::OK) {

This code seems to be duplicated across your project.

            // Check Service Communications Certificate
            $certData = $connTestResult->getOutput('certData');
            
            if (Utils\HTTP::isHTTPS() && $certData !== null) {
                $input = [
                    'category' => 'Service Communications Certificate',
                    'certData' => $certData,
                ];

                $certTest = new TestCase\Cert\Data($this, new TestData($input));
                $this->addTest($certTest);
            } // else {'Unable to capture peer certificate'}

67% of this comment could be valid code. Did you maybe forget this after debugging?

        }

        // Check metadata signing certificate when available
        if (is_string($this->metadataCert)) {
            $input = array(
                'certFile' => Utils\Config::getCertPath($this->metadataCert),
                'category' => 'Metadata Signing Certificate'
            );
            $testData = new TestData($input);

            $test = new TestCase\Cert\File($this, $testData);
            $this->addTest($test);
        }

        $tests = $this->getTests();
        foreach ($tests as $test)
        {
            $this->addMessages($test->getMessages());
        }

        $this->calculateState();
    }
}