Bind - Code Metrics - Inspection of "Update Bind.php" - tvdijen/simplesamlphp-module-monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5173e3...dbfdce )

by Tim

created 2018-01-08 17:05 UTC

Bind A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	57
rs	10
c	0
b	0
f	0
wmc	3
lcom	1
cbo	2

<?php


namespace SimpleSAML\Module\monitor\TestCase\AuthSource\Ldap;

use \SimpleSAML\Module\monitor\State as State;
use \SimpleSAML\Module\monitor\TestData as TestData;
use \SimpleSAML\Module\monitor\TestResult as TestResult;
use \SimpleSAML\Module\monitor\TestSuite as TestSuite;

final class Bind extends \SimpleSAML\Module\monitor\TestCaseFactory
{
    /*
     * @var \SimpleSAML_Auth_LDAP|null
     */
    private $connection = null;

    /*
     * @var string|null
     */
    private $username = null;

    /*
     * @var string|null
     */

    private $password = null;

    /*
     * @param TestData $testData
     *
     * @return void
     */
    protected function initialize($testData)
    {
        $this->connection = $testData->getInput('connection');
        $authSourceData = $testData->getInput('authSourceData');

        $this->username = $authSourceData['search.username'];
        $this->password = $authSourceData['search.password'];

        parent::initialize($testData);
    }

    /*
     * @return void
     */
    protected function invokeTest()
    {
        $connection = $this->connection;

        $testResult = new TestResult('LDAP Bind', $this->username);
        try {
            $bind = $connection->bind($this->username, $this->password);
        } catch (\Exception $e) {
            $bind = null;
        }

        if ($bind === true)
            $msg = 'Bind succesful';
            $state = State::OK;
        } elseif ($bind === false) {
class A {
    var $property;
}
            $msg = str_replace('Library - LDAP bind(): ', '', $e->getMessage());
            $state = State::ERROR;
class A {
    var $property;
}
        } else {
            $msg = ldap_error($connection).' ('.ldap_errno($connection).')';
class A {
    var $property;
}
            $state = State::ERROR;
class A {
    var $property;
}
        }

        $testResult->setMessage($msg);
class A {
    var $property;
}
        $testResult->setState($state);
class A {
    var $property;
}
        $this->setTestResult($testResult);
class A {
    var $property;
}
    }
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-12-30 11:20 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 10 and the first side effect is on line 73. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			namespace SimpleSAML\Module\monitor\TestCase\AuthSource\Ldap;
4
5			use \SimpleSAML\Module\monitor\State as State;
6			use \SimpleSAML\Module\monitor\TestData as TestData;
7			use \SimpleSAML\Module\monitor\TestResult as TestResult;
8			use \SimpleSAML\Module\monitor\TestSuite as TestSuite;
9
10			final class Bind extends \SimpleSAML\Module\monitor\TestCaseFactory
11			{
12			/*
13			* @var \SimpleSAML_Auth_LDAP\|null
14			*/
15			private $connection = null;
16
17			/*
18			* @var string\|null
19			*/
20			private $username = null;
21
22			/*
23			* @var string\|null
24			*/
25
26			private $password = null;
27
28			/*
29			* @param TestData $testData
30			*
31			* @return void
32			*/
33			protected function initialize($testData)
34			{
35			$this->connection = $testData->getInput('connection');
36			$authSourceData = $testData->getInput('authSourceData');
37
38			$this->username = $authSourceData['search.username'];
39			$this->password = $authSourceData['search.password'];
40
41			parent::initialize($testData);
42			}
43
44			/*
45			* @return void
46			*/
47			protected function invokeTest()
48			{
49			$connection = $this->connection;
50
51			$testResult = new TestResult('LDAP Bind', $this->username);
52			try {
53			$bind = $connection->bind($this->username, $this->password);
54			} catch (\Exception $e) {
55			$bind = null;
56			}
57
58			if ($bind === true)
59			$msg = 'Bind succesful';
60			$state = State::OK;
61			} elseif ($bind === false) {
			0 ignored issues – show Bug introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_ELSEIF, expecting T_FUNCTION or T_CONST Loading history... Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history... Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$bind`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
62			$msg = str_replace('Library - LDAP bind(): ', '', $e->getMessage());
63			$state = State::ERROR;
			0 ignored issues – show Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$state`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
64			} else {
65			$msg = ldap_error($connection).' ('.ldap_errno($connection).')';
			0 ignored issues – show Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history... Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$msg`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
66			$state = State::ERROR;
			0 ignored issues – show Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$state`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
67			}
68
69			$testResult->setMessage($msg);
			0 ignored issues – show Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history... Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$testResult`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
70			$testResult->setState($state);
			0 ignored issues – show Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history... Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$testResult`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
71			$this->setTestResult($testResult);
			0 ignored issues – show Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history... Coding Style introduced 2018-01-08 17:07 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$this`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
72			}
73			}
74

tvdijen / simplesamlphp-module-monitor

Push — master ( 5173e3...dbfdce )

Bind A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

Duplication Side-by-Side

Filter issues like