PhoneNumber::sanitizePhoneNumber() - Code Metrics - Inspection of "Add proper phone number sanitizing" - tvdijen/simplesamlphp-module-cmdotcom - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 257e17...004729 )

by Tim

created 2021-07-05 22:31 UTC

PhoneNumber::sanitizePhoneNumber() A

↳ Parent: PhoneNumber

Complexity

Conditions	4
Paths	4

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	10
dl	0
loc	17
rs	9.9332
c	1
b	0
f	0
cc	4
nc	4
nop	2

<?php

/**
 * Phone number utilities for SMS-based OTP.
 *
 * @package tvdijen/simplesamlphp-module-cmdotcom
 */

declare(strict_types=1);

namespace SimpleSAML\Module\cmdotcom\Utils;

use libphonenumber\NumberParseException;
use libphonenumber\PhoneNumber as Number;
use libphonenumber\PhoneNumberFormat;
use libphonenumber\PhoneNumberUtil;

class PhoneNumber
{
    /**
     * Sanitize the mobile phone number for use with the cm.com Rest API
     *
     * @param string $number
     * @return string
     * @throws \UnexpectedValueException if the mobile phone number contains illegal characters or is otherwise invalid.
     */
    public function sanitizePhoneNumber(string $number, $defaultRegion = 'NL'): string
    {
        $util = PhoneNumberUtil::getInstance();
        $region = strpos($number, '+') === false ? $defaultRegion : 'ZZ';
        $proto = $util->parse($number, $region);

        if (
            $util->isViablePhoneNumber($number) === false
            || $util->isValidNumber($proto) === false
        ) {
            throw new NumberParseException(
                NumberParseException::NOT_A_NUMBER,
                "The string supplied did not seem to be a phone number."
            );
        }

        return '00' . $proto->getCountryCode() . $proto->getNationalNumber();
    }
}


1			<?php
2
3			/**
4			* Phone number utilities for SMS-based OTP.
5			*
6			* @package tvdijen/simplesamlphp-module-cmdotcom
7			*/
8
9			declare(strict_types=1);
10
11			namespace SimpleSAML\Module\cmdotcom\Utils;
12
13			use libphonenumber\NumberParseException;
14			use libphonenumber\PhoneNumber as Number;
15			use libphonenumber\PhoneNumberFormat;
16			use libphonenumber\PhoneNumberUtil;
17
18			class PhoneNumber
19			{
20			/**
21			* Sanitize the mobile phone number for use with the cm.com Rest API
22			*
23			* @param string $number
24			* @return string
25			* @throws \UnexpectedValueException if the mobile phone number contains illegal characters or is otherwise invalid.
26			*/
27			public function sanitizePhoneNumber(string $number, $defaultRegion = 'NL'): string
28			{
29			$util = PhoneNumberUtil::getInstance();
30			$region = strpos($number, '+') === false ? $defaultRegion : 'ZZ';
31			$proto = $util->parse($number, $region);
32
33			if (
34			$util->isViablePhoneNumber($number) === false
35			\|\| $util->isValidNumber($proto) === false
36			) {
37			throw new NumberParseException(
38			NumberParseException::NOT_A_NUMBER,
39			"The string supplied did not seem to be a phone number."
40			);
41			}
42
43			return '00' . $proto->getCountryCode() . $proto->getNationalNumber();
44			}
45			}
46

tvdijen / simplesamlphp-module-cmdotcom

Push — master ( 257e17...004729 )

PhoneNumber::sanitizePhoneNumber() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like