ReadableBehavior::markAsRead() - Code Metrics - Inspection of "Introduce database notifications" - tuyakhov/yii2-notifications - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#5)

by Anton

created 2018-07-07 10:51 UTC

ReadableBehavior::markAsRead() A

↳ Parent: ReadableBehavior

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
dl	8
loc	8
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php
/**
 * @copyright Anton Tuyakhov <[email protected]>
 */

namespace tuyakhov\notifications\behaviors;


use yii\base\Behavior;
use yii\db\ActiveRecordInterface;

class ReadableBehavior extends Behavior
{

    public $readAttribute = 'read_at';

    /**
     * Mark the notification as read.
     * @throws \Exception
     * @throws \Throwable
     */
    public function markAsRead()

    {
        /** @var ActiveRecordInterface $model */
        $model = $this->owner;
        if (is_null($model->{$this->readAttribute})) {
            $model->update(false, [$this->readAttribute => date('Y-m-d H:i:s')]);
        }
    }

    /**
     * Mark the notification as unread.
     * @return void
     * @throws \Exception
     * @throws \Throwable
     */
    public function markAsUnread()

    {
        /** @var ActiveRecordInterface $model */
        $model = $this->owner;
        if (!is_null($model->{$this->readAttribute})) {
            $model->update(false, [$this->readAttribute => null]);
        }
    }

    /**
     * Determine if a notification has been read.
     *
     * @return bool
     */
    public function isRead()
    {
        return $this->owner->{$this->readAttribute} !== null;
    }
    /**
     * Determine if a notification has not been read.
     *
     * @return bool
     */
    public function isUnread()
    {
        return $this->owner->{$this->readAttribute} === null;
    }
}

1		<?php
2		/**
3		* @copyright Anton Tuyakhov <[email protected]>
4		*/
5
6		namespace tuyakhov\notifications\behaviors;
7
8
9		use yii\base\Behavior;
10		use yii\db\ActiveRecordInterface;
11
12		class ReadableBehavior extends Behavior
13		{
14
15		public $readAttribute = 'read_at';
16
17		/**
18		* Mark the notification as read.
19		* @throws \Exception
20		* @throws \Throwable
21		*/
22	View Code Duplication	public function markAsRead()
		0 ignored issues – show Duplication introduced 2018-07-07 10:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		/** @var ActiveRecordInterface $model */
25		$model = $this->owner;
26		if (is_null($model->{$this->readAttribute})) {
27		$model->update(false, [$this->readAttribute => date('Y-m-d H:i:s')]);
28		}
29		}
30
31		/**
32		* Mark the notification as unread.
33		* @return void
34		* @throws \Exception
35		* @throws \Throwable
36		*/
37	View Code Duplication	public function markAsUnread()
		0 ignored issues – show Duplication introduced 2018-07-07 10:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		/** @var ActiveRecordInterface $model */
40		$model = $this->owner;
41		if (!is_null($model->{$this->readAttribute})) {
42		$model->update(false, [$this->readAttribute => null]);
43		}
44		}
45
46		/**
47		* Determine if a notification has been read.
48		*
49		* @return bool
50		*/
51		public function isRead()
52		{
53		return $this->owner->{$this->readAttribute} !== null;
54		}
55		/**
56		* Determine if a notification has not been read.
57		*
58		* @return bool
59		*/
60		public function isUnread()
61		{
62		return $this->owner->{$this->readAttribute} === null;
63		}
64		}

tuyakhov / yii2-notifications

Pull Request — master (#5)

ReadableBehavior::markAsRead() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like