tuyakhov\notifications\NotifiableBehavior

Complexity

Total Complexity

14

Size/Duplication

Total Lines	78
Duplicated Lines	20.51 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	5	1
A	attach()	8	12	4
B	detach()	8	14	5
A	handle()	0	20	4

<?php
/**
 * @copyright Anton Tuyakhov <atuyakhov@gmail.com>
 */

namespace tuyakhov\notifications;


use yii\base\Behavior;
use yii\base\Event;
use yii\di\Instance;

class NotifiableBehavior extends Behavior
{
    public $notifications = [];

    /**
     * @var Notifier
     */
    public $notifier = 'notifier';

    public function init()
    {
        parent::init();
        $this->notifier = Instance::of($this->notifier);

$this->notifier is of type object<tuyakhov\notifications\Notifier>, but the function expects a string.

It seems like \yii\di\Instance::of($this->notifier) of type object<yii\di\Instance> is incompatible with the declared type object<tuyakhov\notifications\Notifier> of property $notifier.

    }

    /**
     * @inheritdoc
     */
    public function attach($owner)
    {
        $this->owner = $owner;
        foreach ($this->notifications as $event => $notifications) {

This code seems to be duplicated across your project.

            if (!is_array($notifications)) {
                $notifications = [$notifications];
            }
            foreach ($notifications as $notification) {
                $owner->on($event, [$this, 'handle'], ['notification' => $notification]);
            }
        }
    }

    /**
     * @inheritdoc
     */
    public function detach()
    {
        if ($this->owner) {
            foreach ($this->notifications as $event => $notifications) {

This code seems to be duplicated across your project.

                if (!is_array($notifications)) {
                    $notifications = [$notifications];
                }
                foreach ($notifications as $notification) {
                    $this->owner->off($event, [$this, 'handle']);
                }
            }
            $this->owner = null;
        }
    }

    /**
     * Handles the event using public properties.
     * @param Event $event
     * @throws \InvalidArgumentException
     * @throws \RuntimeException
     */
    public function handle(Event $event)
    {
        if (!isset($event->data['notification'])) {
            throw new \InvalidArgumentException('Can not find `notification` in event data');
        }
        if (!$this->owner instanceof NotifiableInterface) {
            throw new \RuntimeException('Owner should implement `NotifiableInterface`');
        }
        $notification = $event->data['notification'];
        $config = [];

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

        foreach (get_object_vars($event) as $param) {
            $config[$param] = $event->$param;
        }
        $config['class'] = $notification;
        /**
         * @var $notification NotificationInterface
         */
        $notification = \Yii::createObject($config);
        $this->notifier->send($this->owner, $notification);
    }


}