JsonApiParser - Code Metrics - Inspection of "implement serializer, jsonapi parser, resource tra..." - tuyakhov/yii2-json-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 672c08...9a8256 )

by Anton

created 2016-11-12 12:33 UTC

JsonApiParser A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	25.81 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	11
lcom	0
cbo	3
dl	8
loc	31
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
C	parse()	8	24	11

How to fix Duplicated Code

<?php
/**
 * @author Anton Tuyakhov <[email protected]>
 */

namespace tuyakhov\jsonapi;

use yii\helpers\ArrayHelper;
use yii\helpers\Inflector;
use \yii\web\JsonParser;

class JsonApiParser extends JsonParser
{
    /**
     * Parse resource object into the input data to populates the model
     * @inheritdoc
     */
    public function parse($rawBody, $contentType)
    {
        $array = parent::parse($rawBody, $contentType);
        if ($type = ArrayHelper::getValue($array, 'data.type')) {
            $formName = Inflector::id2camel(Inflector::singularize($type));
$a = "a";
$ab = "ab";
$abc = "abc";
            $result[$formName] = ArrayHelper::getValue($array, 'data.attributes');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            if ($relationships = ArrayHelper::getValue($array, 'data.relationships')) {
                foreach ($relationships as $name => $relationship) {
                    if (isset($relationship[0])) {
                        foreach ($relationship as $item) {
                            if (isset($item['type']) && isset($item['id'])) {

                                $formName = Inflector::id2camel(Inflector::singularize($item['type']));
$a = "a";
$ab = "ab";
$abc = "abc";
                                $result[$name][$formName][] = $item;
                            }
                        }
                    } elseif (isset($relationship['type']) && isset($relationship['id'])) {

                        $formName = Inflector::id2camel(Inflector::singularize($relationship['type']));
$a = "a";
$ab = "ab";
$abc = "abc";
                        $result[$name][$formName] = $relationship;
                    }
                }
            }
        }
        return isset($result) ? $result : $array;
    }
}



1		<?php
2		/**
3		* @author Anton Tuyakhov <[email protected]>
4		*/
5
6		namespace tuyakhov\jsonapi;
7
8		use yii\helpers\ArrayHelper;
9		use yii\helpers\Inflector;
10		use \yii\web\JsonParser;
11
12		class JsonApiParser extends JsonParser
13		{
14		/**
15		* Parse resource object into the input data to populates the model
16		* @inheritdoc
17		*/
18		public function parse($rawBody, $contentType)
19		{
20		$array = parent::parse($rawBody, $contentType);
21		if ($type = ArrayHelper::getValue($array, 'data.type')) {
22		$formName = Inflector::id2camel(Inflector::singularize($type));
		0 ignored issues – show Coding Style introduced 2016-11-12 12:36 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
23		$result[$formName] = ArrayHelper::getValue($array, 'data.attributes');
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-12 12:36 UTC by Report Bug Copy Issue Report `$result` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$result = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
24		if ($relationships = ArrayHelper::getValue($array, 'data.relationships')) {
25		foreach ($relationships as $name => $relationship) {
26		if (isset($relationship[0])) {
27		foreach ($relationship as $item) {
28	View Code Duplication	if (isset($item['type']) && isset($item['id'])) {
		0 ignored issues – show Duplication introduced 2016-11-12 12:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		$formName = Inflector::id2camel(Inflector::singularize($item['type']));
		0 ignored issues – show Coding Style introduced 2016-11-12 12:36 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 19 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
30		$result[$name][$formName][] = $item;
31		}
32		}
33	View Code Duplication	} elseif (isset($relationship['type']) && isset($relationship['id'])) {
		0 ignored issues – show Duplication introduced 2016-11-12 12:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		$formName = Inflector::id2camel(Inflector::singularize($relationship['type']));
		0 ignored issues – show Coding Style introduced 2016-11-12 12:36 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
35		$result[$name][$formName] = $relationship;
36		}
37		}
38		}
39		}
40		return isset($result) ? $result : $array;
41		}
42		}
		0 ignored issues – show Coding Style introduced 2016-04-11 12:58 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
43

tuyakhov / yii2-json-api

Push — master ( 672c08...9a8256 )

JsonApiParser A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like