DeleteRelationshipAction::unlinkRelationships() - Code Metrics - Inspection of "Merge pull request #48 from tuyakhov/add_delete_ac..." - tuyakhov/yii2-json-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d63ab9...9b5ad1 )

by Anton

created 2018-03-10 16:28 UTC

DeleteRelationshipAction::unlinkRelationships() C

↳ Parent: DeleteRelationshipAction

Complexity

Conditions	8
Paths	15

Size

Total Lines	30
Code Lines	17

Duplication

Lines	6
Ratio	20 %

Importance

Changes

Metric	Value
dl	6
loc	30
rs	5.3846
c	0
b	0
f	0
cc	8
eloc	17
nc	15
nop	2

<?php
/**
 * @author Anton Tuyakhov <[email protected]>
 */

namespace tuyakhov\jsonapi\actions;

use Yii;
use yii\data\ActiveDataProvider;
use yii\db\ActiveRecordInterface;
use yii\db\ActiveRelationTrait;
use yii\db\BaseActiveRecord;
use yii\helpers\ArrayHelper;
use yii\web\ForbiddenHttpException;
use yii\web\NotFoundHttpException;

/**
 * Deletes the specified members from a relationship
 * @link http://jsonapi.org/format/#crud-updating-relationships
 */
class DeleteRelationshipAction extends Action
{
    /**
     * Removes the relationships from primary model.
     * @var callable
     */
    public $unlinkRelationships;

    /**
     * @param string $id an ID of the primary resource
     * @param string $name a name of the related resource
     * @return ActiveDataProvider
     * @throws ForbiddenHttpException
     * @throws NotFoundHttpException
     * @throws \yii\base\InvalidConfigException
     */
    public function run($id, $name)

    {
        /** @var BaseActiveRecord $model */
        $model = $this->findModel($id);

        if (!$related = $model->getRelation($name, false)) {
            throw new NotFoundHttpException('Relationship does not exist');
        }

        if (!$related->multiple) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            throw new ForbiddenHttpException('Unsupported request to update relationship');
        }

        if ($this->checkAccess) {
            call_user_func($this->checkAccess, $this->id, $model, $name);
        }

        $this->unlinkRelationships($model, [$name => Yii::$app->getRequest()->getBodyParams()]);


        return new ActiveDataProvider([
            'query' => $related
        ]);
    }

    /**
     * Removes the relationships from primary model.
     * @param $model ActiveRecordInterface
     * @param array $data relationship links
     */
    protected function unlinkRelationships($model, array $data = [])
    {
        if ($this->unlinkRelationships !== null) {
            call_user_func($this->unlinkRelationships, $this, $model, $data);
            return;
        }

        foreach ($data as $name => $relationship) {
            /** @var $related ActiveRelationTrait */
            if (!$related = $model->getRelation($name, false)) {
                continue;
            }
            /** @var BaseActiveRecord $relatedClass */
            $relatedClass = new $related->modelClass;
$a = "a";
$ab = "ab";
$abc = "abc";
            $relationships = ArrayHelper::keyExists($relatedClass->formName(), $relationship) ? $relationship[$relatedClass->formName()] : [];

            $ids = [];
            foreach ($relationships as $index => $relObject) {

                if (!isset($relObject['id'])) {
                    continue;
                }
                $ids[] = $relObject['id'];
            }

            $records = $relatedClass::find()->andWhere(['in', $relatedClass::primaryKey(), $ids])->all();
            foreach ($records as $record) {
                $model->unlink($name, $record);
            }
        }
    }
}

1		<?php
2		/**
3		* @author Anton Tuyakhov <[email protected]>
4		*/
5
6		namespace tuyakhov\jsonapi\actions;
7
8		use Yii;
9		use yii\data\ActiveDataProvider;
10		use yii\db\ActiveRecordInterface;
11		use yii\db\ActiveRelationTrait;
12		use yii\db\BaseActiveRecord;
13		use yii\helpers\ArrayHelper;
14		use yii\web\ForbiddenHttpException;
15		use yii\web\NotFoundHttpException;
16
17		/**
18		* Deletes the specified members from a relationship
19		* @link http://jsonapi.org/format/#crud-updating-relationships
20		*/
21		class DeleteRelationshipAction extends Action
22		{
23		/**
24		* Removes the relationships from primary model.
25		* @var callable
26		*/
27		public $unlinkRelationships;
28
29		/**
30		* @param string $id an ID of the primary resource
31		* @param string $name a name of the related resource
32		* @return ActiveDataProvider
33		* @throws ForbiddenHttpException
34		* @throws NotFoundHttpException
35		* @throws \yii\base\InvalidConfigException
36		*/
37	View Code Duplication	public function run($id, $name)
		0 ignored issues – show Duplication introduced 2018-03-10 15:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		/** @var BaseActiveRecord $model */
40		$model = $this->findModel($id);
41
42		if (!$related = $model->getRelation($name, false)) {
43		throw new NotFoundHttpException('Relationship does not exist');
44		}
45
46		if (!$related->multiple) {
		0 ignored issues – show Bug introduced 2018-03-10 15:36 UTC by Report Bug Copy Issue Report Accessing `multiple` on the interface `yii\db\ActiveQueryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
47		throw new ForbiddenHttpException('Unsupported request to update relationship');
48		}
49
50		if ($this->checkAccess) {
51		call_user_func($this->checkAccess, $this->id, $model, $name);
52		}
53
54		$this->unlinkRelationships($model, [$name => Yii::$app->getRequest()->getBodyParams()]);
55
56
57		return new ActiveDataProvider([
58		'query' => $related
59		]);
60		}
61
62		/**
63		* Removes the relationships from primary model.
64		* @param $model ActiveRecordInterface
65		* @param array $data relationship links
66		*/
67		protected function unlinkRelationships($model, array $data = [])
68		{
69		if ($this->unlinkRelationships !== null) {
70		call_user_func($this->unlinkRelationships, $this, $model, $data);
71		return;
72		}
73
74		foreach ($data as $name => $relationship) {
75		/** @var $related ActiveRelationTrait */
76		if (!$related = $model->getRelation($name, false)) {
77		continue;
78		}
79		/** @var BaseActiveRecord $relatedClass */
80		$relatedClass = new $related->modelClass;
		0 ignored issues – show Coding Style introduced 2018-03-10 15:36 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
81		$relationships = ArrayHelper::keyExists($relatedClass->formName(), $relationship) ? $relationship[$relatedClass->formName()] : [];
82
83		$ids = [];
84	View Code Duplication	foreach ($relationships as $index => $relObject) {
		0 ignored issues – show Duplication introduced 2018-03-10 15:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		if (!isset($relObject['id'])) {
86		continue;
87		}
88		$ids[] = $relObject['id'];
89		}
90
91		$records = $relatedClass::find()->andWhere(['in', $relatedClass::primaryKey(), $ids])->all();
92		foreach ($records as $record) {
93		$model->unlink($name, $record);
94		}
95		}
96		}
97		}

tuyakhov / yii2-json-api

Push — master ( d63ab9...9b5ad1 )

DeleteRelationshipAction::unlinkRelationships() C

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like