UpdateRelationshipAction::prepareRelationships() - Code Metrics - Inspection of "Json api actions" - tuyakhov/yii2-json-api - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#22)

by Anton

created 2017-03-09 09:42 UTC

UpdateRelationshipAction::prepareRelationships() B

↳ Parent: Project

Complexity

Conditions	6
Paths	13

Size

Total Lines	29
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	29
rs	8.439
cc	6
eloc	16
nc	13
nop	1

<?php
/**
 * @author Anton Tuyakhov <[email protected]>
 */

namespace tuyakhov\jsonapi\actions;

use tuyakhov\jsonapi\ResourceInterface;
use yii\data\ActiveDataProvider;
use yii\db\BaseActiveRecord;
use yii\web\BadRequestHttpException;
use yii\web\NotFoundHttpException;
use Yii;

/**
 * UpdateRelationshipAction implements the API endpoint for updating relationships.
 * @link http://jsonapi.org/format/#crud-updating-relationships
 */
class UpdateRelationshipAction extends Action
{
    /**
     * Update of relationships independently.
     * @param string $id an ID of the primary resource
     * @param string $name a name of the related resource
     * @return ActiveDataProvider|BaseActiveRecord
     * @throws BadRequestHttpException
     * @throws NotFoundHttpException
     */
    public function run($id, $name)
    {
        /** @var BaseActiveRecord $model */
        $model = $this->findModel($id);

        if (!$related = $model->getRelation($name, false)) {
            throw new NotFoundHttpException('Relationship does not exist');
        }

        if ($this->checkAccess) {
            call_user_func($this->checkAccess, $this->id, $model, $name);
        }

        $this->linkRelationships($model, [$name => Yii::$app->getRequest()->getBodyParams()]);

        if ($related->multiple) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return new ActiveDataProvider([
                'query' => $related
            ]);
        } else {
            return $related->one();
        }
    }
}

1			<?php
2			/**
3			* @author Anton Tuyakhov <[email protected]>
4			*/
5
6			namespace tuyakhov\jsonapi\actions;
7
8			use tuyakhov\jsonapi\ResourceInterface;
9			use yii\data\ActiveDataProvider;
10			use yii\db\BaseActiveRecord;
11			use yii\web\BadRequestHttpException;
12			use yii\web\NotFoundHttpException;
13			use Yii;
14
15			/**
16			* UpdateRelationshipAction implements the API endpoint for updating relationships.
17			* @link http://jsonapi.org/format/#crud-updating-relationships
18			*/
19			class UpdateRelationshipAction extends Action
20			{
21			/**
22			* Update of relationships independently.
23			* @param string $id an ID of the primary resource
24			* @param string $name a name of the related resource
25			* @return ActiveDataProvider\|BaseActiveRecord
26			* @throws BadRequestHttpException
27			* @throws NotFoundHttpException
28			*/
29			public function run($id, $name)
30			{
31			/** @var BaseActiveRecord $model */
32			$model = $this->findModel($id);
33
34			if (!$related = $model->getRelation($name, false)) {
35			throw new NotFoundHttpException('Relationship does not exist');
36			}
37
38			if ($this->checkAccess) {
39			call_user_func($this->checkAccess, $this->id, $model, $name);
40			}
41
42			$this->linkRelationships($model, [$name => Yii::$app->getRequest()->getBodyParams()]);
43
44			if ($related->multiple) {
			0 ignored issues – show Bug introduced 2017-03-09 09:46 UTC by Report Bug Copy Issue Report Accessing `multiple` on the interface `yii\db\ActiveQueryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
45			return new ActiveDataProvider([
46			'query' => $related
47			]);
48			} else {
49			return $related->one();
50			}
51			}
52			}

tuyakhov / yii2-json-api

Pull Request — master (#22)

UpdateRelationshipAction::prepareRelationships() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like