Action::linkRelationships() - Code Metrics - Inspection of "Json api actions" - tuyakhov/yii2-json-api - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#22)

by Anton

created 2017-03-09 09:42 UTC

Action::linkRelationships() C

↳ Parent: Action

Complexity

Conditions	11
Paths	22

Size

Total Lines	38
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	38
rs	5.2653
c	0
b	0
f	0
cc	11
eloc	22
nc	22
nop	2

How to fix Complexity

<?php
/**
 * @author Anton Tuyakhov <[email protected]>
 */

namespace tuyakhov\jsonapi\actions;

use tuyakhov\jsonapi\ResourceInterface;
use yii\db\ActiveRecordInterface;
use yii\db\BaseActiveRecord;
use yii\helpers\ArrayHelper;

class Action extends \yii\rest\Action
{
    /**
     * Links the relationships with primary model.
     * @var callable
     */
    public $linkRelationships;

    /**
     * @var bool Weather allow to do a full replacement of a to-many relationship
     */
    public $allowFullReplacement = true;

    /**
     * Links the relationships with primary model.
     * @param $model ActiveRecordInterface
     * @param array $data
     */
    protected function linkRelationships($model, array $data = [])
    {
        if ($this->linkRelationships !== null) {
            call_user_func($this->linkRelationships, $this, $model, $data);
            return;
        }

        if (!$model instanceof ResourceInterface) {
            return;
        }

        foreach ($data as $name => $relationship) {
            if (!$related = $model->getRelation($name, false)) {

                continue;
            }
            /** @var BaseActiveRecord $relatedClass */
            $relatedClass = new $related->modelClass;
$a = "a";
$ab = "ab";
$abc = "abc";
            $relationships = ArrayHelper::keyExists($relatedClass->formName(), $relationship) ? $relationship[$relatedClass->formName()] : [];

            $ids = [];
            foreach ($relationships as $index => $relObject) {
                if (!isset($relObject['id'])) {
                    continue;
                }
                $ids[] = $relObject['id'];
            }

            if (!$records = $relatedClass::find()->andWhere(['in', $relatedClass::primaryKey(), $ids])->all()) {
                continue;
            }

            if ($related->multiple && !$this->allowFullReplacement) {
                continue;
            }
            $model->unlinkAll($name);

            $model->setResourceRelationship($name, $records);
        }
    }
}

1			<?php
2			/**
3			* @author Anton Tuyakhov <[email protected]>
4			*/
5
6			namespace tuyakhov\jsonapi\actions;
7
8			use tuyakhov\jsonapi\ResourceInterface;
9			use yii\db\ActiveRecordInterface;
10			use yii\db\BaseActiveRecord;
11			use yii\helpers\ArrayHelper;
12
13			class Action extends \yii\rest\Action
14			{
15			/**
16			* Links the relationships with primary model.
17			* @var callable
18			*/
19			public $linkRelationships;
20
21			/**
22			* @var bool Weather allow to do a full replacement of a to-many relationship
23			*/
24			public $allowFullReplacement = true;
25
26			/**
27			* Links the relationships with primary model.
28			* @param $model ActiveRecordInterface
29			* @param array $data
30			*/
31			protected function linkRelationships($model, array $data = [])
32			{
33			if ($this->linkRelationships !== null) {
34			call_user_func($this->linkRelationships, $this, $model, $data);
35			return;
36			}
37
38			if (!$model instanceof ResourceInterface) {
39			return;
40			}
41
42			foreach ($data as $name => $relationship) {
43			if (!$related = $model->getRelation($name, false)) {
			0 ignored issues – show Bug introduced 2017-03-09 09:46 UTC by Report Bug Copy Issue Report The method `getRelation()` does not seem to exist on `object<tuyakhov\jsonapi\ResourceInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
44			continue;
45			}
46			/** @var BaseActiveRecord $relatedClass */
47			$relatedClass = new $related->modelClass;
			0 ignored issues – show Coding Style introduced 2017-03-09 09:46 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
48			$relationships = ArrayHelper::keyExists($relatedClass->formName(), $relationship) ? $relationship[$relatedClass->formName()] : [];
49
50			$ids = [];
51			foreach ($relationships as $index => $relObject) {
52			if (!isset($relObject['id'])) {
53			continue;
54			}
55			$ids[] = $relObject['id'];
56			}
57
58			if (!$records = $relatedClass::find()->andWhere(['in', $relatedClass::primaryKey(), $ids])->all()) {
59			continue;
60			}
61
62			if ($related->multiple && !$this->allowFullReplacement) {
63			continue;
64			}
65			$model->unlinkAll($name);
			0 ignored issues – show Bug introduced 2017-03-09 09:46 UTC by Report Bug Copy Issue Report The method `unlinkAll()` does not seem to exist on `object<tuyakhov\jsonapi\ResourceInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
66			$model->setResourceRelationship($name, $records);
67			}
68			}
69			}

tuyakhov / yii2-json-api

Pull Request — master (#22)

Action::linkRelationships() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like