Issues (468)

Security Analysis    no request data  

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Braintree.php (180 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * @copyright Anton Tuyakhov <[email protected]>
4
 */
5
namespace tuyakhov\braintree;
6
7
use yii\base\Component;
8
use yii\base\InvalidConfigException;
9
10
class Braintree extends Component
11
{
12
    public $environment = 'sandbox';
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
13
    public $merchantId;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
14
    public $publicKey;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
15
    public $privateKey;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
16
    public $clientSideKey;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
17
18
    public $options;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
19
20
    /**
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
21
     * Sets up Braintree configuration from config file
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
22
     * @throws \yii\base\InvalidConfigException
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
23
     */
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
24
    public function init()
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
25
    {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
26
        foreach (['merchantId', 'publicKey', 'privateKey', 'environment'] as $attribute) {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
27
            if ($this->$attribute === null) {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
28
                throw new InvalidConfigException(strtr('"{class}::{attribute}" cannot be empty.', [
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
29
                    '{class}' => static::className(),
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
30
                    '{attribute}' => '$' . $attribute
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
31
                ]));
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
32
            }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
33
            \Braintree_Configuration::$attribute($this->$attribute);
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
34
        }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
35
        $this->clientSideKey = \Braintree_ClientToken::generate();
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
36
        parent::init();
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
37
    }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
38
39
    /**
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
40
     * Braintree sale function
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
41
     * @param bool|true $submitForSettlement
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
42
     * @param bool|true $storeInVaultOnSuccess
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
43
     * @return array
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
44
     */
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
45
    public function singleCharge($submitForSettlement = true, $storeInVaultOnSuccess = true)
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
46
    {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
47
        $this->options['options']['submitForSettlement'] = $submitForSettlement;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.

To visualize

$a = "a";
$ab = "ab";
$abc = "abc";

will produce issues in the first and second line, while this second example

$a   = "a";
$ab  = "ab";
$abc = "abc";

will produce no issues.

Loading history...
48
        $this->options['options']['storeInVaultOnSuccess'] = $storeInVaultOnSuccess;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
49
        $result = \Braintree_Transaction::sale($this->options);
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Equals sign not aligned with surrounding assignments; expected 44 spaces but found 1 space

This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.

To visualize

$a = "a";
$ab = "ab";
$abc = "abc";

will produce issues in the first and second line, while this second example

$a   = "a";
$ab  = "ab";
$abc = "abc";

will produce no issues.

Loading history...
50
51
        if ($result->success) {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
52
            return ['status' => true, 'result' => $result];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
53 View Code Duplication
        } else if ($result->transaction) {
0 ignored issues
show
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
Tabs must be used to indent lines; spaces are not allowed
Loading history...
54
            return ['status' => false, 'result' => $result];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
55
        } else {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
56
            return ['status' => false, 'result' => $result];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
57
        }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
58
    }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
59
60
    /**
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
61
     * Finds transaction by id
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
62
     */
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
63
    public function findTransaction($id)
0 ignored issues
show
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
Tabs must be used to indent lines; spaces are not allowed
Loading history...
64
    {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
65
        return \Braintree_Transaction::find($id);
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
66
    }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
67
68
    /**
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
69
     * This save customer to braintree and returns result array
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
70
     * @return array
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
71
     */
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
72
    public function saveCustomer()
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
73
    {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
74
        if (isset($this->options['customerId'])) {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
75
            $this->options['customer']['id'] = $this->options['customerId'];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
76
        }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
77
        $result = \Braintree_Customer::create($this->options['customer']);
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
78
79 View Code Duplication
        if ($result->success) {
0 ignored issues
show
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
Tabs must be used to indent lines; spaces are not allowed
Loading history...
80
            return ['status' => true, 'result' => $result];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
81
        } else {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
82
            return ['status' => false, 'result' => $result];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
83
        }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
84
    }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
85
86
    /**
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
87
     * This save credit cart to braintree
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
88
     * @return array
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
89
     */
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
90
    public function saveCreditCard()
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
91
    {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
92
        $send_array = $this->options['creditCard'];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Variable "send_array" is not in valid camel caps format
Loading history...
93
        if (isset($this->options['billing'])) {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
94
            $send_array['billingAddress'] = $this->options['billing'];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Variable "send_array" is not in valid camel caps format
Loading history...
95
        }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
96
        if (isset($this->options['customerId'])) {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
97
            $send_array['customerId'] = $this->options['customerId'];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Variable "send_array" is not in valid camel caps format
Loading history...
98
        }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
99
        $result = \Braintree_CreditCard::create($send_array);
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Variable "send_array" is not in valid camel caps format
Loading history...
100
101 View Code Duplication
        if ($result->success) {
0 ignored issues
show
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
Tabs must be used to indent lines; spaces are not allowed
Loading history...
102
            return ['status' => true, 'result' => $result];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
103
        } else {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
104
            return ['status' => false, 'result' => $result];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
105
        }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
106
    }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
107
108
    public function saveAddress()
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
109
    {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
110
        $send_array = $this->options['billing'];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Variable "send_array" is not in valid camel caps format
Loading history...
111
        if (isset($this->options['customerId'])) {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
112
            $send_array['customerId'] = $this->options['customerId'];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Variable "send_array" is not in valid camel caps format
Loading history...
113
        }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
114
        $result = \Braintree_Address::create($send_array);
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Variable "send_array" is not in valid camel caps format
Loading history...
115
116 View Code Duplication
        if ($result->success) {
0 ignored issues
show
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
Tabs must be used to indent lines; spaces are not allowed
Loading history...
117
            return ['status' => true, 'result' => $result];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
118
        } else {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
119
            return ['status' => false, 'result' => $result];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
120
        }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
121
    }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
122
123
    /**
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
124
     * Constructs the Credit Card array for payment
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
125
     * @param integer $number Credit Card Number
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
126
     * @param integer $cvv (optional)Credit Card Security code
0 ignored issues
show
Should the type for parameter $cvv not be integer|null?

This check looks for @param annotations where the type inferred by our type inference engine differs from the declared type.

It makes a suggestion as to what type it considers more descriptive.

Most often this is a case of a parameter that can be null in addition to its declared types.

Loading history...
Tabs must be used to indent lines; spaces are not allowed
Loading history...
127
     * @param integer $expirationMonth format: MM (use expirationMonth and expirationYear or expirationDate not both)
0 ignored issues
show
Should the type for parameter $expirationMonth not be integer|null?

This check looks for @param annotations where the type inferred by our type inference engine differs from the declared type.

It makes a suggestion as to what type it considers more descriptive.

Most often this is a case of a parameter that can be null in addition to its declared types.

Loading history...
Tabs must be used to indent lines; spaces are not allowed
Loading history...
128
     * @param integer $expirationYear format: YYYY (use expirationMonth and expirationYear or expirationDate not both)
0 ignored issues
show
Should the type for parameter $expirationYear not be integer|null?

This check looks for @param annotations where the type inferred by our type inference engine differs from the declared type.

It makes a suggestion as to what type it considers more descriptive.

Most often this is a case of a parameter that can be null in addition to its declared types.

Loading history...
Tabs must be used to indent lines; spaces are not allowed
Loading history...
129
     * @param string $expirationDate format: MM/YYYY (use expirationMonth and expirationYear or expirationDate not both)
0 ignored issues
show
Should the type for parameter $expirationDate not be string|null?

This check looks for @param annotations where the type inferred by our type inference engine differs from the declared type.

It makes a suggestion as to what type it considers more descriptive.

Most often this is a case of a parameter that can be null in addition to its declared types.

Loading history...
Tabs must be used to indent lines; spaces are not allowed
Loading history...
130
     */
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
131
    public function setCreditCard($number, $cvv = null, $expirationMonth = null, $expirationYear = null, $expirationDate = null)
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
132
    {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
133
        $this->options['creditCard'] = [];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Equals sign not aligned with surrounding assignments; expected 49 spaces but found 1 space

This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.

To visualize

$a = "a";
$ab = "ab";
$abc = "abc";

will produce issues in the first and second line, while this second example

$a   = "a";
$ab  = "ab";
$abc = "abc";

will produce no issues.

Loading history...
134
        $this->options['creditCard']['number'] = $number;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Equals sign not aligned with surrounding assignments; expected 39 spaces but found 1 space

This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.

To visualize

$a = "a";
$ab = "ab";
$abc = "abc";

will produce issues in the first and second line, while this second example

$a   = "a";
$ab  = "ab";
$abc = "abc";

will produce no issues.

Loading history...
135
        if (isset($cvv)) $this->options['creditCard']['cvv'] = $cvv;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Single line "IF" must have an expression started from new line.
Loading history...
Equals sign not aligned with surrounding assignments; expected 25 spaces but found 1 space

This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.

To visualize

$a = "a";
$ab = "ab";
$abc = "abc";

will produce issues in the first and second line, while this second example

$a   = "a";
$ab  = "ab";
$abc = "abc";

will produce no issues.

Loading history...
136
        if (isset($expirationMonth)) $this->options['creditCard']['expirationMonth'] = $expirationMonth;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Single line "IF" must have an expression started from new line.
Loading history...
137
        if (isset($expirationYear)) $this->options['creditCard']['expirationYear'] = $expirationYear;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Single line "IF" must have an expression started from new line.
Loading history...
Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.

To visualize

$a = "a";
$ab = "ab";
$abc = "abc";

will produce issues in the first and second line, while this second example

$a   = "a";
$ab  = "ab";
$abc = "abc";

will produce no issues.

Loading history...
138
        if (isset($expirationDate)) $this->options['creditCard']['expirationDate'] = $expirationDate;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Single line "IF" must have an expression started from new line.
Loading history...
Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.

To visualize

$a = "a";
$ab = "ab";
$abc = "abc";

will produce issues in the first and second line, while this second example

$a   = "a";
$ab  = "ab";
$abc = "abc";

will produce no issues.

Loading history...
139
    }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
140
141
    public function getCreditCard($input_values)
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Variable "input_values" is not in valid camel caps format
Loading history...
142
    {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
143
        $default = [
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
144
            'cvv' => null,
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
145
            'expirationMonth' => null,
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
146
            'expirationYear' => null,
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
147
            'expirationDate' => null,
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
148
            'name' => null,
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
149
        ];
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
150
        $values = array_merge($default, $input_values);
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.

To visualize

$a = "a";
$ab = "ab";
$abc = "abc";

will produce issues in the first and second line, while this second example

$a   = "a";
$ab  = "ab";
$abc = "abc";

will produce no issues.

Loading history...
Variable "input_values" is not in valid camel caps format
Loading history...
151
        $this->setCreditCard($values['number'], $values['cvv'], $values['expirationMonth'], $values['expirationYear'], $values['expirationDate'], $values['name']);
0 ignored issues
show
The call to Braintree::setCreditCard() has too many arguments starting with $values['name'].

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress.

In this case you can add the @ignore PhpDoc annotation to the duplicate definition and it will be ignored.

Loading history...
Tabs must be used to indent lines; spaces are not allowed
Loading history...
152
    }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
153
154
    public function getOptions($values)
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
155
    {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
156
        if (!empty($values)) {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
157
            foreach ($values as $key => $value) {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
158
                if ($key == 'amount')
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
159
                    $this->setAmount($values['amount']);
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
160
                elseif ($key == 'creditCard')
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
161
                    $this->getCreditCard($values['creditCard']);
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
162
                else
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
163
                    $this->options[$key] = $value;
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
164
            }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
165
        }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
166
    }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
167
168
    /**
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
169
     * Set the amount to charge
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
170
     * @param float $amount No dollar sign needed
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
171
     */
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
172
    public function setAmount($amount)
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
173
    {
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
174
        $this->options['amount'] = round($amount, 2);
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
175
    }
0 ignored issues
show
Tabs must be used to indent lines; spaces are not allowed
Loading history...
176
}