turnaev / monitor-bundle

src/Command/CheckInfoCommand.php

<?php

/**
 * This file is part of the `tvi/monitor-bundle` project.
 *
 * (c) https://github.com/turnaev/monitor-bundle/graphs/contributors
 *
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

Missing @license tag in file comment

Missing @link tag in file comment

namespace Tvi\MonitorBundle\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Helper\TableCell;
use Symfony\Component\Console\Helper\TableSeparator;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Helper\Table;
use Tvi\MonitorBundle\Reporter\Console;
use Tvi\MonitorBundle\Runner\RunnerManager;

/**

Missing short description in doc comment

 * @author Vladimir Turnaev <turnaev@gmail.com>
 */

Missing @category tag in class comment

Missing @package tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

class CheckInfoCommand extends Command
{
    /**

Missing short description in doc comment

     * @var Manager

The type Tvi\MonitorBundle\Command\Manager was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    private $runnerManager;

Private member variable "runnerManager" must be prefixed with an underscore

    /**

Missing short description in doc comment

Parameter $runnerManager should have a doc-comment as per coding-style.

     * @param ?string $name

Missing parameter comment

Doc comment for parameter $name does not match actual variable name $runnerManager

     */
    public function __construct(RunnerManager $runnerManager, string $name = null)
    {
        parent::__construct($name);
        $this->runnerManager = $runnerManager;

It seems like $runnerManager of type Tvi\MonitorBundle\Runner\RunnerManager is incompatible with the declared type Tvi\MonitorBundle\Command\Manager of property $runnerManager.

    }

    protected function configure()

Missing doc comment for function configure()

    {
        $this
            ->setName(
                'tvi:monitor:check:info'
            )
            ->setDescription(
                'Info health checks'
            )
            ->addOption(
                'check',
                'c',
                InputOption::VALUE_OPTIONAL | InputOption::VALUE_IS_ARRAY,
                'Check filter'
            )
            ->addOption(
                'group',
                'g',
                InputOption::VALUE_OPTIONAL | InputOption::VALUE_IS_ARRAY,
                'Groups filter'
            )
            ->addOption(
                'tag',
                't',
                InputOption::VALUE_OPTIONAL | InputOption::VALUE_IS_ARRAY,
                'Tag(s) filter'
            )
            ->setHelp(
                <<<'EOT'
The <info>%command.name%</info> get check info

* INfo Checks:

  <info>php %command.full_name% [--check=... ,] [--group=... ,] [--tag==... ,] </info>

EOT
            );
    }

    /**

Missing short description in doc comment

Parameter $input should have a doc-comment as per coding-style.

Parameter $output should have a doc-comment as per coding-style.

     * @return int|null|void
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $checkFilter = $input->getOption('check');
        $groupFilter = $input->getOption('group');
        $tagFilter = $input->getOption('tag');

        $checks = $this->runnerManager->findChecksSorted($checkFilter, $groupFilter, $tagFilter);

        $table = new Table($output);
        $table->setHeaders(['Check', 'Tag(s)', 'Label']);

        $groupOld = null;
        foreach ($checks as $check) {
            $tags = $check->getTags();

            if ($tags) {
                $tags = $this->runnerManager->findTags($check->getTags());
                $tags = array_map(static function ($t) {

The opening parenthesis of a multi-line function call should be the last content on the line.

                    return $t->getLabel();
                }, $tags);

For multi-line function calls, the closing parenthesis should be on a new line.

                $tags = implode(', ', $tags);
            } else {
                $tags = null;
            }

            $group = null;
            $groupNew = sprintf('<fg=default;options=bold>%s</>', $check->getGroup());

            if ($groupOld !== $groupNew) {
                if ($groupOld) {
                    $table->addRow(new TableSeparator());
                }
                $table->addRow([new TableCell($groupNew, ['colspan' => 3])]);
                $table->addRow(new TableSeparator());

                $group = $groupOld = $groupNew;

The assignment to $group is dead and can be removed.

            }

            $importanceTag = Console::tagByImportance($check->getImportance());
            $id = sprintf('%s%s</>', $importanceTag, $check->getId());
            $table->addRow([$id, $tags, $check->getLabel()]);
        }

        $table->render();
    }
}