Tvi\MonitorBundle\Check\rabbitmq\QueueSize\Plugin

Complexity

Total Complexity

7

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Test Coverage

Coverage

97.44%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	checkRequirements()	0	4	2
A	checkFactoryConf()	0	24	4
A	_check()	0	26	1

<?php

/**
 * This file is part of the `tvi/monitor-bundle` project.
 *
 * (c) https://github.com/turnaev/monitor-bundle/graphs/contributors
 *
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

PHP version not specified

Missing @category tag in file comment

Missing @package tag in file comment

Missing @author tag in file comment

Missing @license tag in file comment

Missing @link tag in file comment

namespace Tvi\MonitorBundle\Check\rabbitmq\QueueSize;

use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Tvi\MonitorBundle\Check\CheckPluginAbstract;
use Tvi\MonitorBundle\Exception\FeatureRequired;

/**

Missing short description in doc comment

 * @author Vladimir Turnaev <turnaev@gmail.com>
 */

Missing @category tag in class comment

Missing @package tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

class Plugin extends CheckPluginAbstract
{
    const DESCR =

Multi-line assignments must have the equal sign on the second line

<<<'TXT'

Line indented incorrectly; expected at least 4 spaces, found 0

rabbit_mq description
TXT;

    const PATH = __DIR__;

    const GROUP = 'rabbit_mq';
    const CHECK_NAME = 'core:rabbit_mq:queue_size';

    /**

Missing short description in doc comment

Parameter $checkSettings should have a doc-comment as per coding-style.

     * @throws FeatureRequired
     */

Missing @return tag in function comment

    public function checkRequirements(array $checkSettings)
    {
        if (!class_exists('PhpAmqpLib\Connection\AMQPConnection')) {
            throw new FeatureRequired('PhpAmqpLib is not installed');
        }
    }

    public function checkFactoryConf(TreeBuilder $builder): ArrayNodeDefinition

Missing doc comment for function checkFactoryConf()

    {
        /* @var ArrayNodeDefinition $node */
        $node = parent::checkFactoryConf($builder);

        $node = $node
            ->beforeNormalization()
                ->ifArray()

Object operator not indented correctly; expected 12 spaces but found 16

                ->then(static function ($value) {

Object operator not indented correctly; expected 12 spaces but found 16

The opening parenthesis of a multi-line function call should be the last content on the line.

                    if (isset($value['dsn'])) {
                        foreach ($value['items'] as &$v) {
                            if (!array_key_exists('dsn', $v['check'])) {
                                $v['check']['dsn'] = $value['dsn'];
                            }
                        }
                    }

                    return $value;
                })

For multi-line function calls, the closing parenthesis should be on a new line.

            ->end();

        $node->children()->scalarNode('dsn')->defaultNull()->end();

        return $node;

The expression return $node returns the type Symfony\Component\Config\Definition\Builder\NodeDefinition which includes types incompatible with the type-hinted return Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition.

    }

    protected function _check(ArrayNodeDefinition $node): ArrayNodeDefinition

Missing doc comment for function _check()

Protected method name "Plugin::_check" must not be prefixed with an underscore

    {
        $node = $node
            ->children()
                ->arrayNode('check')

Object operator not indented correctly; expected 12 spaces but found 16

                    ->beforeNormalization()

Object operator not indented correctly; expected 12 spaces but found 20

                        ->ifString()

Object operator not indented correctly; expected 12 spaces but found 24

                        ->then(static function ($v) { return ['dsn' => $v]; })

Object operator not indented correctly; expected 12 spaces but found 24

Opening brace must be the last content on the line

Closing brace must be on a line by itself

                    ->end()
                    ->children()
                        ->scalarNode('queue')->isRequired()->end()
                        ->integerNode('warningThreshold')->defaultValue(null)->end()
                        ->integerNode('criticalThreshold')->defaultValue(100)->end()
                        ->scalarNode('host')->defaultValue('localhost')->end()
                        ->integerNode('port')->defaultValue(5672)->end()
                        ->scalarNode('user')->defaultValue('guest')->end()
                        ->scalarNode('password')->defaultValue('guest')->end()
                        ->scalarNode('vhost')->defaultValue('/')->end()
                        ->scalarNode('dsn')->defaultNull()->end()
                    ->end()
                ->end()
            ->end();

        $this->_addition($node);

        return $node;
    }
}