Configuration::addGroups() - Code Metrics - Inspection of "~" - turnaev/monitor-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b2d2e1...8cfc77 )

by Vladimir

created 2018-10-08 07:36 UTC

Configuration::addGroups() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes

Metric	Value
eloc	8
dl	0
loc	10
ccs	9
cts	9
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

/**

 * This file is part of the `tvi/monitor-bundle` project.

 * (c) https://github.com/turnaev/monitor-bundle/graphs/contributors

 * For the full copyright and license information, please view the LICENSE.md

 * file that was distributed with this source code.

*/

Coding Style introduced 2018-09-26 08:01 UTC by

PHP version not specified

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @category tag in file comment

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @package tag in file comment

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @author tag in file comment

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @license tag in file comment

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @link tag in file comment

namespace Tvi\MonitorBundle\DependencyInjection;

use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;

use Symfony\Component\Config\Definition\Builder\TreeBuilder;

use Symfony\Component\Config\Definition\ConfigurationInterface;

use Tvi\MonitorBundle\Check\CheckPluginFinder;

/**

 * This class contains the configuration information for the bundle.

 * This information is solely responsible for how the different configuration

 * sections are normalized, and merged.

 * @author Vladimir Turnaev <[email protected]>

*/

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @category tag in class comment

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @package tag in class comment

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @license tag in class comment

Coding Style introduced 2018-09-26 08:01 UTC by

Missing @link tag in class comment

class Configuration implements ConfigurationInterface

/**

Coding Style introduced 2018-09-24 09:59 UTC by

Missing short description in doc comment

     * @var array

*/

    private $checkPlugins = [];

Coding Style introduced 2018-10-05 08:58 UTC by

Private member variable "checkPlugins" must be prefixed with an underscore

    private $checkPluginClasses = [];

Coding Style introduced 2018-10-05 08:58 UTC by

Private member variable "checkPluginClasses" must be prefixed with an underscore

/**

Coding Style introduced 2018-10-05 08:58 UTC by

Parameter $pluginFinder should have a doc-comment as per coding-style.

     * Configuration constructor.

*/

    public function __construct(CheckPluginFinder $pluginFinder)

        $this->checkPluginClasses = $pluginFinder->find();

    public function getCheckPlugins(): array

Coding Style introduced 2018-10-05 09:04 UTC by

Missing doc comment for function getCheckPlugins()

        return $this->checkPlugins;

/**

     * Generates the configuration tree.

     * @return TreeBuilder

*/

    public function getConfigTreeBuilder()

        $treeBuilder = new TreeBuilder();

        $treeBuilder->root('tvi_monitor', 'array')

            ->children()

                ->append($this->addChecksSearchPaths())

Coding Style introduced 2018-10-05 08:58 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

                ->append($this->addGroups())

Coding Style introduced 2018-10-08 07:29 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

                ->append($this->addTags())

Coding Style introduced 2018-10-05 08:58 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

                ->append($this->addReporers())

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

                ->append($this->addChecks())

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

            ->end()

        ->end();

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 8

        return $treeBuilder;

    private function addChecks(): ArrayNodeDefinition

Coding Style introduced 2018-09-24 09:59 UTC by

Private method name "Configuration::addChecks" must be prefixed with an underscore

Coding Style introduced 2018-09-24 09:59 UTC by

Missing doc comment for function addChecks()

        $builder = new TreeBuilder();

        $checkPligins = $this->checkPlugins;

        $addChecks = function ($rootNode) use ($checkPligins, $builder) {

Unused Code introduced 2018-10-05 08:58 UTC by

The import $checkPligins is not used and could be removed.

            foreach ($this->checkPluginClasses as $checkPluginClass) {

                $checkPligin = new $checkPluginClass();

                $confMethods = array_filter(get_class_methods($checkPligin), static function ($n) {

Coding Style introduced 2018-10-03 08:53 UTC by

The opening parenthesis of a multi-line function call should be the last content on the line.

                    return preg_match('/Conf$/', $n);

});

Coding Style introduced 2018-10-03 08:53 UTC by

For multi-line function calls, the closing parenthesis should be on a new line.

                foreach ($confMethods as $confMethod) {

                    /* @var ArrayNodeDefinition $node */

                    $node = $checkPligin->$confMethod($builder);

                    $checkName = $node->getNode(true)->getName();

                    $serviceName = preg_replace('/_factory$/', '', $checkName);

                    $this->checkPlugins[$checkName] = [

                        'checkServicePath' => $checkPligin::PATH.\DIRECTORY_SEPARATOR.'check.yml',

                        'service' => $serviceName,

                        'pligin' => $checkPligin,

];

                    $rootNode->append($node);

100

101

102

            return $rootNode;

103

};

104

105

        $node = $builder

106

            ->root('checks', 'array')

107

            ->beforeNormalization()

108

            ->always(static function ($value) {

Coding Style introduced 2018-10-01 15:24 UTC by

The opening parenthesis of a multi-line function call should be the last content on the line.

109

                $value = $value ? $value : [];

110

                foreach ($value as $k => $v) {

111

                    $newK = str_replace('(s)', '_factory', $k);

112

                    if ($newK !== $k) {

113

                        $value[$newK] = $value[$k];

114

                        unset($value[$k]);

115

116

117

118

                return $value;

119

})

Coding Style introduced 2018-10-04 11:37 UTC by

For multi-line function calls, the closing parenthesis should be on a new line.

120

            ->end()

121

            ->children(); //--

122

        $node = $addChecks($node)

123

            ->end();

124

125

        return $node;

126

127

128

    private function addReporers(): ArrayNodeDefinition

Coding Style introduced 2018-09-24 09:59 UTC by

Missing doc comment for function addReporers()

Coding Style introduced 2018-09-24 09:59 UTC by

Private method name "Configuration::addReporers" must be prefixed with an underscore

129

130

        return (new TreeBuilder())

131

            ->root('reporters', 'array')

132

            ->children()

133

                ->arrayNode('mailer')

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

134

                    ->children()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

135

                        ->scalarNode('recipient')

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 24

136

                            ->isRequired()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 28

137

                            ->cannotBeEmpty()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 28

138

                        ->end()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 24

139

                        ->scalarNode('sender')

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 24

140

                            ->isRequired()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 28

141

                            ->cannotBeEmpty()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 28

142

                        ->end()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 24

143

                        ->scalarNode('subject')

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 24

144

                            ->isRequired()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 28

145

                            ->cannotBeEmpty()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 28

146

                        ->end()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 24

147

                        ->booleanNode('send_on_warning')

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 24

148

                            ->defaultTrue()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 28

149

                        ->end()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 24

150

                    ->end()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

151

                ->end()

Coding Style introduced 2018-09-24 09:59 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

152

            ->end();

153

154

155

    private function addTags(): ArrayNodeDefinition

Coding Style introduced 2018-09-24 09:59 UTC by

Missing doc comment for function addTags()

Coding Style introduced 2018-09-24 09:59 UTC by

Private method name "Configuration::addTags" must be prefixed with an underscore

156

157

        return (new TreeBuilder())

158

            ->root('tags', 'array')

159

            ->prototype('array')

Bug introduced 2018-10-08 07:29 UTC by

The method prototype() does not exist on Symfony\Component\Config...\Builder\NodeDefinition. It seems like you code against a sub-type of Symfony\Component\Config...\Builder\NodeDefinition such as Symfony\Component\Config...der\ArrayNodeDefinition. ( Ignorable by Annotation )

160

                ->children()

Coding Style introduced 2018-10-08 07:29 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

161

                    ->scalarNode('name')->end()

Coding Style introduced 2018-10-08 07:29 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

162

                    ->scalarNode('descr')->end()

Coding Style introduced 2018-10-08 07:29 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

163

                ->end()

Coding Style introduced 2018-10-08 07:29 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

164

            ->end();

165

166

167

    private function addGroups(): ArrayNodeDefinition

Coding Style introduced 2018-10-08 07:29 UTC by

Private method name "Configuration::addGroups" must be prefixed with an underscore

Coding Style introduced 2018-10-08 07:29 UTC by

Missing doc comment for function addGroups()

168

169

        return (new TreeBuilder())

170

            ->root('groups', 'array')

171

            ->prototype('array')

172

                ->children()

Coding Style introduced 2018-10-08 07:29 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

173

                    ->scalarNode('name')->end()

Coding Style introduced 2018-10-08 07:29 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

174

                    ->scalarNode('descr')->end()

Coding Style introduced 2018-10-08 07:29 UTC by

Object operator not indented correctly; expected 12 spaces but found 20

175

                ->end()

Coding Style introduced 2018-10-08 07:29 UTC by

Object operator not indented correctly; expected 12 spaces but found 16

176

            ->end();

177

178

179

    private function addChecksSearchPaths(): ArrayNodeDefinition

Coding Style introduced 2018-10-05 08:58 UTC by

Private method name "Configuration::addChecksSearchPaths" must be prefixed with an underscore

Coding Style introduced 2018-10-05 08:58 UTC by

Missing doc comment for function addChecksSearchPaths()

180

181

        return (new TreeBuilder())

182

            ->root('checks_search_paths', 'array')

183

            ->prototype('scalar')->end();

184

185

186

turnaev / monitor-bundle

Push — master ( b2d2e1...8cfc77 )

Configuration::addGroups() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like