RunnerManager::findChecksSorted() - Code Metrics - Inspection of "~" - turnaev/monitor-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 13c004...92d87a )

by Vladimir

created 2018-10-15 04:10 UTC

RunnerManager::findChecksSorted() A

↳ Parent: RunnerManager

Complexity

Conditions	3
Paths	1

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
eloc	4
dl	0
loc	9
ccs	6
cts	6
cp	1
rs	10
c	0
b	0
f	0
cc	3
nc	1
nop	3
crap	3

<?php

/**
 * This file is part of the `tvi/monitor-bundle` project.
 *
 * (c) https://github.com/turnaev/monitor-bundle/graphs/contributors
 *
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */


namespace Tvi\MonitorBundle\Runner;

use Tvi\MonitorBundle\Check\CheckInterface;
use Tvi\MonitorBundle\Check\Group;
use Tvi\MonitorBundle\Check\CheckManager;
use Tvi\MonitorBundle\Check\Tag;

/**

 * @author Vladimir Turnaev <[email protected]>
 */

class RunnerManager
{
    /**

     * @var CheckManager
     */
    protected $checkManager;

    public function __construct(CheckManager $checkManager)

    {
        $this->checkManager = $checkManager;
    }

    /**

     * @param ?string|string[] $ids

     * @param ?string|string[] $groups

     * @param ?string|string[] $tags

     */

    public function getRunner($ids = null, $groups = null, $tags = null): Runner
    {
        $checks = $this->checkManager->findChecks($ids, $groups, $tags);

        return new Runner(null, $checks);
    }

    /**

     * @param ?string|string[] $ids

     * @param ?string|string[] $groups

     * @param ?string|string[] $tags

     *
     * @return CheckInterface[]
     */
    public function findChecks($ids = null, $groups = null, $tags = null): array
    {
        return $this->checkManager->findChecks($ids, $groups, $tags);
    }

    /**

     * @param ?string|string[] $ids

     * @param ?string|string[] $groups

     * @param ?string|string[] $tags

     *
     * @return CheckInterface[]
     */
    public function findChecksSorted($ids = null, $groups = null, $tags = null): array
    {
        $checks = $this->findChecks($ids, $groups, $tags);

        uasort($checks, static function (CheckInterface $a, CheckInterface $b) {

            return ($a->getGroup() === $b->getGroup()) ? 0 : ($a->getGroup() < $b->getGroup() ? -1 : 1);
        });
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.

        return $checks;
    }

    /**

     * @param ?string|string[] $tags

     *
     * @return Tag[]
     */
    public function findTags($tags = null): array
    {
        return $this->checkManager->findTags($tags);

    }

    /**

     * @param ?string|string[] $groups

     *
     * @return Group[]
     */
    public function findGroups($groups = null): array
    {
        return $this->checkManager->findGroups($groups);
    }
}


1		<?php
2
3		/**
4		* This file is part of the `tvi/monitor-bundle` project.
5		*
6		* (c) https://github.com/turnaev/monitor-bundle/graphs/contributors
7		*
8		* For the full copyright and license information, please view the LICENSE.md
9		* file that was distributed with this source code.
10		*/
		0 ignored issues – show Coding Style introduced 2018-10-03 11:42 UTC by Report Bug Copy Issue Report PHP version not specified Loading history... Coding Style introduced 2018-10-03 11:42 UTC by Report Bug Copy Issue Report Missing @category tag in file comment Loading history... Coding Style introduced 2018-10-03 11:42 UTC by Report Bug Copy Issue Report Missing @package tag in file comment Loading history... Coding Style introduced 2018-10-03 11:42 UTC by Report Bug Copy Issue Report Missing @author tag in file comment Loading history... Coding Style introduced 2018-10-03 11:42 UTC by Report Bug Copy Issue Report Missing @license tag in file comment Loading history... Coding Style introduced 2018-10-03 11:42 UTC by Report Bug Copy Issue Report Missing @link tag in file comment Loading history...
11
12		namespace Tvi\MonitorBundle\Runner;
13
14		use Tvi\MonitorBundle\Check\CheckInterface;
15		use Tvi\MonitorBundle\Check\Group;
16		use Tvi\MonitorBundle\Check\CheckManager;
17		use Tvi\MonitorBundle\Check\Tag;
18
19		/**
		0 ignored issues – show Coding Style introduced 2018-09-27 10:13 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
20		* @author Vladimir Turnaev <[email protected]>
21		*/
		0 ignored issues – show Coding Style introduced 2018-10-03 11:42 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2018-10-03 11:42 UTC by Report Bug Copy Issue Report Missing @package tag in class comment Loading history... Coding Style introduced 2018-10-03 11:42 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2018-10-03 11:42 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
22		class RunnerManager
23		{
24		/**
		0 ignored issues – show Coding Style introduced 2018-09-24 09:59 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
25		* @var CheckManager
26		*/
27		protected $checkManager;
28
29	94	public function __construct(CheckManager $checkManager)
		0 ignored issues – show Coding Style introduced 2018-10-01 16:50 UTC by Report Bug Copy Issue Report Missing doc comment for function __construct() Loading history...
30		{
31	94	$this->checkManager = $checkManager;
32	94	}
33
34		/**
		0 ignored issues – show Coding Style introduced 2018-10-01 16:50 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
35		* @param ?string\|string[] $ids
		0 ignored issues – show Coding Style introduced 2018-10-01 15:46 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
36		* @param ?string\|string[] $groups
		0 ignored issues – show Coding Style introduced 2018-10-01 15:46 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
37		* @param ?string\|string[] $tags
		0 ignored issues – show Coding Style introduced 2018-10-01 15:46 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
38		*/
		0 ignored issues – show Coding Style introduced 2018-10-01 16:50 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
39	62	public function getRunner($ids = null, $groups = null, $tags = null): Runner
40		{
41	62	$checks = $this->checkManager->findChecks($ids, $groups, $tags);
42
43	62	return new Runner(null, $checks);
44		}
45
46		/**
		0 ignored issues – show Coding Style introduced 2018-10-01 13:07 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
47		* @param ?string\|string[] $ids
		0 ignored issues – show Coding Style introduced 2018-10-01 13:07 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
48		* @param ?string\|string[] $groups
		0 ignored issues – show Coding Style introduced 2018-10-01 15:46 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
49		* @param ?string\|string[] $tags
		0 ignored issues – show Coding Style introduced 2018-10-01 13:07 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
50		*
51		* @return CheckInterface[]
52		*/
53	12	public function findChecks($ids = null, $groups = null, $tags = null): array
54		{
55	12	return $this->checkManager->findChecks($ids, $groups, $tags);
56		}
57
58		/**
		0 ignored issues – show Coding Style introduced 2018-10-01 13:07 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
59		* @param ?string\|string[] $ids
		0 ignored issues – show Coding Style introduced 2018-10-15 04:16 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
60		* @param ?string\|string[] $groups
		0 ignored issues – show Coding Style introduced 2018-10-01 15:46 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
61		* @param ?string\|string[] $tags
		0 ignored issues – show Coding Style introduced 2018-10-15 04:16 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
62		*
63		* @return CheckInterface[]
64		*/
65	1	public function findChecksSorted($ids = null, $groups = null, $tags = null): array
66		{
67	1	$checks = $this->findChecks($ids, $groups, $tags);
68
69	1	uasort($checks, static function (CheckInterface $a, CheckInterface $b) {
		0 ignored issues – show Coding Style introduced 2018-10-10 07:29 UTC by Report Bug Copy Issue Report The opening parenthesis of a multi-line function call should be the last content on the line. Loading history...
70	1	return ($a->getGroup() === $b->getGroup()) ? 0 : ($a->getGroup() < $b->getGroup() ? -1 : 1);
71	1	});
		0 ignored issues – show Coding Style introduced 2018-10-15 04:16 UTC by Report Bug Copy Issue Report For multi-line function calls, the closing parenthesis should be on a new line. If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line: someFunctionCall( $firstArgument, $secondArgument, $thirdArgument ); // Closing parenthesis on a new line. Loading history...
72
73	1	return $checks;
74		}
75
76		/**
		0 ignored issues – show Coding Style introduced 2018-10-15 04:16 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
77		* @param ?string\|string[] $tags
		0 ignored issues – show Coding Style introduced 2018-10-01 15:46 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
78		*
79		* @return Tag[]
80		*/
81	12	public function findTags($tags = null): array
82		{
83	12	return $this->checkManager->findTags($tags);
		0 ignored issues – show Bug Best Practice introduced 2018-10-01 13:21 UTC by Report Bug Copy Issue Report The expression `return $this->checkManager->findTags($tags)` returns an array which contains values of type `Tvi\MonitorBundle\Check\Group` which are incompatible with the documented value type `Tvi\MonitorBundle\Check\Tag`. Loading history...
84		}
85
86		/**
		0 ignored issues – show Coding Style introduced 2018-10-01 13:07 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
87		* @param ?string\|string[] $groups
		0 ignored issues – show Coding Style introduced 2018-10-15 04:16 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history...
88		*
89		* @return Group[]
90		*/
91	11	public function findGroups($groups = null): array
92		{
93	11	return $this->checkManager->findGroups($groups);
94		}
95		}
96

turnaev / monitor-bundle

Push — master ( 13c004...92d87a )

RunnerManager::findChecksSorted() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like